[issue28221] Unused indata in test_ssl.ThreadedTests.test_asyncore_server

[Martin Panter]

Changes by Martin Panter :


--
resolution:  -> fixed
stage: needs patch -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28221] Unused indata in test_ssl.ThreadedTests.test_asyncore_server

[Roundup Robot]

Roundup Robot added the comment:

New changeset 4a1e1715efc3 by Martin Panter in branch '2.7':
Issue #28221: Remove unused assignment from test_asyncore_server()
https://hg.python.org/cpython/rev/4a1e1715efc3

New changeset 97ff9934ad2d by Martin Panter in branch '3.5':
Issue #28221: Remove unused assignment from test_asyncore_server()
https://hg.python.org/cpython/rev/97ff9934ad2d

New changeset d8d047217da1 by Martin Panter in branch '3.6':
Issue #28221: Merge SSL test cleanup from 3.5 into 3.6
https://hg.python.org/cpython/rev/d8d047217da1

New changeset 65e83846ed51 by Martin Panter in branch 'default':
Issue #28221: Merge SSL test cleanup from 3.6
https://hg.python.org/cpython/rev/65e83846ed51

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28221] Unused indata in test_ssl.ThreadedTests.test_asyncore_server

[Christian Heimes]

Christian Heimes added the comment:

Thanks for your investigation.

--
assignee: christian.heimes -> 

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28221] Unused indata in test_ssl.ThreadedTests.test_asyncore_server

[Martin Panter]

Martin Panter added the comment:

Actually in the Py 3 branch, I found an earlier revision that added 
indata="FOO\n": r59506 (Dec 2007).

Anyway, the server in the test case just does a simple lower() call on the 
data, so I think the simpler FOO line may be fine on its own.

--
stage:  -> needs patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28221] Unused indata in test_ssl.ThreadedTests.test_asyncore_server

[Martin Panter]

New submission from Martin Panter:

In r62273 (Apr 2008), method testAsyncoreServer() was added to the py3k branch 
with indata="FOO\n". In r64578 (Jun 2008), this test method was added to the Py 
2 branch, but with indata = "TEST MESSAGE of mixed case\n". Later, r80598 added 
the mixed case line to the Py 3 branch, but it is not used because the original 
FOO line overwrites it. Then revision 221a1f9155e2 backported the Py 3 code to 
2.7. So now both versions include the mixed case line but neither use it.

I haven’t investigated, but I presume either the mixed case version would test 
more stuff and should be enabled, or it would be overkill and should be dropped 
in favour of the simpler line.

--
assignee: christian.heimes
components: SSL, Tests
messages: 277085
nosy: christian.heimes, martin.panter
priority: normal
severity: normal
status: open
title: Unused indata in test_ssl.ThreadedTests.test_asyncore_server
type: enhancement
versions: Python 2.7, Python 3.5, Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com