[issue30177] pathlib.resolve(strict=False) only includes first child

Ned Deily added the comment: New changeset a77a35d70ba8aed047e63d4d9f7d0554e98d4c4b by Ned Deily (Antoine Pietri) in branch 'master': bpo-30177: add NEWS entry (#2135) https://github.com/python/cpython/commit/a77a35d70ba8aed047e63d4d9f7d0554e98d4c4b --

[issue30177] pathlib.resolve(strict=False) only includes first child

Changes by Antoine Pietri : -- pull_requests: +2189 ___ Python tracker ___ ___

[issue30177] pathlib.resolve(strict=False) only includes first child

Ned Deily added the comment: New changeset 8399a177de8bfa860a66e96665488c17199cb9d2 by Ned Deily (Antoine Pietri) in branch '3.6': [3.6] bpo-30177: add NEWS entry (#2134) https://github.com/python/cpython/commit/8399a177de8bfa860a66e96665488c17199cb9d2 --

[issue30177] pathlib.resolve(strict=False) only includes first child

Changes by Antoine Pietri : -- pull_requests: +2188 ___ Python tracker ___ ___

[issue30177] pathlib.resolve(strict=False) only includes first child

Steve Dower added the comment: Good point about not needing 3.5. Buildbots were clean, so I merged it. Thanks Antoine! -- resolution: -> fixed stage: backport needed -> resolved status: open -> closed versions: -Python 3.5 ___ Python tracker

[issue30177] pathlib.resolve(strict=False) only includes first child

Steve Dower added the comment: New changeset ceabf9acf03f9bbe660d856bff90ecab475ab543 by Steve Dower (Antoine Pietri) in branch '3.6': bpo-30177: pathlib: include the full path in resolve(strict=False) (#1893) (#1985)

[issue30177] pathlib.resolve(strict=False) only includes first child

Antoine Pietri added the comment: The only backport was for 3.6 as the previous versions don't have the strict= parameter. PR submitted here: https://github.com/python/cpython/pull/1985 -- ___ Python tracker

[issue30177] pathlib.resolve(strict=False) only includes first child

Changes by Antoine Pietri : -- pull_requests: +2052 ___ Python tracker ___ ___

[issue30177] pathlib.resolve(strict=False) only includes first child

Steve Dower added the comment: New changeset add98eb4fe41baeaa70fbd4ccc020833740609a4 by Steve Dower (Antoine Pietri) in branch 'master': bpo-30177: pathlib: include the full path in resolve(strict=False) (#1893) https://github.com/python/cpython/commit/add98eb4fe41baeaa70fbd4ccc020833740609a4

[issue30177] pathlib.resolve(strict=False) only includes first child

Steve Dower added the comment: As usual, I can easily hit merge but may not be able to get to the backport immediately. Someone else can feel free to cherrypick and submit the PRs and I'll hit merge on them. We should also watch the buildbots for failures though before backporting.

[issue30177] pathlib.resolve(strict=False) only includes first child

Antoine Pietri added the comment: The code has been reviewed by (the other) Antoine, I guess there is now everything needed to merge it? -- ___ Python tracker

[issue30177] pathlib.resolve(strict=False) only includes first child

Antoine Pietri added the comment: I updated the PR to fix the Windows part of the issue thanks to Zachary who gave me access to a Windows machine. -- ___ Python tracker

[issue30177] pathlib.resolve(strict=False) only includes first child

Antoine Pietri added the comment: So, I asked a friend to check again with a more recent Python version on Windows and he can't reproduce the documented behavior, so the bug seems to also be present on Windows. My patch doesn't address that for now, which explains why the build fails (and why

[issue30177] pathlib.resolve(strict=False) only includes first child

Zachary Ware added the comment: > do we have any buildbots running as admin for symlink tests? No, as far as I know. I just took Eryk's suggestion and gave the buildslave user on my Windows 8.1 bot rights to create symbolic links, though. It's now rebooting after updates, we'll see how it

[issue30177] pathlib.resolve(strict=False) only includes first child

Eryk Sun added the comment: > Ah, looks like they require symlinks for the whole test, > which means you need to be admin when running them on Windows. The privilege to create symlinks isn't filtered out of a standard user's token. Are there any buildbots already running as a standard user?

[issue30177] pathlib.resolve(strict=False) only includes first child

Antoine Pietri added the comment: I added a fix for the tests and the code. -- ___ Python tracker ___ ___

[issue30177] pathlib.resolve(strict=False) only includes first child

Changes by Roundup Robot : -- pull_requests: +1969 ___ Python tracker ___

[issue30177] pathlib.resolve(strict=False) only includes first child

Steve Dower added the comment: Ah, looks like they require symlinks for the whole test, which means you need to be admin when running them on Windows. Zach - do we have any buildbots running as admin for symlink tests? -- nosy: +zach.ware ___

[issue30177] pathlib.resolve(strict=False) only includes first child

Steve Dower added the comment: The initial fix should be easy: --- a/Lib/pathlib.py +++ b/Lib/pathlib.py @@ -329,8 +329,6 @@ class _PosixFlavour(_Flavour): if e.errno != EINVAL: if strict: raise -

[issue30177] pathlib.resolve(strict=False) only includes first child

Antoine Pietri added the comment: I'm on it. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue30177] pathlib.resolve(strict=False) only includes first child

Ned Deily added the comment: We have less than 2 weeks until cutoff for 3.6.2 so it would be great if someone would take this on. -- ___ Python tracker

[issue30177] pathlib.resolve(strict=False) only includes first child

Zopieux added the comment: I agree bpo-30177 is not a suitable fix for this issue, as it fixes the doc instead of fixing the actual underlying bug in the function behavior. This bug can lead to files being added to the wrong (parent) directory, which is quite critical. -- nosy:

[issue30177] pathlib.resolve(strict=False) only includes first child

Steve Dower added the comment: Ah, didn't catch that it doesn't occur on Windows - that explains why I've never seen it before. Yes, definitely fix and backport. Adding the RMs in case they want to delay any upcoming releases to get the fix. -- nosy: +larry, ned.deily priority:

[issue30177] pathlib.resolve(strict=False) only includes first child

Antoine Pitrou added the comment: This is definitely a bug and I think the fixes should be backported. -- versions: +Python 3.5 ___ Python tracker ___

[issue30177] pathlib.resolve(strict=False) only includes first child

Antoine Pietri added the comment: By the way, I'm pasting what I said on the PR here: For what it's worth, this bug was the cause of an important downtime in our organization, because someone needed to normalize a path that was later passed to a .mkdir(parents=True), and it was, in some

[issue30177] pathlib.resolve(strict=False) only includes first child

Steve Dower added the comment: This is definitely a bug if it really behaves as described. PRs for fixing the functionality are welcome - I'm inclined to say fix it in 3.6 as well, but it might be too big a behavioural change if people are already working around it. -- nosy:

[issue30177] pathlib.resolve(strict=False) only includes first child

Antoine Pietri added the comment: In Windows/Python 3.6, the behavior matches the documented one, so this could actually be an important silent bug when executing a code wrote for Windows in another OS. I'd argue to fix it in 3.6 too. -- ___ Python

[issue30177] pathlib.resolve(strict=False) only includes first child

Richard Cooper added the comment: Pull Request (PR 1649) treats this as a documentation problem. I would argue that the documentation is correct and this is a bug in the code. The `strict` flag was added as a result of issue19717. The decision on what to do when strict=False seems to come in

[issue30177] pathlib.resolve(strict=False) only includes first child

Changes by Marcel Plch : -- pull_requests: +1744 ___ Python tracker ___ ___

[issue30177] pathlib.resolve(strict=False) only includes first child

Antoine Pietri added the comment: I can reproduce this bug. This behavior is really confusing. -- nosy: +seirl ___ Python tracker ___

[issue30177] pathlib.resolve(strict=False) only includes first child

Changes by Serhiy Storchaka : -- nosy: +pitrou, serhiy.storchaka ___ Python tracker ___

[issue30177] pathlib.resolve(strict=False) only includes first child

New submission from Michael Shuffett: According to the documentation https://docs.python.org/3/library/pathlib.html#pathlib.Path.resolve If strict is False, the path is resolved as far as possible and any remainder is appended without checking whether it exists. The current behavior is not