[issue30258] [2.7] regrtest: handle child process crash

2017-06-16 Thread STINNER Victor 

STINNER Victor added the comment:


New changeset a0ccc54e6dffacf9e7c06f2a3e9056d2d35d21eb by Victor Stinner in 
branch '3.6':
Synchronize libregrtest from master to 3.6 (#2244)
https://github.com/python/cpython/commit/a0ccc54e6dffacf9e7c06f2a3e9056d2d35d21eb


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30258] [2.7] regrtest: handle child process crash

2017-06-16 Thread STINNER Victor 

Changes by STINNER Victor :


--
pull_requests: +2291

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30258] [2.7] regrtest: handle child process crash

2017-05-16 Thread STINNER Victor 

STINNER Victor added the comment:

Python 2.7 now has test_regrtest and test_regrtest pass on all 2.7 buildbots, 
so I close the issue.

--
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30258] [2.7] regrtest: handle child process crash

2017-05-09 Thread STINNER Victor 

STINNER Victor added the comment:


New changeset 74683fc6247c522ae955a6e7308b8ff51def35d8 by Victor Stinner in 
branch 'master':
bpo-30258: regrtest: Fix run_tests_multiprocess() (#1479)
https://github.com/python/cpython/commit/74683fc6247c522ae955a6e7308b8ff51def35d8


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30258] [2.7] regrtest: handle child process crash

2017-05-05 Thread STINNER Victor 

STINNER Victor added the comment:

> You just pressed the merge button 2 minutes before I finished a review.

Oh sorry, I didn't expect a review on this small change.

> Do you mind to port changes to 3.x?

I created https://github.com/python/cpython/pull/1479 for the 
run_tests_multiprocess() bugfix.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30258] [2.7] regrtest: handle child process crash

2017-05-05 Thread STINNER Victor 

Changes by STINNER Victor :


--
resolution: fixed -> 
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30258] [2.7] regrtest: handle child process crash

2017-05-05 Thread STINNER Victor 

Changes by STINNER Victor :


--
pull_requests: +1578

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30258] [2.7] regrtest: handle child process crash

2017-05-05 Thread Serhiy Storchaka 

Serhiy Storchaka added the comment:

Do you mind to port changes to 3.x?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30258] [2.7] regrtest: handle child process crash

2017-05-05 Thread Serhiy Storchaka 

Serhiy Storchaka added the comment:

You just pressed the merge button 2 minutes before I finished a review.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30258] [2.7] regrtest: handle child process crash

2017-05-05 Thread STINNER Victor 

STINNER Victor added the comment:

@Serhiy: I fixed the bug you found. Don't hesitate to propose directly a PR if 
I missed something (or open an issue, it's up to you).

At least, regrtest of Python 2.7 should now handle correctly crashes when using 
-jN.

--
resolution:  -> fixed
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30258] [2.7] regrtest: handle child process crash

2017-05-05 Thread STINNER Victor 

STINNER Victor added the comment:


New changeset 228da42961ac9bf2990e6c191ecc9b762ead617c by Victor Stinner in 
branch '2.7':
bpo-30258: Fix handling of child error in regrtest (#1477)
https://github.com/python/cpython/commit/228da42961ac9bf2990e6c191ecc9b762ead617c


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30258] [2.7] regrtest: handle child process crash

2017-05-05 Thread STINNER Victor 

Changes by STINNER Victor :


--
pull_requests: +1576

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30258] [2.7] regrtest: handle child process crash

2017-05-03 Thread STINNER Victor 

STINNER Victor added the comment:

Ooops, there is a bug in my pushed changed, spotted by Serhiy:

>  # Strip last refcount output line if it exists, since it
 # comes from the shutdown of the interpreter in the 
subcommand.
 stderr = debug_output_pat.sub("", stderr)
+
+if retcode != 0:
+result = (CHILD_ERROR, "Exit code %s" % retcode)
+output.put((test, stdout.rstrip(), stderr.rstrip(),
+result))
+

Missed return?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30258] [2.7] regrtest: handle child process crash

2017-05-03 Thread STINNER Victor 

STINNER Victor added the comment:


New changeset c991eb280e60ed25c68a5332bd8633959e9f7113 by Victor Stinner in 
branch '2.7':
bpo-30258: regrtest handles child process crash (#1431)
https://github.com/python/cpython/commit/c991eb280e60ed25c68a5332bd8633959e9f7113


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30258] [2.7] regrtest: handle child process crash

2017-05-03 Thread Serhiy Storchaka 

Serhiy Storchaka added the comment:

Victor, you are just incredible!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30258] [2.7] regrtest: handle child process crash

2017-05-03 Thread STINNER Victor 

Changes by STINNER Victor :


--
pull_requests: +1536

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30258] [2.7] regrtest: handle child process crash

2017-05-03 Thread STINNER Victor 

New submission from STINNER Victor:

In the master branch, regrtest in multiprocess mode handles well crash of child 
processes. In 2.7, regrtest handles them badly: see issue #30254.

Attached PR backports the CHILD_ERROR status from regrtest master and adds code 
to handle crash (or any non-zero exit code) of the child process (a worker 
running an unit test).

--
components: Tests
messages: 292904
nosy: haypo, serhiy.storchaka
priority: normal
severity: normal
status: open
title: [2.7] regrtest: handle child process crash
versions: Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com