[issue32277] SystemError via chmod(symlink, ..., follow_symlinks=False)

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue32277] SystemError via chmod(symlink, ..., follow_symlinks=False)

Serhiy Storchaka added the comment: New changeset d1cb1067a82b11280204e36b695e786a5a3ca221 by Serhiy Storchaka (Miss Islington (bot)) in branch '3.6': bpo-32277: Fix exception raised from chmod(..., follow_symlinks=False) (GH-4797) (#4869)

[issue32277] SystemError via chmod(symlink, ..., follow_symlinks=False)

Serhiy Storchaka added the comment: I was going to request a test, but the fix is obvious and writing a test for this case can be not easy. Thank you Anthony for your report and patch. -- ___ Python tracker

[issue32277] SystemError via chmod(symlink, ..., follow_symlinks=False)

Change by Roundup Robot : -- pull_requests: +4761 ___ Python tracker ___

[issue32277] SystemError via chmod(symlink, ..., follow_symlinks=False)

Serhiy Storchaka added the comment: New changeset 233ef249cc5c18d796fb581747179c5e062b4083 by Serhiy Storchaka (Anthony Sottile) in branch 'master': bpo-32277: Fix exception raised from chmod(..., follow_symlinks=False) (#4797)

[issue32277] SystemError via chmod(symlink, ..., follow_symlinks=False)

Anthony Sottile added the comment: I noticed it when I changed the test preconditions in https://github.com/python/cpython/pull/4783 I tried changing a test to trigger this (in this branch) but I found I was just implementing exactly the test in the `skip` condition which

[issue32277] SystemError via chmod(symlink, ..., follow_symlinks=False)

Change by Serhiy Storchaka : -- components: +Extension Modules type: -> behavior versions: -Python 3.8 ___ Python tracker

[issue32277] SystemError via chmod(symlink, ..., follow_symlinks=False)

Serhiy Storchaka added the comment: Does any existing test failed on such platform? -- nosy: +serhiy.storchaka ___ Python tracker

[issue32277] SystemError via chmod(symlink, ..., follow_symlinks=False)

Change by Anthony Sottile : -- keywords: +patch pull_requests: +4696 stage: -> patch review ___ Python tracker ___

[issue32277] SystemError via chmod(symlink, ..., follow_symlinks=False)

New submission from Anthony Sottile : While investigating https://bugs.python.org/issue31940 I noticed the following is raised as `SystemError` instead of the expected `NotImplementedError` (note: you need a platform with fchmodat but does not support nofollow) ``` touch