[issue33629] test_importlib creates a coredump on AMD64 FreeBSD 10.x Shared 3.7

[STINNER Victor]

Change by STINNER Victor :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33629] test_importlib creates a coredump on AMD64 FreeBSD 10.x Shared 3.7

[miss-islington]

miss-islington  added the comment:


New changeset fc0356d2a34719df517a5056bf1a3709850776cf by Miss Islington (bot) 
in branch '3.6':
bpo-33629: Prevent coredump in test_importlib (GH-7090)
https://github.com/python/cpython/commit/fc0356d2a34719df517a5056bf1a3709850776cf


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33629] test_importlib creates a coredump on AMD64 FreeBSD 10.x Shared 3.7

[miss-islington]

miss-islington  added the comment:


New changeset d9eb22c67c38b45764dd924801c72092770d200f by Miss Islington (bot) 
in branch '3.7':
bpo-33629: Prevent coredump in test_importlib (GH-7090)
https://github.com/python/cpython/commit/d9eb22c67c38b45764dd924801c72092770d200f


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33629] test_importlib creates a coredump on AMD64 FreeBSD 10.x Shared 3.7

[miss-islington]

Change by miss-islington :


--
pull_requests: +6740

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33629] test_importlib creates a coredump on AMD64 FreeBSD 10.x Shared 3.7

[miss-islington]

Change by miss-islington :


--
pull_requests: +6738

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33629] test_importlib creates a coredump on AMD64 FreeBSD 10.x Shared 3.7

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 483000e164ec68717d335767b223ae31b4b720cf by Victor Stinner in 
branch 'master':
bpo-33629: Prevent coredump in test_importlib (GH-7090)
https://github.com/python/cpython/commit/483000e164ec68717d335767b223ae31b4b720cf


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33629] test_importlib creates a coredump on AMD64 FreeBSD 10.x Shared 3.7

[Brett Cannon]

Change by Brett Cannon :


--
nosy: +ncoghlan, petr.viktorin

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33629] test_importlib creates a coredump on AMD64 FreeBSD 10.x Shared 3.7

[STINNER Victor]

STINNER Victor  added the comment:

The test creating the coredump has been added by bpo-32374.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33629] test_importlib creates a coredump on AMD64 FreeBSD 10.x Shared 3.7

[STINNER Victor]

Change by STINNER Victor :


--
keywords: +patch
pull_requests: +6725
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33629] test_importlib creates a coredump on AMD64 FreeBSD 10.x Shared 3.7

[STINNER Victor]

STINNER Victor  added the comment:

The problem comes from MultiPhaseExtensionModuleTests.test_bad_traverse() of 
Lib/test/test_importlib/extension/test_loader.py.

This test runs the following code:
---
import importlib.util as util
spec = util.find_spec('_testmultiphase')
spec.name = '_testmultiphase_with_bad_traverse'
m = spec.loader.create_module(spec)
---

I confirm that this script does crash and may generate a core dump:

vstinner@apu$ ./python x.py
Segmentation fault (core dumped)

Python traceback of the crash:

(gdb) py-bt
Traceback (most recent call first):
  
  File "", line 219, in _call_with_frames_removed
  File "", line 1043, in create_module
  File "x.py", line 4, in 
m = spec.loader.create_module(spec)

C traceback:

Program received signal SIGSEGV, Segmentation fault.
0x7fffeffb69f3 in bad_traverse (self=, 
visit=0x481b4d , arg=0x0)
at /home/vstinner/prog/python/master/Modules/_testmultiphase.c:628
628 Py_VISIT(m_state->integer);
(gdb) where
#0  0x7fffeffb69f3 in bad_traverse (self=, 
visit=0x481b4d , arg=0x0)
at /home/vstinner/prog/python/master/Modules/_testmultiphase.c:628
#1  0x00482866 in PyModule_FromDefAndSpec2TraceRefs (def=0x701b8ce0 
, 
spec=, 
origin='/home/vstinner/prog/python/master/build/lib.linux-x86_64-3.8-pydebug/_testmultiphase.cpython-38dm-x86_64-linux-gnu.so',
 loader_state=None, submodule_search_locations=None, _set_fileattr=True, 
_cached=None) at remote 0x70463330>, module_api_version=1013) at 
Objects/moduleobject.c:366
#2  0x0057ed89 in _PyImport_LoadDynamicModuleWithSpec (
spec=, 
origin='/home/vstinner/prog/python/master/build/lib.linux-x86_64-3.8-pydebug/_testmultiphase.cpython-38dm-x86_64-linux-gnu.so',
 loader_state=None, submodule_search_locations=None, _set_fileattr=True, 
_cached=None) at remote 0x70463330>, fp=0x0) at ./Python/importdl.c:193
#3  0x0057df53 in _imp_create_dynamic_impl (module=, 
spec=, 
origin='/home/vstinner/prog/python/master/build/lib.linux-x86_64-3.8-pydebug/_testmultiphase.cpython-38dm-x86_64-linux-gnu.so',
 loader_state=None, submodule_search_locations=None, _set_fileattr=True, 
_cached=None) at remote 0x70463330>, file=0x0) at Python/import.c:2174
#4  0x0057789f in _imp_create_dynamic (module=, args=0x77f1f630, nargs=1) at Python/clinic/import.c.h:289
(...)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33629] test_importlib creates a coredump on AMD64 FreeBSD 10.x Shared 3.7

[STINNER Victor]

New submission from STINNER Victor :

http://buildbot.python.org/all/#/builders/124/builds/315

Warning -- files was modified by test_importlib
  Before: []
  After:  ['python.core']

--
components: FreeBSD, Tests
messages: 317497
nosy: koobs, vstinner
priority: normal
severity: normal
status: open
title: test_importlib creates a coredump on AMD64 FreeBSD 10.x Shared 3.7
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com