[issue33873] False positives when running leak tests with -R 1:1

[STINNER Victor]

STINNER Victor  added the comment:

Pablo Galindo Salgado fixed the bug in master, I backported his fix to 2.7, 3.6 
and 3.7 branches. Thanks Pablo!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 2.7, Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33873] False positives when running leak tests with -R 1:1

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 1d55888a78bcefed3723fb7e48df2a75b4f0adb0 by Victor Stinner in 
branch '3.6':
bpo-33873: Backport regrtest from master to 3.7 (GH-7935) (GH-7937)
https://github.com/python/cpython/commit/1d55888a78bcefed3723fb7e48df2a75b4f0adb0


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33873] False positives when running leak tests with -R 1:1

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 5430c14aba319f83b18879575244ba429e8c1d81 by Victor Stinner in 
branch '2.7':
[2.7] bpo-33873: Backport regrtest from master (GH-7936)
https://github.com/python/cpython/commit/5430c14aba319f83b18879575244ba429e8c1d81


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33873] False positives when running leak tests with -R 1:1

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +7546

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33873] False positives when running leak tests with -R 1:1

[STINNER Victor]

STINNER Victor  added the comment:


New changeset d1f9481b7a2d31c40fca1347ef99d819eb656ce7 by Victor Stinner in 
branch '3.7':
bpo-33873: Backport regrtest from master to 3.7 (GH-7935)
https://github.com/python/cpython/commit/d1f9481b7a2d31c40fca1347ef99d819eb656ce7


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33873] False positives when running leak tests with -R 1:1

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +7544

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33873] False positives when running leak tests with -R 1:1

[STINNER Victor]

STINNER Victor  added the comment:

Since I didn't backport yet the commit 4ffe9c2b251f6e027b26250b7a2618e78d4edd22 
(format duration) from master to other branches, I will backport the commit 
58ed7307ea0b5c5aa052291ebc3030f314f938d8 (-R fix) manually to other branches 
with other recent regrtest changes.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33873] False positives when running leak tests with -R 1:1

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +7542

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33873] False positives when running leak tests with -R 1:1

[miss-islington]

Change by miss-islington :


--
pull_requests: +7541

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33873] False positives when running leak tests with -R 1:1

[miss-islington]

Change by miss-islington :


--
pull_requests: +7540

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33873] False positives when running leak tests with -R 1:1

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:


New changeset 58ed7307ea0b5c5aa052291ebc3030f314f938d8 by Pablo Galindo in 
branch 'master':
bpo-33873: Fix bug in `runtest.py` and add checks for invalid `-R` parameters 
(GH-7735)
https://github.com/python/cpython/commit/58ed7307ea0b5c5aa052291ebc3030f314f938d8


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33873] False positives when running leak tests with -R 1:1

[STINNER Victor]

STINNER Victor  added the comment:

> I think commit 4ffe9c2b251f6e027b26250b7a2618e78d4edd22 from bpo-33718 should 
> be backported IMO: ...

Once PR 7735 will be merged, we can backport recent regrtest commits at once 
into 3.7, then backport the 3.7 change to 3.6 and 2.7.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33873] False positives when running leak tests with -R 1:1

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

I think commit4ffe9c2b251f6e027b26250b7a2618e78d4edd22 from bpo-33718 should be 
backported IMO:

bpo-33718: regrtest: use format_duration() to display failed tests (GH-7686)
https://github.com/python/cpython/commit/4ffe9c2b251f6e027b26250b7a2618e78d4edd22

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33873] False positives when running leak tests with -R 1:1

[STINNER Victor]

STINNER Victor  added the comment:

Once PR 7735 will be merged, it may be worth it to backport the enhancements to 
other branches. See maybe bpo-33718 to check if there are other changes that 
should be backportd. It can help to backport the change to 2.7 (which is very 
different).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33873] False positives when running leak tests with -R 1:1

[STINNER Victor]

STINNER Victor  added the comment:


New changeset cac4fef8860e66a9da67d09762f5b614b9471a12 by Victor Stinner (Pablo 
Galindo) in branch 'master':
bpo-33873: regrtest: Add warning on -R 1:3 (GH-7736)
https://github.com/python/cpython/commit/cac4fef8860e66a9da67d09762f5b614b9471a12


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33873] False positives when running leak tests with -R 1:1

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

Updated PR7735 with the checks for invalid parameters.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33873] False positives when running leak tests with -R 1:1

[STINNER Victor]

STINNER Victor  added the comment:

I tested PR 7735:

vstinner@apu$ ./python -m test -R 0:0 test_os -m test_access
Run tests sequentially
0:00:00 load avg: 0.19 [1/1] test_os
beginning 0 repetitions


test_os leaked [] references, sum=0
test_os leaked [] memory blocks, sum=0
test_os failed

== Tests result: FAILURE ==

1 test failed:
test_os

Total duration: 63 ms
Tests result: FAILURE

vstinner@apu$ ./python -m test -R 0:1 test_os -m test_access
Run tests sequentially
0:00:00 load avg: 0.35 [1/1] test_os
beginning 1 repetitions
1
.
test_os leaked [280435] references, sum=280435
test_os leaked [91518] memory blocks, sum=91518
test_os leaked [4] file descriptors, sum=4
test_os failed

== Tests result: FAILURE ==

1 test failed:
test_os

Total duration: 95 ms
Tests result: FAILURE

vstinner@apu$ ./python -m test -R 1:0 test_os -m test_access
Run tests sequentially
0:00:00 load avg: 0.16 [1/1] test_os
beginning 1 repetitions
1
.
test_os leaked [] references, sum=0
test_os leaked [] memory blocks, sum=0
test_os failed

== Tests result: FAILURE ==

1 test failed:
test_os

Total duration: 95 ms
Tests result: FAILURE



Hum, we should require at least one run and at least one warmup: -R 1:1 should 
be the bare minimum.

By the way, it seems like negative numbers are currently accepted, whereas it 
doesn't make sense:

vstinner@apu$ ./python -m test -R 0:-2 test_list
Run tests sequentially
0:00:00 load avg: 0.31 [1/1] test_list
beginning -2 repetitions
(...)

It would fix this bug as well.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33873] False positives when running leak tests with -R 1:1

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
pull_requests: +7347

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33873] False positives when running leak tests with -R 1:1

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
keywords: +patch
pull_requests: +7346
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33873] False positives when running leak tests with -R 1:1

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

Let's make the buildbots happier!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33873] False positives when running leak tests with -R 1:1

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
title: False positives when running refleaks tests with -R 1:1 -> False 
positives when running leak tests with -R 1:1

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com