[issue39385] Add an assertNoLogs context manager to unittest TestCase

[Mark Dickinson]

Change by Mark Dickinson :


--
nosy: +mark.dickinson
nosy_count: 8.0 -> 9.0
pull_requests: +21362
pull_request: https://github.com/python/cpython/pull/22317

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39385] Add an assertNoLogs context manager to unittest TestCase

[Vinay Sajip]

Change by Vinay Sajip :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39385] Add an assertNoLogs context manager to unittest TestCase

[Vinay Sajip]

Vinay Sajip  added the comment:


New changeset 6b34d7b51e33fcb21b8827d927474ce9ed1f605c by Kit Choi in branch 
'master':
bpo-39385: Add an assertNoLogs context manager to unittest.TestCase (GH-18067)
https://github.com/python/cpython/commit/6b34d7b51e33fcb21b8827d927474ce9ed1f605c


--
nosy: +vinay.sajip

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39385] Add an assertNoLogs context manager to unittest TestCase

[Rémi Lapeyre]

Change by Rémi Lapeyre :


--
versions: +Python 3.10 -Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39385] Add an assertNoLogs context manager to unittest TestCase

[Kit Yan Choi]

Kit Yan Choi  added the comment:

Thank you for looking into this.
Yes, I agree it makes sense to have assertNoWarns for the same reason.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39385] Add an assertNoLogs context manager to unittest TestCase

[Rémi Lapeyre]

Rémi Lapeyre  added the comment:

This makes sense, should assertNoWarns() be added too?

--
nosy: +remi.lapeyre

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39385] Add an assertNoLogs context manager to unittest TestCase

[François Freitag]

Change by François Freitag :


--
nosy: +francois.freitag

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39385] Add an assertNoLogs context manager to unittest TestCase

[Kit Yan Choi]

Change by Kit Yan Choi :


--
keywords: +patch
pull_requests: +17459
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/18067

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39385] Add an assertNoLogs context manager to unittest TestCase

[Karthikeyan Singaravelan]

Change by Karthikeyan Singaravelan :


--
nosy: +xtreak

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39385] Add an assertNoLogs context manager to unittest TestCase

[SilentGhost]

Change by SilentGhost :


--
nosy: +ezio.melotti, michael.foord, rbcollins
versions: +Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39385] Add an assertNoLogs context manager to unittest TestCase

[Kit Yan Choi]

New submission from Kit Yan Choi :

assertLogs is really useful (issue18937). Unfortunately it does not cover the 
use cases where one wants to ensure no logs are emitted.

Similar to assertLogs, we can have a context manager for asserting no logs, 
something like this?:

with assertNoLogs(logger, level):
...


If logs are unexpected found, the test would fail with the logs captured 
included in the error message.

Happy to submit a PR if there is interest.

--
components: Library (Lib)
messages: 360250
nosy: Kit Yan Choi
priority: normal
severity: normal
status: open
title: Add an assertNoLogs context manager to unittest TestCase
type: enhancement

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com