[issue40061] Possible refleak in _asynciomodule.c future_add_done_callback()

Kyle Stanley added the comment: Thanks for the PR, Zackery. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue40061] Possible refleak in _asynciomodule.c future_add_done_callback()

miss-islington added the comment: New changeset 7b78e7f9fd77bb3280ee39fb74b86772a7d46a70 by Zackery Spytz in branch 'master': bpo-40061: Fix a possible refleak in _asynciomodule.c (GH-19748) https://github.com/python/cpython/commit/7b78e7f9fd77bb3280ee39fb74b86772a7d46a70 -- nosy:

[issue40061] Possible refleak in _asynciomodule.c future_add_done_callback()

Kyle Stanley added the comment: Antoine Pitrou wrote: > You're right that a Py_DECREF is missing there. However, it seems unlikely > that this is triggering the test failure, because `PyList_New(1)` will > practically never fail in normal conditions (and even making it deliberately > fail

[issue40061] Possible refleak in _asynciomodule.c future_add_done_callback()

Antoine Pitrou added the comment: You're right that a Py_DECREF is missing there. However, it seems unlikely that this is triggering the test failure, because `PyList_New(1)` will practically never fail in normal conditions (and even making it deliberately fail would be quite difficult).

[issue40061] Possible refleak in _asynciomodule.c future_add_done_callback()

Change by Zackery Spytz : -- keywords: +patch nosy: +ZackerySpytz nosy_count: 3.0 -> 4.0 pull_requests: +19069 stage: -> patch review pull_request: https://github.com/python/cpython/pull/19748 ___ Python tracker

[issue40061] Possible refleak in _asynciomodule.c future_add_done_callback()

Kyle Stanley added the comment: > When using the `test-with-buildbots` label in GH-19149 (which involved no C > changes), a failure occurred in test_asyncio for several of the refleak > buildbots. To clarify, the refleak failures occurred when i applied the label to the following commit:

[issue40061] Possible refleak in _asynciomodule.c future_add_done_callback()

New submission from Kyle Stanley : When using the `test-with-buildbots` label in GH-19149 (which involved no C changes), a failure occurred in test_asyncio for several of the refleak buildbots. Here's the output of a few: AMD64 Fedora Stable Refleaks PR: test_asyncio leaked [3, 3, 27]