[issue40179] Argument Clinic incorretly translates #elif

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40179] Argument Clinic incorretly translates #elif

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset bfda4db0d2c05eef4e4ae90d899d0b67cb2e33e5 by Serhiy Storchaka in 
branch '3.8':
[3.8] bpo-40179: Fix translation of #elif in Argument Clinic (GH-19364) 
(GH-19583)
https://github.com/python/cpython/commit/bfda4db0d2c05eef4e4ae90d899d0b67cb2e33e5


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40179] Argument Clinic incorretly translates #elif

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 67ae454da749a7ca67115b43205d9fe98bea3213 by Serhiy Storchaka in 
branch '3.7':
[3.7] bpo-40179: Fix translation of #elif in Argument Clinic (GH-19364) 
(GH-19584)
https://github.com/python/cpython/commit/67ae454da749a7ca67115b43205d9fe98bea3213


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40179] Argument Clinic incorretly translates #elif

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
pull_requests: +18921
pull_request: https://github.com/python/cpython/pull/19584

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40179] Argument Clinic incorretly translates #elif

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
pull_requests: +18920
pull_request: https://github.com/python/cpython/pull/19583

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40179] Argument Clinic incorretly translates #elif

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 12446e6a605f066d837d3a595d0a73e4f3b43b65 by Serhiy Storchaka in 
branch 'master':
bpo-40179: Fix translation of #elif in Argument Clinic (GH-19364)
https://github.com/python/cpython/commit/12446e6a605f066d837d3a595d0a73e4f3b43b65


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40179] Argument Clinic incorretly translates #elif

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

See PR 19360 for real example.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40179] Argument Clinic incorretly translates #elif

[Larry Hastings]

Larry Hastings  added the comment:

Good catch, and thanks for submitting a patch too!  I want to play with your 
patch a little before I just say "yes of course".

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40179] Argument Clinic incorretly translates #elif

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
pull_requests: +18727
pull_request: https://github.com/python/cpython/pull/19360

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40179] Argument Clinic incorretly translates #elif

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
keywords: +patch
pull_requests: +18726
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/19364

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40179] Argument Clinic incorretly translates #elif

[Serhiy Storchaka]

New submission from Serhiy Storchaka :

It converts

#if A
...
#elif B
...
#else
...
#endif

into

#if A
...
#endif /* A */

#if B
...
#endif /* B */

#if !B
...
#endif /* !B */

The correct translation is:

#if A
...
#endif /* A */

#if !A && B
...
#endif /* !A && B */

#if !A && !B
...
#endif /* !A && !B */

--
components: Argument Clinic, Build
messages: 365769
nosy: larry, serhiy.storchaka
priority: normal
severity: normal
status: open
title: Argument Clinic incorretly translates #elif
type: compile error
versions: Python 3.7, Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com