[issue40703] PyType_FromSpec*() overwrites the type's "__module__"

Change by Petr Viktorin : -- resolution: fixed -> status: closed -> open ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue40703] PyType_FromSpec*() overwrites the type's "__module__"

Petr Viktorin added the comment: Thank you, Stefan! This should have a test as well. I'm willing to mentor someone who wants to get into the C-API, otherwise this has low priority for me. -- resolution: -> fixed stage: test needed -> resolved status: open -> closed

[issue40703] PyType_FromSpec*() overwrites the type's "__module__"

Stefan Behnel added the comment: New changeset 9419158a3e67ba2eadf33215568003ed723b0a98 by Miss Islington (bot) in branch '3.9': bpo-40703: Let PyType_FromSpec() set "type.__module__" only if it is not set yet. (GH-20273) (GH-20782)

[issue40703] PyType_FromSpec*() overwrites the type's "__module__"

Change by Stefan Behnel : -- stage: patch review -> test needed ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue40703] PyType_FromSpec*() overwrites the type's "__module__"

Change by miss-islington : -- nosy: +miss-islington nosy_count: 5.0 -> 6.0 pull_requests: +19977 pull_request: https://github.com/python/cpython/pull/20782 ___ Python tracker

[issue40703] PyType_FromSpec*() overwrites the type's "__module__"

Stefan Behnel added the comment: New changeset 24b8bad6d30ae4fb37ee686a073adfa5308659f9 by scoder in branch 'master': bpo-40703: Let PyType_FromSpec() set "type.__module__" only if it is not set yet. (GH-20273)

[issue40703] PyType_FromSpec*() overwrites the type's "__module__"

Change by hai shi : -- nosy: +shihai1991 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40703] PyType_FromSpec*() overwrites the type's "__module__"

Change by Stefan Behnel : -- keywords: +patch pull_requests: +19553 stage: -> patch review pull_request: https://github.com/python/cpython/pull/20273 ___ Python tracker ___

[issue40703] PyType_FromSpec*() overwrites the type's "__module__"

New submission from Stefan Behnel : The PyType_FromSpec() functions set the type's "__module__" attribute at the end: https://github.com/python/cpython/blob/0509c4547fc95cc32a91ac446a26192c3bfdf157/Objects/typeobject.c#L3154-L3172 There are only two possible cases, either it finds a module