[issue41515] typing.get_type_hints generates KeyError

Change by Will Chen : -- nosy: +WCA nosy_count: 6.0 -> 7.0 pull_requests: +25458 pull_request: https://github.com/python/cpython/pull/26862 ___ Python tracker ___

[issue41515] typing.get_type_hints generates KeyError

STINNER Victor added the comment: I see that all PRs are merged, and the CI issue is fixed as well. I close the issue. commit eb77133564d74eb09ed63872a69b9827d4841b49 Author: Karthikeyan Singaravelan Date: Tue Apr 13 19:24:23 2021 +0530 bpo41515: Fix assert in test which throws

[issue41515] typing.get_type_hints generates KeyError

Karthikeyan Singaravelan added the comment: Thanks Victor. I have created https://github.com/python/cpython/pull/25379 that uses self.assertEqual instead of assert that produces syntax warning. -- ___ Python tracker

[issue41515] typing.get_type_hints generates KeyError

Change by Karthikeyan Singaravelan : -- pull_requests: +24111 pull_request: https://github.com/python/cpython/pull/25379 ___ Python tracker ___

[issue41515] typing.get_type_hints generates KeyError

STINNER Victor added the comment: > Thanks -- odd this didn't fail in CI. The CI runs tests with "make buildbottest" which uses the -w option: -w, --verbose2re-run failed tests in verbose mode When test___all__ is re-run in verbose mode, it doesn't fail: "== Tests result: FAILURE

[issue41515] typing.get_type_hints generates KeyError

Guido van Rossum added the comment: Thanks -- odd this didn't fail in CI. We'll get it fixed. -- ___ Python tracker ___ ___

[issue41515] typing.get_type_hints generates KeyError

STINNER Victor added the comment: This change introduced a regression: https://buildbot.python.org/all/#/builders/96/builds/1012 $ ./python -m test test___all__ 0:00:00 load avg: 0.28 Run tests sequentially 0:00:00 load avg: 0.28 [1/1] test___all__ test test___all__ failed -- Traceback (most

[issue41515] typing.get_type_hints generates KeyError

Guido van Rossum added the comment: New changeset a9cf69df2e031d6157f01289f66ca9cf723ceb5c by Karthikeyan Singaravelan in branch 'master': bpo-41515: Fix KeyError raised in get_type_hints (GH-25352) https://github.com/python/cpython/commit/a9cf69df2e031d6157f01289f66ca9cf723ceb5c

[issue41515] typing.get_type_hints generates KeyError

Change by Karthikeyan Singaravelan : -- pull_requests: +24087 pull_request: https://github.com/python/cpython/pull/25352 ___ Python tracker ___

[issue41515] typing.get_type_hints generates KeyError

Karthikeyan Singaravelan added the comment: I guess more libraries will experience this with `from __future__ import annotations` becoming default in Python 3.10 and they switch to get_type_hints. https://github.com/sphinx-doc/sphinx/issues/8084

[issue41515] typing.get_type_hints generates KeyError

Change by Roundup Robot : -- keywords: +patch nosy: +python-dev nosy_count: 3.0 -> 4.0 pull_requests: +20948 stage: -> patch review pull_request: https://github.com/python/cpython/pull/21816 ___ Python tracker

[issue41515] typing.get_type_hints generates KeyError

Guido van Rossum added the comment: Hm, the fix would seem simple enough. Can you submit a PR? It would be nice if it had a test as well. -- ___ Python tracker ___

[issue41515] typing.get_type_hints generates KeyError

Change by Karthikeyan Singaravelan : -- nosy: +gvanrossum, levkivskyi ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue41515] typing.get_type_hints generates KeyError

New submission from Eric Fahlgren : Windows 10 Pro 64 Python 3.8.3 64 wxPython 4.1.0 It appears that there are synthetic classes in the mro, which don't appear in the type's namespace, raising KeyError when encountered. From reading the function's doc and source, it looks like it should