[issue43132] Incorrect handling of PyObject_RichCompareBool() in the _zoneinfo module

[Zackery Spytz]

Change by Zackery Spytz :


--
pull_requests: +23593
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/24829

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43132] Incorrect handling of PyObject_RichCompareBool() in the _zoneinfo module

[Zackery Spytz]

Zackery Spytz  added the comment:

Okay, I will add some tests.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43132] Incorrect handling of PyObject_RichCompareBool() in the _zoneinfo module

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

Sorry, I thought I just forgot to close this issue.

--
resolution: fixed -> 
stage: resolved -> needs patch
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43132] Incorrect handling of PyObject_RichCompareBool() in the _zoneinfo module

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
resolution:  -> fixed
stage: needs patch -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43132] Incorrect handling of PyObject_RichCompareBool() in the _zoneinfo module

[Paul Ganssle]

Paul Ganssle  added the comment:

Re-opening because this was merged without tests.

@ZackerySpytz would you mind adding tests to hit these error cases? I've spent 
some time satisfying myself that it's indeed possible, and I've detailed a 
general outline here: 
https://github.com/python/cpython/pull/24450#issuecomment-774190609

--
nosy: +p-ganssle
resolution: fixed -> 
stage: resolved -> needs patch
status: closed -> open
type:  -> behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43132] Incorrect handling of PyObject_RichCompareBool() in the _zoneinfo module

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset c8b4375fe1aca1188f57ecf482547abd77e3ef91 by Miss Islington (bot) 
in branch '3.9':
bpo-43132: Fix incorrect handling of PyObject_RichCompareBool() in _zoneinfo 
(GH-24450) (GH-24457)
https://github.com/python/cpython/commit/c8b4375fe1aca1188f57ecf482547abd77e3ef91


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43132] Incorrect handling of PyObject_RichCompareBool() in the _zoneinfo module

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43132] Incorrect handling of PyObject_RichCompareBool() in the _zoneinfo module

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset effaec0bb54f381db8ccfa62514bc26b00946b40 by Zackery Spytz in 
branch 'master':
bpo-43132: Fix incorrect handling of PyObject_RichCompareBool() in _zoneinfo 
(GH-24450)
https://github.com/python/cpython/commit/effaec0bb54f381db8ccfa62514bc26b00946b40


--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43132] Incorrect handling of PyObject_RichCompareBool() in the _zoneinfo module

[miss-islington]

Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 2.0 -> 3.0
pull_requests: +23255
pull_request: https://github.com/python/cpython/pull/24457

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43132] Incorrect handling of PyObject_RichCompareBool() in the _zoneinfo module

[Zackery Spytz]

Change by Zackery Spytz :


--
keywords: +patch
pull_requests: +23251
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/24450

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43132] Incorrect handling of PyObject_RichCompareBool() in the _zoneinfo module

[Zackery Spytz]

New submission from Zackery Spytz :

PyObject_RichCompareBool() returns -1 on error, but this case is not handled
by the find_in_strong_cache() function.

--
components: Extension Modules
messages: 386503
nosy: ZackerySpytz
priority: normal
severity: normal
status: open
title: Incorrect handling of PyObject_RichCompareBool() in the _zoneinfo module
versions: Python 3.10, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com