[issue44351] distutils.sysconfig.parse_makefile() regression in Python 3.10

Change by Petr Viktorin : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue44351] distutils.sysconfig.parse_makefile() regression in Python 3.10

Petr Viktorin added the comment: New changeset 2f2ea96c4429b81f491aa1cdc4219ef2fd6d37fb by Miss Islington (bot) in branch '3.10': bpo-44351: Restore back parse_makefile in distutils.sysconfig (GH-26637) (GH-26673)

[issue44351] distutils.sysconfig.parse_makefile() regression in Python 3.10

Petr Viktorin added the comment: New changeset fc98266ff627ba0f56f8ae241245b66bc983baa3 by Lumír 'Frenzy' Balhar in branch 'main': bpo-44351: Restore back parse_makefile in distutils.sysconfig (GH-26637) https://github.com/python/cpython/commit/fc98266ff627ba0f56f8ae241245b66bc983baa3

[issue44351] distutils.sysconfig.parse_makefile() regression in Python 3.10

Change by miss-islington : -- nosy: +miss-islington nosy_count: 3.0 -> 4.0 pull_requests: +25259 pull_request: https://github.com/python/cpython/pull/26673 ___ Python tracker

[issue44351] distutils.sysconfig.parse_makefile() regression in Python 3.10

Change by Lumír Balhar : -- keywords: +patch pull_requests: +25223 stage: -> patch review pull_request: https://github.com/python/cpython/pull/26637 ___ Python tracker ___

[issue44351] distutils.sysconfig.parse_makefile() regression in Python 3.10

Miro Hrončok added the comment: Yes, for the purposes of this bug, bringing TextFile-powered parse_makefile() back to distutils (and distutils only) is the right thing to do. Whether or not Python needs a public standard library function to parse makefiles and whether that function in

[issue44351] distutils.sysconfig.parse_makefile() regression in Python 3.10

Petr Viktorin added the comment: IMO, the functionality should only be preserved until distutils is removed. So: - distutils.sysconfig.parse_makefile should use TextFile as before, so projects that use it aren't broken *yet* - nothing else should call distutils.sysconfig.parse_makefile, so

[issue44351] distutils.sysconfig.parse_makefile() regression in Python 3.10

Lumír Balhar added the comment: Thanks for the report. The regression is caused by the fact that the old implementation of parse_makefile in distutils.sysconfig was using feature-rich class TextFile which handles all the functionalities you reported as broken - stripping of comments,

[issue44351] distutils.sysconfig.parse_makefile() regression in Python 3.10

New submission from Miro Hrončok : Hello. I think https://github.com/python/cpython/pull/23142 changed the behavior of distutils.sysconfig.parse_makefile(). A downstream Fedora report with an affected petsc package: https://bugzilla.redhat.com/show_bug.cgi?id=1959088 Reproducers