[issue44564] DeprecationWarning in test_enum over formatting

[Łukasz Langa]

Łukasz Langa  added the comment:

Thanks, Brandon! ✨  ✨

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44564] DeprecationWarning in test_enum over formatting

[Łukasz Langa]

Łukasz Langa  added the comment:


New changeset f99c015638b46e46ae3ee3f27b96a514007cdaef by Brandon Schabell in 
branch 'main':
bpo-44564 Move formatted assertion under deprecation warning context (GH-27090)
https://github.com/python/cpython/commit/f99c015638b46e46ae3ee3f27b96a514007cdaef


--
nosy: +lukasz.langa

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44564] DeprecationWarning in test_enum over formatting

[Denis Laxalde]

Denis Laxalde  added the comment:

The assertion at stake looks redundant since we already check that 
`'{}'.format(OkayEnum.one) == '1'` (the line above) and that `OkayEnum.one == 
'1'` (3 lines above).

--
nosy: +dlax

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44564] DeprecationWarning in test_enum over formatting

[Brandon Schabell]

Change by Brandon Schabell :


--
keywords: +patch
nosy: +brandonschabell
nosy_count: 2.0 -> 3.0
pull_requests: +25638
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/27090

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44564] DeprecationWarning in test_enum over formatting

[Karthikeyan Singaravelan]

New submission from Karthikeyan Singaravelan :

It seems the line above this is wrapped under a block to check for deprecation 
warning but this line got missed out.

PYTHONWARNINGS=always ./python.exe -Wall -m test test_enum
0:00:00 load avg: 3.91 Run tests sequentially
0:00:00 load avg: 3.91 [1/1] test_enum
/Users/kasingar/stuff/python/cpython/Lib/test/test_enum.py:2324: 
DeprecationWarning: in 3.12 format() will use the enum member, not the enum 
member's value;
use a format specifier, such as :d for an integer-based Enum, to maintain the 
current display
  self.assertEqual(OkayEnum.one, '{}'.format(OkayEnum.one))

== Tests result: SUCCESS ==

1 test OK.

Total duration: 257 ms
Tests result: SUCCESS

--
components: Library (Lib)
keywords: newcomer friendly
messages: 396967
nosy: ethan.furman, xtreak
priority: normal
severity: normal
status: open
title: DeprecationWarning in test_enum over formatting
type: behavior
versions: Python 3.11

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com