[issue45889] pathlib: Path.match does not work on paths

[Nick Papior]

Nick Papior  added the comment:

Ok, I can accept a no-fix ;)

I'll close this.

--
resolution:  -> wont fix
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45889] pathlib: Path.match does not work on paths

[Eric V. Smith]

Eric V. Smith  added the comment:

I agree with Éric and Ronald.

--
nosy: +eric.smith

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45889] pathlib: Path.match does not work on paths

[Éric Araujo]

Éric Araujo  added the comment:

FWIW I think in the same way as Ronald.

A pattern is not a path, it’s a string expressing rules.
If it matches, the results are paths, but that does not make the pattern a path.

--
nosy: +eric.araujo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45889] pathlib: Path.match does not work on paths

[Nick Papior]

Nick Papior  added the comment:

Thanks for the discussion.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45889] pathlib: Path.match does not work on paths

[Ronald Oussoren]

Ronald Oussoren  added the comment:

I don't think our opinions about this will converge, I'm therefore leaving this 
discussion.

>> would ``Path("dir/some.py").match(Path("*.py"))`` return?
>
> str(Path("*.py")) == "*.py"
>
> So no problems here.

I do think this is a problem, treating a Path like an pattern feels wrong to me.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45889] pathlib: Path.match does not work on paths

[Nick Papior]

Nick Papior  added the comment:

It basically checks that some part of the path is the same as some part of a 
reference path, they need not have the same complete parent which is why the 
resolve command would negate this comparison always.

--

As for your last example, that will be quite easily handled:

> would ``Path("dir/some.py").match(Path("*.py"))`` return?

str(Path("*.py")) == "*.py"

So no problems here.

It would even allow users for easier combination of patterns

suffix_path = Path("*.py")

if path.match("home" / suffix_path):
   
elif path.match("other" / suffix_path):
   


The equivalent code would have been:

suffix_path = "*.py"
if path.match(os.path.join("home", suffix_path):
   
elif path.match(os.path.join("other", suffix_path):
   


I think the former does not infer any confusion, nor does it seem to me to 
introduce anything that contradicts the meaning of match/glob/rglob.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45889] pathlib: Path.match does not work on paths

[Ronald Oussoren]

Ronald Oussoren  added the comment:

I'm not sure what your code tries to accomplish, does it check that 
``f.parent`` refers to the same location as ``ref_file``? A clearer solution 
for that would be ``f.parent.resolve() == ref_file.resolve()``. 



The argument to match, glob and rglob cannot be Paths because the argument is 
not a path but a pattern. Those are conceptually different.

What would ``Path("dir/some.py").match(Path("*.py"))`` return?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45889] pathlib: Path.match does not work on paths

[Nick Papior]

Nick Papior  added the comment:

> Because of this I don't agree with your idea that anything that can match a 
> path is a sub-path. 

Why not? If a match is True, it means that what is matched must be some kind of 
valid path matching a glob specification. Whether it is a regular expression, 
or anything else. If one did $(ls pattern) one would list the paths that 
matches the pattern, and hence a path. Agreed that the pattern itself is not 
necessarily a fixed/single path, but a shell glob path. Yet, matches will 
regardless be a path.

As for the use case I want to assert a files path has a parent that matches 
another directory/filename something like this:


ref_file = Path("hello")
for f in dir.iterdir():
if f.parent.match(ref_file):


in the real application the match is a bit more complex with nested directories 
as well as a recursive iterator.

Lastly, you say:
> That said, I don't understand why it is desirable to use a Path as the match 
> argument.

I am on the other side:
I don't understand why it is undesirable to use a Path as the match argument.

:)

A simple

if isinstance(pattern, PurePath):
   pattern = str(pattern)

would suffice. Or possibly str(pattern.expanduser()) for consistency.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45889] pathlib: Path.match does not work on paths

[Ronald Oussoren]

Ronald Oussoren  added the comment:

Match doesn't match paths, but basically does a regular expression match on the 
textual representation  (using glob syntax instead of normal regular expression 
syntax).

Because of this I don't agree with your idea that anything that can match a 
path is a sub-path. 

What is your use case for this?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45889] pathlib: Path.match does not work on paths

[Nick Papior]

Nick Papior  added the comment:

Ok, I see this a feature. :)

As for why it is desirable.

A part of a path is still a path, and matching for something must mean that you 
are matching a partial path.

Even if you use '*.py' as the pattern this would still make sense as a path:

path = pl.Path("foo/bar")
print(path.match("bar"))
print(path.match(str(pl.Path("bar"
print(path.match(str(pl.Path("*"

The idea is that *anything* that can match a path _is_ a sub-path by 
definition, otherwise it can't be matched. So allowing path is just as natural 
as far as I see it.

As for the above argumentation I think this also holds for Path.glob and 
Path.rglob where pattern could just as well be a Path.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45889] pathlib: Path.match does not work on paths

[Ronald Oussoren]

Ronald Oussoren  added the comment:

This would definitely be a new feature and not something that can be back 
ported.

That said, I don't understand why it is desirable to use a Path as the match 
argument. That argument is a glob pattern (such as "*.py") and not a file name .

--
nosy: +ronaldoussoren
versions: +Python 3.11 -Python 3.6, Python 3.7, Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45889] pathlib: Path.match does not work on paths

[Nick Papior]

New submission from Nick Papior :

The documentation of Path.match only says it will match a pattern.

But quite often this pattern may be desirable to have as a Path as well.

import pathlib as pl

path = pl.Path("foo/bar")
print(path.match("bar"))
print(path.match(pl.Path("bar")))

However, the last one fails and one has to resort to 

print(path.match(str(pl.Path("bar"

which in my opinion is a little misleading.

I couldn't find any other bug/enhancement report of this. Also, this probably 
also targets later versions.

--
components: Library (Lib)
messages: 406910
nosy: nickpapior
priority: normal
severity: normal
status: open
title: pathlib: Path.match does not work on paths
type: enhancement
versions: Python 3.6, Python 3.7, Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com