[issue46417] Clear static types in Py_Finalize() for embedded Python

STINNER Victor added the comment: New changeset 9a241271139a317597aca71d5971346b2cfe7dbd by Victor Stinner in branch 'main': bpo-46417: _PyStructSequence_FiniType() updates _Py_RefTotal (GH-30988) https://github.com/python/cpython/commit/9a241271139a317597aca71d5971346b2cfe7dbd --

[issue46417] Clear static types in Py_Finalize() for embedded Python

Change by STINNER Victor : -- pull_requests: +29167 pull_request: https://github.com/python/cpython/pull/30988 ___ Python tracker ___

[issue46417] Clear static types in Py_Finalize() for embedded Python

STINNER Victor added the comment: I close the issue. I cleared most static types at exit. Following work can be done in bpo-40077 or other issues. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue46417] Clear static types in Py_Finalize() for embedded Python

STINNER Victor added the comment: New changeset 6c6a153dee132116611f2d5df0689a5a605f62b6 by Victor Stinner in branch 'main': bpo-46417: signal: move siginfo_type to the module state (GH-30964) https://github.com/python/cpython/commit/6c6a153dee132116611f2d5df0689a5a605f62b6 --

[issue46417] Clear static types in Py_Finalize() for embedded Python

Change by STINNER Victor : -- pull_requests: +29143 pull_request: https://github.com/python/cpython/pull/30964 ___ Python tracker ___

[issue46417] Clear static types in Py_Finalize() for embedded Python

STINNER Victor added the comment: > See also bpo-46476: Not all memory allocated by _Py_Quicken() is released at > Python exit. If you apply my workaround for bpo-46476: https://bugs.python.org/issue46476#msg411321 Python no longer leaks any memory block at exit for the simplest command! $

[issue46417] Clear static types in Py_Finalize() for embedded Python

STINNER Victor added the comment: New changeset 976dec9b3b35fddbaa893c99297e0c54731451b5 by Victor Stinner in branch 'main': bpo-46417: _PyList_Fini() clears indexerr (GH-30815) https://github.com/python/cpython/commit/976dec9b3b35fddbaa893c99297e0c54731451b5 --

[issue46417] Clear static types in Py_Finalize() for embedded Python

Change by STINNER Victor : -- pull_requests: +29002 pull_request: https://github.com/python/cpython/pull/30815 ___ Python tracker ___

[issue46417] Clear static types in Py_Finalize() for embedded Python

STINNER Victor added the comment: See also bpo-46476: Not all memory allocated by _Py_Quicken() is released at Python exit. -- ___ Python tracker ___

[issue46417] Clear static types in Py_Finalize() for embedded Python

STINNER Victor added the comment: > New changeset a1444f43584af0f7a0af72aa06ba0a86ae5a87a2 by Victor Stinner in > branch 'main': > bpo-46417: Fix _PyStaticType_Dealloc() (GH-30810) > https://github.com/python/cpython/commit/a1444f43584af0f7a0af72aa06ba0a86ae5a87a2 At this commit,

[issue46417] Clear static types in Py_Finalize() for embedded Python

STINNER Victor added the comment: cannot_deallocate2.patch: updated patch to debug which types are not cleared at exit. -- Added file: https://bugs.python.org/file50577/cannot_deallocate2.patch ___ Python tracker

[issue46417] Clear static types in Py_Finalize() for embedded Python

STINNER Victor added the comment: The _PyStaticType_Dealloc() function cannot call PyObject_ClearWeakRefs() if the refcount is not zero. I am not sure if it's a real issue or not. Maybe the weakref list must be cleared (release memory), but callbacks must not be called? --

[issue46417] Clear static types in Py_Finalize() for embedded Python

STINNER Victor added the comment: New changeset a1444f43584af0f7a0af72aa06ba0a86ae5a87a2 by Victor Stinner in branch 'main': bpo-46417: Fix _PyStaticType_Dealloc() (GH-30810) https://github.com/python/cpython/commit/a1444f43584af0f7a0af72aa06ba0a86ae5a87a2 --

[issue46417] Clear static types in Py_Finalize() for embedded Python

STINNER Victor added the comment: New changeset 12f4ac3bc848244242d6b8a7ee158b985fd64744 by Victor Stinner in branch 'main': bpo-46417: Clear symtable identifiers at exit (GH-30809) https://github.com/python/cpython/commit/12f4ac3bc848244242d6b8a7ee158b985fd64744 --

[issue46417] Clear static types in Py_Finalize() for embedded Python

Change by STINNER Victor : -- pull_requests: +28998 pull_request: https://github.com/python/cpython/pull/30810 ___ Python tracker ___

[issue46417] Clear static types in Py_Finalize() for embedded Python

Change by STINNER Victor : -- pull_requests: +28997 pull_request: https://github.com/python/cpython/pull/30809 ___ Python tracker ___

[issue46417] Clear static types in Py_Finalize() for embedded Python

STINNER Victor added the comment: New changeset 9c8e490b8f9e40a6fe9815be58bacaecab5369ee by Victor Stinner in branch 'main': bpo-46417: Clear _io module static objects at exit (GH-30807) https://github.com/python/cpython/commit/9c8e490b8f9e40a6fe9815be58bacaecab5369ee --

[issue46417] Clear static types in Py_Finalize() for embedded Python

Change by STINNER Victor : -- pull_requests: +28995 pull_request: https://github.com/python/cpython/pull/30807 ___ Python tracker ___

[issue46417] Clear static types in Py_Finalize() for embedded Python

STINNER Victor added the comment: New changeset 1626bf4ac7aef1244e6f886e63a31f7ed65fbd10 by Victor Stinner in branch 'main': bpo-46417: Clear Unicode static types at exit (GH-30806) https://github.com/python/cpython/commit/1626bf4ac7aef1244e6f886e63a31f7ed65fbd10 --

[issue46417] Clear static types in Py_Finalize() for embedded Python

Change by STINNER Victor : -- pull_requests: +28994 pull_request: https://github.com/python/cpython/pull/30806 ___ Python tracker ___

[issue46417] Clear static types in Py_Finalize() for embedded Python

STINNER Victor added the comment: New changeset 621a45ccacd121f9ae4d8a539f040410c74b253b by Victor Stinner in branch 'main': bpo-46417: Py_Finalize() clears static exceptioins (GH-30805) https://github.com/python/cpython/commit/621a45ccacd121f9ae4d8a539f040410c74b253b --

[issue46417] Clear static types in Py_Finalize() for embedded Python

Change by STINNER Victor : -- pull_requests: +28993 pull_request: https://github.com/python/cpython/pull/30805 ___ Python tracker ___

[issue46417] Clear static types in Py_Finalize() for embedded Python

STINNER Victor added the comment: New changeset f1bcdeaca6e912a2bec1fbcff76cc49e7f761d38 by Victor Stinner in branch 'main': bpo-46417: Factorize _PyExc_InitTypes() code (GH-30804) https://github.com/python/cpython/commit/f1bcdeaca6e912a2bec1fbcff76cc49e7f761d38 --

[issue46417] Clear static types in Py_Finalize() for embedded Python

Change by STINNER Victor : -- pull_requests: +28992 pull_request: https://github.com/python/cpython/pull/30804 ___ Python tracker ___

[issue46417] Clear static types in Py_Finalize() for embedded Python

STINNER Victor added the comment: Attached cannot_deallocate.patch explains why some static types cannot be deallocated. It lists (static) types which are not cleard properly at Python exit. Simplest example: --- $ ./python -c pass Cannot clear type 'object': it still has subclasses *

[issue46417] Clear static types in Py_Finalize() for embedded Python

STINNER Victor added the comment: Kumar Aditya: "The following patch further reduces the reference but not sure if it is correct (...)" Right! PyContext and PyHamt types were on my TODO list ;-) They are now cleared since this change: bpo-46417: Clear more static types (GH-30796)

[issue46417] Clear static types in Py_Finalize() for embedded Python

STINNER Victor added the comment: New changeset 6cacdb42454264ae75cab5e32bb62876da43bf6f by Victor Stinner in branch 'main': bpo-46417: _PyTypes_FiniTypes() clears object and type (GH-30798) https://github.com/python/cpython/commit/6cacdb42454264ae75cab5e32bb62876da43bf6f --

[issue46417] Clear static types in Py_Finalize() for embedded Python

Change by STINNER Victor : -- pull_requests: +28983 pull_request: https://github.com/python/cpython/pull/30798 ___ Python tracker ___

[issue46417] Clear static types in Py_Finalize() for embedded Python

STINNER Victor added the comment: New changeset 3a4c15bb9815b6f4652621fe6043ae18e0d202b3 by Victor Stinner in branch 'main': bpo-46417: Cleanup typeobject.c code (GH-30795) https://github.com/python/cpython/commit/3a4c15bb9815b6f4652621fe6043ae18e0d202b3 --

[issue46417] Clear static types in Py_Finalize() for embedded Python

STINNER Victor added the comment: New changeset 500c146387b01ea797b52e6a54caf228384e184c by Victor Stinner in branch 'main': bpo-46417: Clear more static types (GH-30796) https://github.com/python/cpython/commit/500c146387b01ea797b52e6a54caf228384e184c --

[issue46417] Clear static types in Py_Finalize() for embedded Python

Change by STINNER Victor : -- pull_requests: +28981 pull_request: https://github.com/python/cpython/pull/30796 ___ Python tracker ___

[issue46417] Clear static types in Py_Finalize() for embedded Python

Change by STINNER Victor : -- pull_requests: +28980 pull_request: https://github.com/python/cpython/pull/30795 ___ Python tracker ___

[issue46417] Clear static types in Py_Finalize() for embedded Python

STINNER Victor added the comment: New changeset 2d03b73cc9c0dada3243eab1373a46dbd98d24a0 by Victor Stinner in branch 'main': bpo-46417: remove_subclass() clears tp_subclasses (GH-30793) https://github.com/python/cpython/commit/2d03b73cc9c0dada3243eab1373a46dbd98d24a0 --

[issue46417] Clear static types in Py_Finalize() for embedded Python

Change by STINNER Victor : -- pull_requests: +28978 pull_request: https://github.com/python/cpython/pull/30793 ___ Python tracker ___

[issue46417] Clear static types in Py_Finalize() for embedded Python

STINNER Victor added the comment: New changeset f1796f29478f08f34e0c30a060622c0b2d843e2c by Miss Islington (bot) in branch '3.9': bpo-46417: Fix race condition on setting type __bases__ (GH-30788) (GH-30790) https://github.com/python/cpython/commit/f1796f29478f08f34e0c30a060622c0b2d843e2c

[issue46417] Clear static types in Py_Finalize() for embedded Python

STINNER Victor added the comment: New changeset acda9f3b90c33e4020237cb9e5c676efb38f7847 by Miss Islington (bot) in branch '3.10': bpo-46417: Fix race condition on setting type __bases__ (GH-30788) (GH-30789) https://github.com/python/cpython/commit/acda9f3b90c33e4020237cb9e5c676efb38f7847

[issue46417] Clear static types in Py_Finalize() for embedded Python

Change by STINNER Victor : -- pull_requests: +28976 pull_request: https://github.com/python/cpython/pull/30791 ___ Python tracker ___

[issue46417] Clear static types in Py_Finalize() for embedded Python

Change by miss-islington : -- pull_requests: +28975 pull_request: https://github.com/python/cpython/pull/30790 ___ Python tracker ___

[issue46417] Clear static types in Py_Finalize() for embedded Python

STINNER Victor added the comment: New changeset f1c6ae3270913e095d24ae13ecf96f5a32c8c503 by Victor Stinner in branch 'main': bpo-46417: Fix race condition on setting type __bases__ (GH-30788) https://github.com/python/cpython/commit/f1c6ae3270913e095d24ae13ecf96f5a32c8c503 --

[issue46417] Clear static types in Py_Finalize() for embedded Python

Change by miss-islington : -- nosy: +miss-islington nosy_count: 7.0 -> 8.0 pull_requests: +28974 pull_request: https://github.com/python/cpython/pull/30789 ___ Python tracker

[issue46417] Clear static types in Py_Finalize() for embedded Python

Change by STINNER Victor : -- pull_requests: +28973 pull_request: https://github.com/python/cpython/pull/30788 ___ Python tracker ___

[issue46417] Clear static types in Py_Finalize() for embedded Python

Kumar Aditya added the comment: The following patch further reduces the reference but not sure if it is correct. diff --git a/Objects/object.c b/Objects/object.c index a5ee8eef4a..2ba6d14d5b 100644 --- a/Objects/object.c +++ b/Objects/object.c @@ -1853,6 +1853,9 @@ static PyTypeObject*

[issue46417] Clear static types in Py_Finalize() for embedded Python

Change by STINNER Victor : -- pull_requests: +28960 pull_request: https://github.com/python/cpython/pull/30775 ___ Python tracker ___

[issue46417] Clear static types in Py_Finalize() for embedded Python

STINNER Victor added the comment: New changeset ac1f152421fab3ac854fe4565c575b306e2bb4b5 by Victor Stinner in branch 'main': bpo-46417: Use _PyType_CAST() in Objects directory (GH-30764) https://github.com/python/cpython/commit/ac1f152421fab3ac854fe4565c575b306e2bb4b5 --

[issue46417] Clear static types in Py_Finalize() for embedded Python

STINNER Victor added the comment: New changeset 7835cbf949c413a746324721a352cc72670a8a36 by Victor Stinner in branch 'main': bpo-46417: Use _PyType_CAST() in Python directory (GH-30769) https://github.com/python/cpython/commit/7835cbf949c413a746324721a352cc72670a8a36 --

[issue46417] Clear static types in Py_Finalize() for embedded Python

STINNER Victor added the comment: New changeset 8ee07dda139f3fa1d7c58a29532a98efc790568d by Victor Stinner in branch 'main': bpo-46417: Add _PyType_GetSubclasses() function (GH-30761) https://github.com/python/cpython/commit/8ee07dda139f3fa1d7c58a29532a98efc790568d --

[issue46417] Clear static types in Py_Finalize() for embedded Python

Change by STINNER Victor : -- pull_requests: +28955 pull_request: https://github.com/python/cpython/pull/30767 ___ Python tracker ___

[issue46417] Clear static types in Py_Finalize() for embedded Python

Change by STINNER Victor : -- pull_requests: +28954 pull_request: https://github.com/python/cpython/pull/30769 ___ Python tracker ___

[issue46417] Clear static types in Py_Finalize() for embedded Python

Change by STINNER Victor : -- pull_requests: +28950 pull_request: https://github.com/python/cpython/pull/30764 ___ Python tracker ___

[issue46417] Clear static types in Py_Finalize() for embedded Python

Change by STINNER Victor : -- pull_requests: +28949 pull_request: https://github.com/python/cpython/pull/30763 ___ Python tracker ___

[issue46417] Clear static types in Py_Finalize() for embedded Python

STINNER Victor added the comment: New changeset bc67f189fdd62ed42013fa05cd0ef2df498f5967 by Victor Stinner in branch 'main': bpo-46417: Add _PyType_CAST() macro (GH-30760) https://github.com/python/cpython/commit/bc67f189fdd62ed42013fa05cd0ef2df498f5967 --

[issue46417] Clear static types in Py_Finalize() for embedded Python

Change by STINNER Victor : -- pull_requests: +28948 pull_request: https://github.com/python/cpython/pull/30761 ___ Python tracker ___

[issue46417] Clear static types in Py_Finalize() for embedded Python

Change by STINNER Victor : -- pull_requests: +28947 pull_request: https://github.com/python/cpython/pull/30760 ___ Python tracker ___

[issue46417] Clear static types in Py_Finalize() for embedded Python

STINNER Victor added the comment: New changeset a1bf329bca80a0259da454c936075e11e6af710f by Victor Stinner in branch 'main': bpo-46417: Add missing types of _PyTypes_InitTypes() (GH-30749) https://github.com/python/cpython/commit/a1bf329bca80a0259da454c936075e11e6af710f --

[issue46417] Clear static types in Py_Finalize() for embedded Python

STINNER Victor added the comment: > bpo-46417: Revert remove_subclass() change (GH-30750) Ok, this change fixed buildbots. I saw code in typeobject.c which uses a borrowed reference to tp_subclasses with a loop which can modify tp_subclasses. This code should be modified to hold a strong

[issue46417] Clear static types in Py_Finalize() for embedded Python

STINNER Victor added the comment: New changeset fda88864980ffce57add0ea03fb9cbda2798975e by Victor Stinner in branch 'main': bpo-46417: Revert remove_subclass() change (GH-30750) https://github.com/python/cpython/commit/fda88864980ffce57add0ea03fb9cbda2798975e --

[issue46417] Clear static types in Py_Finalize() for embedded Python

Change by STINNER Victor : -- pull_requests: +28937 pull_request: https://github.com/python/cpython/pull/30750 ___ Python tracker ___

[issue46417] Clear static types in Py_Finalize() for embedded Python

Change by STINNER Victor : -- pull_requests: +28936 pull_request: https://github.com/python/cpython/pull/30749 ___ Python tracker ___

[issue46417] Clear static types in Py_Finalize() for embedded Python

STINNER Victor added the comment: Maybe the problem is that I changed the order in which types are initialized in _PyTypes_InitTypes()? So far, test_unittest crashed on 4 buildbot workers: * s390x Debian 3.x: ./configure --prefix '$(PWD)/target' --with-pydebug

[issue46417] Clear static types in Py_Finalize() for embedded Python

STINNER Victor added the comment: > bpo-46417: Py_Finalize() clears static types (GH-30743) Oh, test_unittest crashed on s390x Debian 3.x: https://buildbot.python.org/all/#/builders/49/builds/1789 I fail to see the relationship between my change and this crash. I don't expect test_unittest

[issue46417] Clear static types in Py_Finalize() for embedded Python

STINNER Victor added the comment: New changeset 595225e86dcc6ea520a584839925a878dce7a9b2 by Victor Stinner in branch 'main': bpo-46417: Py_Finalize() clears static types (GH-30743) https://github.com/python/cpython/commit/595225e86dcc6ea520a584839925a878dce7a9b2 --

[issue46417] Clear static types in Py_Finalize() for embedded Python

STINNER Victor added the comment: New changeset ea38e436fe1e585fb8c1f0badf5482f525b7f9ff by Victor Stinner in branch 'main': bpo-46417: Call _PyDebug_PrintTotalRefs() later (GH-30744) https://github.com/python/cpython/commit/ea38e436fe1e585fb8c1f0badf5482f525b7f9ff --

[issue46417] Clear static types in Py_Finalize() for embedded Python

Change by STINNER Victor : -- pull_requests: +28931 pull_request: https://github.com/python/cpython/pull/30744 ___ Python tracker ___

[issue46417] Clear static types in Py_Finalize() for embedded Python

Change by STINNER Victor : -- pull_requests: +28930 pull_request: https://github.com/python/cpython/pull/30743 ___ Python tracker ___

[issue46417] Clear static types in Py_Finalize() for embedded Python

STINNER Victor added the comment: New changeset d013b241352e902389f955f8f99d75f16c124ee2 by Victor Stinner in branch 'main': bpo-46417: signal uses PyStructSequence_NewType() (GH-30735) https://github.com/python/cpython/commit/d013b241352e902389f955f8f99d75f16c124ee2 --

[issue46417] Clear static types in Py_Finalize() for embedded Python

STINNER Victor added the comment: See also bpo-46449 "Deep-freezed modules create inconsistency in sys.gettotalrefcount() (_Py_Reftotal)". -- ___ Python tracker ___

[issue46417] Clear static types in Py_Finalize() for embedded Python

STINNER Victor added the comment: New changeset 1781d55eb34f94029e50970232635fc5082378cb by Victor Stinner in branch 'main': bpo-46417: _curses uses PyStructSequence_NewType() (GH-30736) https://github.com/python/cpython/commit/1781d55eb34f94029e50970232635fc5082378cb --

[issue46417] Clear static types in Py_Finalize() for embedded Python

Change by STINNER Victor : -- pull_requests: +28923 pull_request: https://github.com/python/cpython/pull/30736 ___ Python tracker ___

[issue46417] Clear static types in Py_Finalize() for embedded Python

Change by STINNER Victor : -- pull_requests: +28922 pull_request: https://github.com/python/cpython/pull/30735 ___ Python tracker ___

[issue46417] Clear static types in Py_Finalize() for embedded Python

STINNER Victor added the comment: New changeset 17f268a4ae6190b2659c89c6f32ad2d006e0e3c8 by Victor Stinner in branch 'main': bpo-46417: time module uses PyStructSequence_NewType() (GH-30734) https://github.com/python/cpython/commit/17f268a4ae6190b2659c89c6f32ad2d006e0e3c8 --

[issue46417] Clear static types in Py_Finalize() for embedded Python

STINNER Victor added the comment: New changeset f389b37fb1cebe7ed66331cdd373a014695261f6 by Victor Stinner in branch 'main': bpo-46417: _thread uses PyStructSequence_NewType() (GH-30733) https://github.com/python/cpython/commit/f389b37fb1cebe7ed66331cdd373a014695261f6 --

[issue46417] Clear static types in Py_Finalize() for embedded Python

Change by STINNER Victor : -- pull_requests: +28921 pull_request: https://github.com/python/cpython/pull/30734 ___ Python tracker ___

[issue46417] Clear static types in Py_Finalize() for embedded Python

Change by STINNER Victor : -- pull_requests: +28920 pull_request: https://github.com/python/cpython/pull/30733 ___ Python tracker ___

[issue46417] Clear static types in Py_Finalize() for embedded Python

STINNER Victor added the comment: New changeset 6415e2ee4955b1a995c1e75544e2506b03780c3d by Victor Stinner in branch 'main': bpo-46417: _testembed.c avoids Py_SetProgramName() (GH-30732) https://github.com/python/cpython/commit/6415e2ee4955b1a995c1e75544e2506b03780c3d --

[issue46417] Clear static types in Py_Finalize() for embedded Python

Change by STINNER Victor : -- pull_requests: +28919 pull_request: https://github.com/python/cpython/pull/30732 ___ Python tracker ___

[issue46417] Clear static types in Py_Finalize() for embedded Python

STINNER Victor added the comment: New changeset e9e3eab0b868c7d0b48e472705024240d5c39d5c by Victor Stinner in branch 'main': bpo-46417: Finalize structseq types at exit (GH-30645) https://github.com/python/cpython/commit/e9e3eab0b868c7d0b48e472705024240d5c39d5c --

[issue46417] Clear static types in Py_Finalize() for embedded Python

STINNER Victor added the comment: Another measure using the command: PYTHONHASHSEED=0 ./python -X showrefcount -c pass I had to run the command 20 times to get a stable value, I don't know why. main branch: [21981 refs, 5716 blocks] PR: [21887 refs, 5667 blocks] => the PR removes 94

[issue46417] Clear static types in Py_Finalize() for embedded Python

STINNER Victor added the comment: I checked with Valgrind the affect of PR 30645. main branch: ==330902== LEAK SUMMARY: ==330902== possibly lost: 29,128 bytes in 494 blocks ==330902==still reachable: 353,615 bytes in 3,577 blocks With the PR: ==332161== LEAK SUMMARY: ==332161==

[issue46417] Clear static types in Py_Finalize() for embedded Python

STINNER Victor added the comment: If tomorrow static types are shared between sub-interpreters, it doesn't solve this problem: we still need to release memory allocated by Py_Initialize() in Py_Finalize() when Python is embedded. This issue is a sub-set of the big bpo-1635741 which explains

[issue46417] Clear static types in Py_Finalize() for embedded Python

Change by Dong-hee Na : -- nosy: +corona10 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue46417] Clear static types in Py_Finalize() for embedded Python

Petr Viktorin added the comment: > Sharing objects between interpreters is bad That's your opinion, I don't necessarily share it. > and is causing complex bugs. But converting static things (types, small ints) to heap is also causing bugs :( Anyway, for this issue: is there a way to

[issue46417] Clear static types in Py_Finalize() for embedded Python

Change by Paulo Henrique Silva : -- nosy: +phsilva ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue46417] Clear static types in Py_Finalize() for embedded Python

Change by STINNER Victor : -- title: [subinterpreters] Clear static types in Py_Finalize() -> Clear static types in Py_Finalize() for embedded Python ___ Python tracker ___

[issue46417] Clear static types in Py_Finalize() for embedded Python

Change by STINNER Victor : -- components: +Interpreter Core -Subinterpreters ___ Python tracker ___ ___ Python-bugs-list mailing