[issue8734] msvcrt get_osfhandle crash on bad FD

2010-09-04 Thread Pascal Chambon 

Pascal Chambon chambon.pas...@gmail.com added the comment:

I guess it should, shouldn't it ?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8734
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8734] msvcrt get_osfhandle crash on bad FD

2010-09-04 Thread Antoine Pitrou 

Antoine Pitrou pit...@free.fr added the comment:

Ok, I've committed the patch in r84506 (3.x), r84507 (3.1) and r84508 (2.7). 
Thank you!

--
resolution: accepted - fixed
stage: commit review - committed/rejected
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8734
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8734] msvcrt get_osfhandle crash on bad FD

2010-09-03 Thread Antoine Pitrou 

Antoine Pitrou pit...@free.fr added the comment:

Should this be checked in?

--
nosy: +pitrou
versions: +Python 3.1, Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8734
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8734] msvcrt get_osfhandle crash on bad FD

2010-05-17 Thread Pascal Chambon 

Pascal Chambon chambon.pas...@gmail.com added the comment:

My bad, here is a better patch...

--
Added file: http://bugs.python.org/file17382/msvcrt_crash2.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8734
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8734] msvcrt get_osfhandle crash on bad FD

2010-05-17 Thread Pascal Chambon 

Changes by Pascal Chambon chambon.pas...@gmail.com:


Removed file: http://bugs.python.org/file17369/msvcrt_crash.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8734
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8734] msvcrt get_osfhandle crash on bad FD

2010-05-17 Thread Amaury Forgeot d'Arc 

Amaury Forgeot d'Arc amaur...@gmail.com added the comment:

The second patch looks good to me.

--
resolution:  - accepted
stage: patch review - commit review

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8734
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8734] msvcrt get_osfhandle crash on bad FD

2010-05-16 Thread Pascal Chambon 

New submission from Pascal Chambon chambon.pas...@gmail.com:

In python trunk, _set_invalid_parameter_handler() has been dropped and replaced 
by custom checking functions, but in msvcrt.get_osfhandle() these checks aren't 
present, so providing a bad FD leads to a crash.

Here is the little fix + a test (added to test_fileio, because I can't find 
unit tests for the msvcrt builtin, and similar bad fd cases are treated 
there).

--
components: IO
files: msvcrt_crash.patch
keywords: patch
messages: 105872
nosy: pakal
priority: normal
severity: normal
status: open
title: msvcrt get_osfhandle crash on bad FD
type: crash
versions: Python 2.7
Added file: http://bugs.python.org/file17369/msvcrt_crash.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8734
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com