[issue9433] regrtest.py -j 2 doesn't work on Windows: remove close_fds=True on Windows
Tim Golden m...@timgolden.me.uk added the comment: I can confirm that the patched regrtest runs ok on WinXP. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9433 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9433] regrtest.py -j 2 doesn't work on Windows: remove close_fds=True on Windows
Antoine Pitrou pit...@free.fr added the comment: Ok, I've committed the change in r84176 (py3k) and r84178 (2.7). Thank you! -- resolution: - fixed stage: patch review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9433 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9433] regrtest.py -j 2 doesn't work on Windows: remove close_fds=True on Windows
STINNER Victor victor.stin...@haypocalc.com added the comment: No, thank *you*, Antoine :-) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9433 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9433] regrtest.py -j 2 doesn't work on Windows: remove close_fds=True on Windows
Changes by Antoine Pitrou pit...@free.fr: -- nosy: +brian.curtin, tim.golden ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9433 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9433] regrtest.py -j 2 doesn't work on Windows: remove close_fds=True on Windows
Antoine Pitrou pit...@free.fr added the comment: Possible patch (checked to work in a Windows 7 VM): Index: Lib/test/regrtest.py === --- Lib/test/regrtest.py(révision 83938) +++ Lib/test/regrtest.py(copie de travail) @@ -547,7 +547,8 @@ popen = Popen([sys.executable, '-E', '-m', 'test.regrtest', '--slaveargs', json.dumps(args_tuple)], stdout=PIPE, stderr=PIPE, - universal_newlines=True, close_fds=True) + universal_newlines=True, + close_fds=(os.name != 'nt')) stdout, stderr = popen.communicate() # Strip last refcount output line if it exists, since it # comes from the shutdown of the interpreter in the subcommand. -- stage: needs patch - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9433 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9433] regrtest.py -j 2 doesn't work on Windows: remove close_fds=True on Windows
New submission from STINNER Victor victor.stin...@haypocalc.com: On Windows, subprocess doesn't support close_fds=True if stdin, stdout or stderr is redirected to a pipe. The problem is in the work function: popen = Popen([sys.executable, '-E', '-m', 'test.regrtest', ...], ..., stdout=PIPE, stderr=PIPE, close_fds=True). -- messages: 112125 nosy: haypo priority: normal severity: normal status: open title: regrtest.py -j 2 doesn't work on Windows: remove close_fds=True on Windows versions: Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9433 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9433] regrtest.py -j 2 doesn't work on Windows: remove close_fds=True on Windows
Changes by Florent Xicluna florent.xicl...@gmail.com: -- nosy: +flox ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9433 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9433] regrtest.py -j 2 doesn't work on Windows: remove close_fds=True on Windows
Changes by Florent Xicluna florent.xicl...@gmail.com: -- components: +Tests, Windows stage: - needs patch type: - behavior ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9433 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9433] regrtest.py -j 2 doesn't work on Windows: remove close_fds=True on Windows
Antoine Pitrou pit...@free.fr added the comment: Does it work ok if you remove close_fds? There is a reason it's better to close all handles :) -- nosy: +pitrou ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9433 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
