[issue10134] test_email failures on Windows: end of line issue?

R. David Murray added the comment: This is fixed by r86642. The remaining failing tests were pointing to bugs in the implementation of the linesep argument to generator.flatten. I had to add an additional test to catch all the related bugs, though. The tests now run the inversion tests with

[issue10134] test_email failures on Windows: end of line issue?

Changes by STINNER Victor : -- nosy: -haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue10134] test_email failures on Windows: end of line issue?

Brian Curtin added the comment: > Still not sure why they were not showing up on the buildbots. Victor was > working from an svn checkout and I from the binary installer, so it's not > just a difference in the svn eol handling. I too had only been seeing this in my checkout, but now that I s

[issue10134] test_email failures on Windows: end of line issue?

Changes by R. David Murray : -- dependencies: +email.Generators does not separates headers with "\r\n" ___ Python tracker ___ ___ Pyth

[issue10134] test_email failures on Windows: end of line issue?

R. David Murray added the comment: Having looked more carefully at the email4 (python2) code, I think I'm wrong. The test I changed appears to codify the behavior expected when parsing a crlf file in binary mode. This means that email4 code being ported to email5 may depend on that behavior

[issue10134] test_email failures on Windows: end of line issue?

R. David Murray added the comment: Clarification of my earlier comment on the patch: I think the behavior *originally* tested for by the changed test is arguably incorrect, given email's internal use of '\n' line endings. So I think the patch improves things, but it is a potential behavior c

[issue10134] test_email failures on Windows: end of line issue?

Changes by R. David Murray : Removed file: http://bugs.python.org/file19273/windows_email_fix.patch ___ Python tracker ___ ___ Python-bugs-lis

[issue10134] test_email failures on Windows: end of line issue?

R. David Murray added the comment: Revised patch that seems to fix all the windows failures. Still not sure why they were not showing up on the buildbots. Victor was working from an svn checkout and I from the binary installer, so it's not just a difference in the svn eol handling.

[issue10134] test_email failures on Windows: end of line issue?

R. David Murray added the comment: Here is a patch that adds a test of the underlying problem and fixes it. I don't like this patch because it tries to detect the line ending style of the input stream and changes behavior based on that, but because email wants to use '\n' as the separator in

[issue10134] test_email failures on Windows: end of line issue?

R. David Murray added the comment: Drat, there's a real bug here, too. The bytes parsing machinery doesn't correctly translate crlf on input. -- ___ Python tracker ___ ___

[issue10134] test_email failures on Windows: end of line issue?

Changes by R. David Murray : -- assignee: -> r.david.murray ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue10134] test_email failures on Windows: end of line issue?

R. David Murray added the comment: The interesting question is, why aren't the buildbots seeing this failure? I can reproduce it in my Windows VM using 3.2a3, and will work on a fix (to the tests, the code under test is doing the "correct" thing, though that thing is somewhat broken by desig

[issue10134] test_email failures on Windows: end of line issue?

New submission from STINNER Victor : See attached file for the full output. One example: == CPython 3.2a3+ (py3k:85660, Oct 17 2010, 21:57:48) [MSC v.1500 32 bit (Intel)] == Windows-XP-5.1.2600-SP3 little-endian == FAIL: test