Changes by Jesús Cea Avión j...@jcea.es:
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10142
___
___
Python-bugs-list
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset d69f95e57792 by Jesus Cea in branch 'default':
Cope with OSs lying - #10142: Support for SEEK_HOLE/SEEK_DATA
http://hg.python.org/cpython/rev/d69f95e57792
--
___
Python
Jesús Cea Avión j...@jcea.es added the comment:
Thanks for the head-up, Antoine.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10142
___
___
Antoine Pitrou pit...@free.fr added the comment:
Ping. The ARM buildbot still fails on test_fs_holes:
http://buildbot.python.org/all/builders/ARM%20Ubuntu%203.x/builds/775/steps/test/logs/stdio
--
___
Python tracker rep...@bugs.python.org
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 814557548af5 by Jesus Cea in branch 'default':
Skip test in freebsd entirely - Kernel bug in freebsd7/8/9 - #10142: Support
for SEEK_HOLE/SEEK_DATA
http://hg.python.org/cpython/rev/814557548af5
--
Jesús Cea Avión j...@jcea.es added the comment:
Stefan, I am confused with your comments. The thing is that freebsd defines
SEEK_HOLE/SEEK_DATA but reports an error when you use them. I guess they are
errors when used on a filesystem that doesn't support them. This is a bug, in
my opinion (if
Jesús Cea Avión j...@jcea.es added the comment:
Greog, I am confused about ARM ubuntu errors. Do we know what ubuntu version is
running there?. What is the filesystem?.
I am seriously thinking about supporting these flags only in real OSs like
Solaris derivatives :-)
--
Georg Brandl ge...@python.org added the comment:
Jesus, what do you think about removing that test entirely?
IMO it is not our job to verify the OS' proper behavior in the face of
SEEK_HOLE/SEEK_DATA; it is enough to provide the constants, and let whoever
uses it face the perils of the
Jesús Cea Avión j...@jcea.es added the comment:
Georg, I am fine with that if you are fine with that :-). Please, confirm :)
(sorry for mistyping your name before!)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10142
Stefan Krah stefan-use...@bytereef.org added the comment:
Jes??s Cea Avi??n rep...@bugs.python.org wrote:
Stefan, I am confused with your comments.
The FreeBSD bug report you linked to had a test case attached. The test case
uses errno == ENXIO. I could not reproduce the failure, so in my
Georg Brandl ge...@python.org added the comment:
As long as we have a test confirming that SEEK_HOLE/SEEK_DATA are *accepted* by
the io module (which is a big part of the patch), it is fine.
E.g. calling seek() with the constants and check that it only raises OSError or
nothing should work,
Changes by Hynek Schlawack h...@ox.cx:
--
nosy: -hynek
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10142
___
___
Python-bugs-list mailing list
Stefan Krah stefan-use...@bytereef.org added the comment:
This looks like a bug in freebsd:
http://lists.freebsd.org/pipermail/freebsd-amd64/2012-January/014332.html
I tested that one already yesterday (it was late, so I forgot to mention
it) and the test case attached to the bug report
Stefan Krah stefan-use...@bytereef.org added the comment:
int main(void)
{
int fd = open(ccc.c, O_RDONLY);
off_t offset=lseek(fd,0,SEEK_HOLE);
if (offset==-1) {
if (errno==ENXIO) {
Darn, the errno in test_posix should be ENOTTY. Indeed, with ENOTTY the
test case for
Georg Brandl ge...@python.org added the comment:
The test case is till failing for the freebsd7 buildbot:
http://www.python.org/dev/buildbot/all/builders/x86%20FreeBSD%207.2%203.x/builds/3155/steps/test/logs/stdio
--
nosy: +georg.brandl
status: closed - open
Georg Brandl ge...@python.org added the comment:
And the Ubuntu ARM buildbot.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10142
___
___
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset de2a0cb6ba52 by Jesus Cea in branch 'default':
Closes #10142: Support for SEEK_HOLE/SEEK_DATA
http://hg.python.org/cpython/rev/de2a0cb6ba52
--
resolution: - fixed
stage: patch review - committed/rejected
Stefan Krah stefan-use...@bytereef.org added the comment:
Looks like the FreeBSD bot fails in test_posix:
==
ERROR: test_fs_holes (test.test_posix.PosixTester)
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 13f5a329d5ea by Jesus Cea in branch 'default':
Kernel bug in freebsd9 - #10142: Support for SEEK_HOLE/SEEK_DATA
http://hg.python.org/cpython/rev/13f5a329d5ea
--
___
Jesús Cea Avión j...@jcea.es added the comment:
This looks like a bug in freebsd:
http://lists.freebsd.org/pipermail/freebsd-amd64/2012-January/014332.html
Since looks like a kernel bug, skipping test in that case.
Committed patch.
Thanks for the head-up.
--
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 8acaa341df53 by Jesus Cea in branch 'default':
Skip the test only if neccesary - Kernel bug in freebsd9 - #10142: Support for
SEEK_HOLE/SEEK_DATA
http://hg.python.org/cpython/rev/8acaa341df53
--
Hynek Schlawack h...@ox.cx added the comment:
bikeshedIn some cases you change invalid to unsupported when encountering
an invalid/unsupported `whence' and in others you keep them on invalid. I
find it rather hard to really differentiate these two words in that context;
care to shed a light
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 86dc014cdd74 by Jesus Cea in branch 'default':
Close #10142: Support for SEEK_HOLE/SEEK_DATA
http://hg.python.org/cpython/rev/86dc014cdd74
--
nosy: +python-dev
resolution: - fixed
stage: patch review -
Benjamin Peterson benja...@python.org added the comment:
You broke test_io
www.python.org/dev/buildbot/all/builders/x86 Gentoo Non-Debug
3.x/builds/2143/steps/test/logs/stdio
--
nosy: +benjamin.peterson
___
Python tracker rep...@bugs.python.org
Jesús Cea Avión j...@jcea.es added the comment:
Yes, backing out changeset.
Never suppose anything...
--
resolution: fixed -
stage: committed/rejected - patch review
status: closed - open
___
Python tracker rep...@bugs.python.org
Changes by Jesús Cea Avión j...@jcea.es:
Added file: http://bugs.python.org/file25370/6447a9323b11.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10142
___
Jesús Cea Avión j...@jcea.es added the comment:
New patch proposed, with testsuite fixed.
Please, review. Last chance :-).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10142
___
Changes by Jesús Cea Avión j...@jcea.es:
Added file: http://bugs.python.org/file25374/c7abfb4d4260.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10142
___
Jesús Cea Avión j...@jcea.es added the comment:
New patch, after neolo...@free.fr review.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10142
___
Changes by Jesús Cea Avión j...@jcea.es:
Added file: http://bugs.python.org/file25347/34103049559f.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10142
___
Changes by Jesús Cea Avión j...@jcea.es:
Removed file: http://bugs.python.org/file25347/34103049559f.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10142
___
Changes by Jesús Cea Avión j...@jcea.es:
Added file: http://bugs.python.org/file25348/0a5a40a4674a.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10142
___
Jesús Cea Avión j...@jcea.es added the comment:
New version, addressing Amaury concerns and Neologix review.
Please, do a final review.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10142
Antoine Pitrou pit...@free.fr added the comment:
- In test_posix.py: it's better to use the with statement when opening a file
- In Misc/NEWS: the entries should be kept in reverse chronological order
--
___
Python tracker rep...@bugs.python.org
Changes by Jesús Cea Avión j...@jcea.es:
Added file: http://bugs.python.org/file25350/ad882ba08568.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10142
___
Jesús Cea Avión j...@jcea.es added the comment:
Another version, after Antoine feedback.
Please, review.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10142
___
Jesús Cea Avión j...@jcea.es added the comment:
I am going to integrate next week
Please, review.
--
assignee: - jcea
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10142
___
Terry J. Reedy tjre...@udel.edu added the comment:
Is there a reason to say (several times) 'can support' instead of just
'support'? Do the OSes in question just optionally support rather than always
support?
The first version added: change 'depend of' to 'depend on'.
In several functions
Jesús Cea Avión j...@jcea.es added the comment:
Terry, yes, skiping the test in the code will raise an error anyway when doing
the real seek() OS syscall.
Is there a reason to say (several times) 'can support' instead of
just 'support'? Do the OSes in question just optionally support
rather
Amaury Forgeot d'Arc amaur...@gmail.com added the comment:
I don't see the point if OS seek() is going to give an error anyway.
Please check that Windows won't crash the interpreter with bad 'whence' values,
like it already does for closed file descriptors.
--
Changes by Jesús Cea Avión j...@jcea.es:
Added file: http://bugs.python.org/file25259/d6aeff63fa5e.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10142
___
Changes by Jesús Cea Avión j...@jcea.es:
--
hgrepos: +119
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10142
___
___
Python-bugs-list mailing
Changes by Jesús Cea Avión j...@jcea.es:
Removed file: http://bugs.python.org/file19566/z.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10142
___
Changes by Jesús Cea Avión j...@jcea.es:
Added file: http://bugs.python.org/file25260/3f967e00e267.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10142
___
Jesús Cea Avión j...@jcea.es added the comment:
Victor, internally Python uses 0, 1 and 2 as wired values independently of the
platform values. This is probably an historic accident.
Please, review.
--
stage: needs patch - patch review
___
Python
Changes by Kristján Valur Jónsson krist...@ccpgames.com:
--
nosy: -krisvale
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10142
___
___
Andreas Klauer andreas.kla...@googlemail.com added the comment:
ZFS supports SEEK_HOLE/SEEK_DATA in lseek() syscall.
The feature has patches available too for Linux, but never integrated in
mainline kernel, AFAIK.
it is difficult to write a testcase when I can only test under a system with
STINNER Victor victor.stin...@gmail.com added the comment:
+/* SEEK_SET and SEEK_CUR are special because we could seek inside the
+ buffer. Other whence values must be managed without this optimization.
+ Some Operating Systems can provide additional values, like
+
Changes by Jesús Cea Avión j...@jcea.es:
--
assignee: amaury.forgeotdarc - krisvale
keywords: +buildbot -easy, patch
nosy: +krisvale -amaury.forgeotdarc
versions: +Python 3.3 -Python 3.2
___
Python tracker rep...@bugs.python.org
Changes by Jesús Cea Avión j...@jcea.es:
--
assignee: krisvale - amaury.forgeotdarc
keywords: +easy, patch -buildbot
nosy: +amaury.forgeotdarc
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10142
Antoine Pitrou pit...@free.fr added the comment:
Jesus, perhaps you can address Amaury's comments by uploading a new patch?
--
assignee: amaury.forgeotdarc -
stage: commit review - needs patch
___
Python tracker rep...@bugs.python.org
Changes by Jesús Cea Avión j...@jcea.es:
Removed file: http://bugs.python.org/file19356/z
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10142
___
___
Jesús Cea Avión j...@jcea.es added the comment:
Please, review this. I had changed IO to support the new flags too. To do it, I
must relax error control in IO, a bit.
So, the new flag are supported both in os.lseek() and in standard file
objects.
Please, Antoine, could you review?.
I have
Jesús Cea Avión j...@jcea.es added the comment:
import os
f=open(XX,w+b)
f.seek(1024*1024)
1048576
f.write(bhello)
5
f.seek(1024*1024*2)
2097152
f.write(bbye)
3
f.seek(0,os.SEEK_HOLE)
0
f.seek(0,os.SEEK_DATA)
1048576
f.seek(1048576,os.SEEK_HOLE)
1179648
f.seek(1179648,os.SEEK_DATA)
Amaury Forgeot d'Arc amaur...@gmail.com added the comment:
- The patch modifies the _io module but not _pyio, why?
(try f=_pyio.open(XX,w+b) at the beginning of the script above)
- One test was *removed*, but nothing was added to test this new feature.
This is the most likely way to lose it
Jesús Cea Avión j...@jcea.es added the comment:
Amaury, thanks for your valuable feedback.
1. I forgot about the python implementation. I am not familiar with the new IO
framework. Implemented now.
3. These new SEEK modes should not be used in text mode. In my new patch the
modes are
Changes by Jesús Cea Avión j...@jcea.es:
--
assignee: pitrou - amaury.forgeotdarc
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10142
___
___
Jesús Cea Avión j...@jcea.es added the comment:
This is far more complicated that expected, because I would like to modify
file.seek() to be able to support these flags too. Analizing
Modules/_io/bufferedio.c:buffered_seek(), the logic is pretty convoluted and
the ramifications are
Jesús Cea Avión j...@jcea.es added the comment:
I attach patch. I have reviewed the IO module and I think we don't need to do
any change there, since values over 2 are not touched.
The patch is trivial. My plan was to leave this patch for a novice :-).
Please, review. But let me do the final
Jesús Cea Avión j...@jcea.es added the comment:
[j...@babylon5 py3k]$ ./python
Python 3.2a3+ (py3k:85834M, Oct 25 2010, 15:37:04)
[GCC 4.5.1] on sunos5
Type help, copyright, credits or license for more information.
import os
os.SEEK_DATA
3
os.SEEK_HOLE
4
--
Martin v. Löwis mar...@v.loewis.de added the comment:
The patch lacks a documentation change. Otherwise, it looks fine.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10142
___
Antoine Pitrou pit...@free.fr added the comment:
I think the docs should also make it clear that these flags are only supported
by os.lseek() (unless you have tested the IO lib to work properly, that is, but
in this case it would be nice to add unit tests).
--
Jesús Cea Avión j...@jcea.es added the comment:
I will update documentation.
Antoine, it is difficult to write a testcase when I can only test under a
system with ZFS. I don't think we have a buildbot with Solaris/*BSD and ZFS.
Any suggestion?.
--
Antoine Pitrou pit...@free.fr added the comment:
I will update documentation.
Antoine, it is difficult to write a testcase when I can only test
under a system with ZFS. I don't think we have a buildbot with
Solaris/*BSD and ZFS.
If you ascertain yourself that the test works under ZFS then
Martin v. Löwis mar...@v.loewis.de added the comment:
If you ascertain yourself that the test works under ZFS then I think it
is enough. Of course, it would be better if a buildbot ran that test,
but we can live without it (IMHO).
I agree. I trust that the patch is correct, and we really
Raymond Hettinger rhettin...@users.sourceforge.net added the comment:
Jesús, can you attach a patch (with the appropriate #ifdefs)?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10142
___
Jesús Cea Avión j...@jcea.es added the comment:
Seems to be adopted too in *bsd:
http://manpages.ubuntu.com/manpages/lucid/man2/lseek.2freebsd.html .
The feature has patches available too for Linux, but never integrated in
mainline kernel, AFAIK. Googling SEEK_HOLE is interesting.
--
Antoine Pitrou pit...@free.fr added the comment:
If it's just additional constants then I don't see the problem. We already have
a lot of platform-specific constants.
However, it would be a lot better if the io module were made to work properly
with these constants, too. There are a lot of
Martin v. Löwis mar...@v.loewis.de added the comment:
Am 19.10.2010 06:58, schrieb Raymond Hettinger:
Raymond Hettinger rhettin...@users.sourceforge.net added the
comment:
Martin, any thoughts on adding a ZFS dependent feature? ISTM this
Solaris feature hasn't taken hold elsewhere and
New submission from Jesús Cea Avión j...@jcea.es:
ZFS supports SEEK_HOLE/SEEK_DATA in lseek() syscall.
Oracle Solaris man page por lseek:
[...]
o If whence is SEEK_HOLE, the offset of the start of the
next hole greater than or equal to the supplied offset
is
Changes by Jesús Cea Avión j...@jcea.es:
--
components: +IO, Library (Lib)
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10142
___
___
Changes by Jesús Cea Avión j...@jcea.es:
--
stage: - needs patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10142
___
___
Python-bugs-list
Raymond Hettinger rhettin...@users.sourceforge.net added the comment:
Martin, any thoughts on adding a ZFS dependent feature? ISTM this Solaris
feature hasn't taken hold elsewhere and it may be a mistake to immortalize it
in Python.
--
assignee: - loewis
nosy: +loewis, rhettinger
73 matches
Mail list logo
