[issue10182] match_start truncates large values

Benjamin Peterson added the comment: It's good you were able to report this before we released anything. -- status: open -> closed ___ Python tracker ___

[issue10182] match_start truncates large values

Roundup Robot added the comment: New changeset 0f5067d9e1d8 by Benjamin Peterson in branch '2.7': use PyInt_FromSsize_t instead of PyLong_FromSsize_t (#10182) http://hg.python.org/cpython/rev/0f5067d9e1d8 -- ___ Python tracker

[issue10182] match_start truncates large values

Benjamin Peterson added the comment: Actually, 2.7 should just use PyInt_FromSsize_t, which only promotes when needed. -- ___ Python tracker ___

[issue10182] match_start truncates large values

Changes by Barry A. Warsaw : -- nosy: +benjamin.peterson ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:/

[issue10182] match_start truncates large values

Barry A. Warsaw added the comment: Nosied Benjamin since this is a release issue. Re-opened, assigned to him, and release blocked for 2.7.4. -- assignee: -> benjamin.peterson nosy: +georg.brandl, larry priority: normal -> release blocker status: closed -> open ___

[issue10182] match_start truncates large values

Barry A. Warsaw added the comment: Note that this change is causing problems with genshi due to API backward incompatibility. This is reported here: https://bugs.launchpad.net/ubuntu/+source/python2.7/+bug/1097783 The reason the user found it in Ubuntu first is that we track hg tip, but I've

[issue10182] match_start truncates large values

Changes by Antoine Pitrou : -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___ _

[issue10182] match_start truncates large values

Roundup Robot added the comment: New changeset de0f38f9280e by Antoine Pitrou in branch '2.7': Issue #10182: The re module doesn't truncate indices to 32 bits anymore. http://hg.python.org/cpython/rev/de0f38f9280e -- ___ Python tracker

[issue10182] match_start truncates large values

Roundup Robot added the comment: New changeset 0edc92d78192 by Antoine Pitrou in branch '3.2': Issue #10182: The re module doesn't truncate indices to 32 bits anymore. http://hg.python.org/cpython/rev/0edc92d78192 New changeset 21ceee08a375 by Antoine Pitrou in branch '3.3': Issue #10182: The re

[issue10182] match_start truncates large values

Antoine Pitrou added the comment: Thanks for the patch. For the record, the test passes successfully but it needs 40 GB, not 4 GB: http://buildbot.python.org/all/builders/AMD64%20Ubuntu%20LTS%20bigmem%20custom/builds/3 -- ___ Python tracker

[issue10182] match_start truncates large values

Serhiy Storchaka added the comment: Here is a test. -- Added file: http://bugs.python.org/file28181/buildvalue_overflow_tests.patch ___ Python tracker ___ ___

[issue10182] match_start truncates large values

Antoine Pitrou added the comment: Actually, we now have a 64-bit big endian buildbot and it does not show any test failure: http://buildbot.python.org/all/builders/SPARC%20Solaris%2010%20%28cc%2C%2064b%29%20%5BSB%5D%203.x [...] checking size of int... 4 checking size of long... 8 checking size

[issue10182] match_start truncates large values

Antoine Pitrou added the comment: > Actually, standard tests should be enough on a big-endian platform with > sizeof(int) < sizeof(size_t) or sizeof(long) < sizeof(size_t). No > additional tests needed. Ok, thanks. Unfortunately, all our 64-bit big endian buildbots are configured to produce 3

[issue10182] match_start truncates large values

Serhiy Storchaka added the comment: Actually, standard tests should be enough on a big-endian platform with sizeof(int) < sizeof(size_t) or sizeof(long) < sizeof(size_t). No additional tests needed. -- ___ Python tracker

[issue10182] match_start truncates large values

Serhiy Storchaka added the comment: I can't write a test, because I have no such big memory. -- ___ Python tracker ___ ___ Python-bugs

[issue10182] match_start truncates large values

Antoine Pitrou added the comment: Patch looks good to me. Do you think it's possible to add some bigmem tests for this? -- ___ Python tracker ___ ___

[issue10182] match_start truncates large values

Changes by Ezio Melotti : -- nosy: +pitrou ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue10182] match_start truncates large values

Serhiy Storchaka added the comment: Please review. -- keywords: +needs review ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue10182] match_start truncates large values

Changes by Serhiy Storchaka : -- stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue10182] match_start truncates large values

Changes by Serhiy Storchaka : -- components: +Regular Expressions nosy: +ezio.melotti, mrabarnett ___ Python tracker ___ ___ Python-bu

[issue10182] match_start truncates large values

Serhiy Storchaka added the comment: I analyzed all 1-valued usages of Py_BuildValue and found similar bags only in Modules/_sre.h. Here is a patch. Bugs should be evident on big-endian platform with sizeof(int) < sizeof(size_t) or sizeof(long) < sizeof(size_t). Standard tests should fail on su

[issue10182] match_start truncates large values

Changes by Serhiy Storchaka : -- keywords: +easy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue10182] match_start truncates large values

Changes by Serhiy Storchaka : -- components: +Library (Lib) stage: -> needs patch type: -> behavior ___ Python tracker ___ ___ Pytho

[issue10182] match_start truncates large values

Changes by Serhiy Storchaka : -- nosy: +storchaka versions: +Python 3.3 -Python 3.1 ___ Python tracker ___ ___ Python-bugs-list mailin

[issue10182] match_start truncates large values

New submission from Martin v. Löwis : _sre.c:match_start currently uses Py_BuildValue("i") to return the start index, which itself is of type Py_ssize_t. This will get truncated on x64 Windows if the start is > 2**31. PyInt_FromSsize_t should be used instead. Other usages of Py_BuildValue shou