[issue10246] uu.encode fd leak if arguments are filenames

2010-10-31 Thread Brett Cannon
Brett Cannon br...@python.org added the comment: On Sat, Oct 30, 2010 at 06:04, Antoine Pitrou rep...@bugs.python.org wrote: Antoine Pitrou pit...@free.fr added the comment: Committed in r85975 (3.2). I guess we'll do a big svnmerge to other branches later. Or not at all. I honestly have

[issue10246] uu.encode fd leak if arguments are filenames

2010-10-31 Thread Brian Brazil
Brian Brazil brian.bra...@gmail.com added the comment: The garbage collector should take care of the vast majority of these, it's only bugs in the C like issue 10253 that I'd worry about. -- ___ Python tracker rep...@bugs.python.org

[issue10246] uu.encode fd leak if arguments are filenames

2010-10-30 Thread Brian Brazil
New submission from Brian Brazil brian.bra...@gmail.com: Please see attached patch, I'm not sure if this is the cleanest way to fix this. This also fixes the resource warnings in the test. -- components: Library (Lib) files: uu_fd_leak.patch keywords: patch messages: 119975 nosy:

[issue10246] uu.encode fd leak if arguments are filenames

2010-10-30 Thread Antoine Pitrou
Antoine Pitrou pit...@free.fr added the comment: I think there should be a try..finally block so that those files get closed even when there's an error in-between. -- nosy: +pitrou ___ Python tracker rep...@bugs.python.org

[issue10246] uu.encode fd leak if arguments are filenames

2010-10-30 Thread Brian Brazil
Brian Brazil brian.bra...@gmail.com added the comment: How does v2 look? -- Added file: http://bugs.python.org/file19426/uu_fd_leak_v2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10246

[issue10246] uu.encode fd leak if arguments are filenames

2010-10-30 Thread Antoine Pitrou
Antoine Pitrou pit...@free.fr added the comment: How does v2 look? Nice, thank you! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10246 ___

[issue10246] uu.encode fd leak if arguments are filenames

2010-10-30 Thread Antoine Pitrou
Antoine Pitrou pit...@free.fr added the comment: Committed in r85975 (3.2). I guess we'll do a big svnmerge to other branches later. -- resolution: - fixed stage: - committed/rejected status: open - closed versions: +Python 3.2 -Python 3.3 ___