Benjamin Peterson benja...@python.org added the comment:
Committed my patch in r70555.
--
resolution: - accepted
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1034053
Benjamin Peterson benja...@python.org added the comment:
Ok, here's my unittest skipping patch. It supports skipping classes and
expected failures and includes skipping decorators.
I had to employ a little evil to make test skipping work for classes.
The made a new TestSuite class called
Benjamin Peterson benja...@python.org added the comment:
Here's the patch on Rietveld: http://codereview.appspot.com/27095
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1034053
___
Changes by Benjamin Peterson benja...@python.org:
Removed file: http://bugs.python.org/file13396/unittest_galore.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1034053
___
Changes by Benjamin Peterson benja...@python.org:
Added file: http://bugs.python.org/file13399/unittest_galore.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1034053
___
Benjamin Peterson benja...@python.org added the comment:
I've attached a new patch which takes into account Antoine's review.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1034053
___
Benjamin Peterson benja...@python.org added the comment:
I think this is a good improvement, and I hope it can make it into 2.7/3.1.
Several comments on patch:
- I don't like the name SkipException SkipTest is better IMO.
- TestResult.addSkipped should be changed to TestResult.addSkip.
- I'm
Antoine Pitrou pit...@free.fr added the comment:
Pupeno's patch looks good to me. Additional candy would be a decorator
to flag skipped tests (e.g. @skipped_test or @skipped_test(A
message)), but we can do that later.
--
stage: - patch review
type: - feature request
versions: +Python
Remy Blank remy.bl...@pobox.com added the comment:
There's still a typo in the docstring of TestResult.addSkipped() (tuble
- tuple).
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1034053
___
J. Pablo Fernández [EMAIL PROTECTED] added the comment:
Hello,
The attached patch adds the skip functionality and tests to a very
recent (yesterday) Python 3. It took me a few hours to apply the patch,
change to Python 3 style, merge the tests into the current set of tests
not doing a mess.
I
J. Pablo Fernández [EMAIL PROTECTED] added the comment:
Oh, I forgot to upgrade versions to include Python 3.0 and to mention
that I have to fix some other tests to work with the new TestCase. It's
nothing serious, just doctests that where too dependent on the output of
the TextTestRunner. As
Steve Purcell added the comment:
The status of this ticket is unchanged. I'm somewhat removed from the
Python scene in recent times, and I'm not in a position to apply this
patch or a variation of it.
I still believe this would be a beneficial change to the unittest
module, though, and
Georg Brandl added the comment:
I'll take it.
--
assignee: purcell - georg.brandl
nosy: +georg.brandl
_
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1034053
_
Changes by Giampaolo Rodola':
--
nosy: +giampaolo.rodola
_
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1034053
_
___
Python-bugs-list mailing list
Unsubscribe:
Antoine Pitrou added the comment:
So what's the status of this? Skipping test is still an important
ability to have.
--
nosy: +pitrou
_
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1034053
_
15 matches
Mail list logo
