Gregory P. Smith added the comment:
It looks like someone has already done the Python-ast cleanup and I don't
understand the point of the distutils test one or the libffi one (ffi has been
updated but it's trivial and would still apply).
--
nosy: +gregory.p.smith
Gregory P. Smith added the comment:
I'm not inclined to apply the patch to ffi unless someone can demonstrate that
it is an actual problem. given that nobody has applied it to *upstream* libffi
(since we just pulled in v3.0.13 earlier this week) I doubt it matters to
anyone.
everything here
Éric Araujo added the comment:
I don't understand the point of the distutils test one
Making the test not fail wrongly with some compilers. This was committed.
--
stage: patch review - committed/rejected
___
Python tracker rep...@bugs.python.org
Éric Araujo mer...@netwok.org added the comment:
Do the changes to Python/Python-ast.c and Modules/_ctypes/libffi/src/x86/ffi.c
still apply? (libffi is an external project, but our copy is already edited so
we might as well do one more change).
--
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset fe0972e102cd by Éric Araujo in branch '3.2':
Make C code in one distutils test comply with ISO C (#10359).
http://hg.python.org/cpython/rev/fe0972e102cd
New changeset 9ded1f21f0fd by Éric Araujo in branch 'default':
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 134b68cae802 by Éric Araujo in branch '2.7':
Make C code in one distutils test comply with ISO C (#10359).
http://hg.python.org/cpython/rev/134b68cae802
--
___
Python
Ezio Melotti ezio.melo...@gmail.com added the comment:
According to the latest patch updated by Victor, there are only 3 files left:
* Lib/distutils/tests/test_config_cmd.py
* Python/Python-ast.c
* Modules/_ctypes/libffi/src/x86/ffi.c
The first is in a test and it's probably safe to fix
Éric Araujo mer...@netwok.org added the comment:
I will commit this fix and push this week-end or Monday.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10359
___
Roundup Robot devnull@devnull added the comment:
New changeset 74fa7b4b934f by Éric Araujo in branch 'default':
Port r86353 to packaging (#10359: “;” after function definition is invalid in
ISO C)
http://hg.python.org/cpython/rev/74fa7b4b934f
--
nosy: +python-dev
Hallvard B Furuseth h.b.furus...@usit.uio.no added the comment:
STINNER Victor writes:
Python-ast.c: why do you move req_name and req_type outside PyAST_obj2mod()?
Eh, in case I've managed to be sufficiently unclear: The reason I
modified it at all was because the initialization is not valid
Antoine Pitrou pit...@free.fr added the comment:
Stable branches (2.7 and 3.1) only get bug fixes, not new features or
code cleanups.
Éric, making code compliant *is* a bug fix (admittedly of minor importance
here, since all modern compilers accept the non-compliant code anyway).
--
Hallvard B Furuseth h.b.furus...@usit.uio.no added the comment:
,AIric Araujo writes:
By the way, do these changes actually fix errors or are they just
cleanups and pedantic (not a slight) fixes?
I've used compilers where they'd be compile errors, though I found them
just with gcc -pedantic
Senthil Kumaran orsent...@gmail.com added the comment:
Hallvard, if it going be a rather huge diff, you may make it available at
http://bugs.python.org/review, so that it is easy for review.
--
nosy: +orsenthil
___
Python tracker
STINNER Victor victor.stin...@haypocalc.com added the comment:
I commited a part of your patches:
r86353 Remove ; after function definition, invalid in ISO C
r86354: [array] int = Py_UNICODE (my commit is a little bit different, but it
is based on your patch)
r86355: [_pickle] Remove useless
Hallvard B Furuseth h.b.furus...@usit.uio.no added the comment:
STINNER Victor writes:
Python-ast.c: why do you move req_name and req_type outside PyAST_obj2mod()?
Because there's no need to initialize the arrays each time PyAST_obj2mod
is called. C90-friendly code inside PyAST_obj2mod would
Hallvard B Furuseth h.b.furus...@usit.uio.no added the comment:
Hallvard B Furuseth writes:
(...) which is what the current code actually executes.
Er, I mean, that's what it does with req_type.
The 'static' for req_name is an optimization of the current code.
--
Éric Araujo mer...@netwok.org added the comment:
I've used compilers where they'd be compile errors, though I found
them just with gcc -pedantic in an idle moment.
If Victor accepts the patches then they’re useful :)
If the latter, I think they won’t go into stable branches.
Not until
New submission from Hallvard B Furuseth h.b.furus...@usit.uio.no:
Here are some ISO C conformance patches, and
a minor cleanup I encountered along the way.
Lib/distutils/tests/test_config_cmd.py // comment -- /* comment */.
Lib/distutils/tests/test_build_ext.py,
Objects/weakrefobject.c,
Éric Araujo mer...@netwok.org added the comment:
If it’s not too much trouble for you, please post diffs as text files rather
than binary. You can also use “svn diff” to produce one file with all
differences.
--
nosy: +eric.araujo
___
Python
Éric Araujo mer...@netwok.org added the comment:
By the way, do these changes actually fix errors or are they just cleanups and
pedantic (not a slight) fixes? If the latter, I think they won’t go into
stable branches. I don’t do C though, so I won’t be the one to judge. Thanks
for the
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +amaury.forgeotdarc
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10359
___
___
21 matches
Mail list logo
