[issue10504] Trivial mingw compile fixes

Change by Irit Katriel : -- resolution: duplicate -> wont fix ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue10504] Trivial mingw compile fixes

Change by Irit Katriel : -- resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> MinGW is unsupported - close all open issues and list them here. ___ Python tracker

[issue10504] Trivial mingw compile fixes

Martin Panter added the comment: The patch seems to share some changes to Modules/posixmodule.c with parts of Issue 17598’s patch (and one common part has already been applied). Issue 17591 already fixed to lowercase. Just now Issue 28269 has been opened about strcasecmp(). --

[issue10504] Trivial mingw compile fixes

Changes by Éric Araujo mer...@netwok.org: -- nosy: +eric.araujo versions: +Python 3.3 -Python 2.7 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10504 ___

[issue10504] Trivial mingw compile fixes

Changes by Kalev Lember kalevlem...@gmail.com: -- nosy: +kalev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10504 ___ ___ Python-bugs-list

[issue10504] Trivial mingw compile fixes

Changes by Ralf Schmitt sch...@gmail.com: -- nosy: +schmir ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10504 ___ ___ Python-bugs-list mailing

[issue10504] Trivial mingw compile fixes

Martin v. Löwis mar...@v.loewis.de added the comment: Why exactly are you skeptical? Because it doesn't fix everything in one go? The other changes are also minimal (I'm not even sure if it requires more source changes, maybe I have just to get my #defines right). If you prefer to see a

[issue10504] Trivial mingw compile fixes

Johann Hanne pyt...@jf.hanne.name added the comment: Well... ok. Although I already regard the patch as a strict bugfix (it fixes compilation of some C modules on MinGW), I'll go forward and create a patch for Python 3.2 which fixes compilation of all C modules on MinGW (all which are

[issue10504] Trivial mingw compile fixes

Amaury Forgeot d'Arc amaur...@gmail.com added the comment: But a strict bugfix should fix something. Is there something that did not work before, and will work after this patch? IOW, how do you compile posixmodule.c with MinGW and does it produce a working module? Now, I *am* interested in a

[issue10504] Trivial mingw compile fixes

New submission from Johann Hanne pyt...@jf.hanne.name: There are a number of mingw compile issues which are easily fixed * some _MSC_VER #if's should be MS_WINDOWS instead * for cross-compiling, windows.h should be all-lowercase * mingw has a strcasecmp, so private implementations must not use

[issue10504] Trivial mingw compile fixes

Martin v. Löwis mar...@v.loewis.de added the comment: What's the objective of this patch? I.e. what precisely is it supposed to achieve? -- nosy: +loewis ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10504

[issue10504] Trivial mingw compile fixes

Johann Hanne pyt...@jf.hanne.name added the comment: Python 2.7 will currently not compile with MinGW for the outlined reasons. * There are several #if defined(_MSC_VER) macros which surround Windows specific code/preprocessor fragments. But _MSC_VER is only defined with the Visual Studio

[issue10504] Trivial mingw compile fixes

Johann Hanne pyt...@jf.hanne.name added the comment: What's the objective of this patch? I.e. what precisely is it supposed to achieve? So the answer is: It will fix compiling with gcc/MinGW by fixing the 3 issues described. -- ___ Python

[issue10504] Trivial mingw compile fixes

Changes by Roumen Petrov bugtr...@roumenpetrov.info: -- nosy: +rpetrov ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10504 ___ ___

[issue10504] Trivial mingw compile fixes

Amaury Forgeot d'Arc amaur...@gmail.com added the comment: I doubt this fix will be enough to fix compilation with mingw32. But IMO it goes in the right direction. With this patch, #ifdef MS_WINDOWS has the meaning of linked with some version of MSVCRT. Do we agree on this, or is another

[issue10504] Trivial mingw compile fixes

Martin v. Löwis mar...@v.loewis.de added the comment: I doubt this fix will be enough to fix compilation with mingw32. So somebody will have to verify independently. If it fails to fix the bug completely, it's out of scope for 2.7 (it's out of scope for 2.7.1 IMO either way). With this

[issue10504] Trivial mingw compile fixes

Johann Hanne pyt...@jf.hanne.name added the comment: I've revised the patch to use defined(_MSC_VER) || defined(__MINGW32__) as suggested. And no, it does not solve all mingw compilition issues, but most of them. I've tried to only address the most obvious ones, which are *very* unlikely to

[issue10504] Trivial mingw compile fixes

Martin v. Löwis mar...@v.loewis.de added the comment: Please give me some starting point by applying these patches. I don't care if it's for 2.7.1 or 2.7.2. I'll try hard to get *everything* fixed, but we have to start somewhere. I'm skeptical that we should do that with 2.7, then. So it

[issue10504] Trivial mingw compile fixes

Johann Hanne pyt...@jf.hanne.name added the comment: Why exactly are you skeptical? Because it doesn't fix everything in one go? The other changes are also minimal (I'm not even sure if it requires more source changes, maybe I have just to get my #defines right). If you prefer to see a single

[issue10504] Trivial mingw compile fixes

Amaury Forgeot d'Arc amaur...@gmail.com added the comment: Since the patch does not completely fix the mingw32 build, I suggest to apply it only on 3.2, and continue to work on mingw32 support there. Only after we will be able to discuss whether all the changes can be backported to 2.7,