Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 958a98bf924e by Eli Bendersky in branch 'default':
updated whatsnew/3.3.rst with the new methods added to list and bytearray
(issue 10516)
http://hg.python.org/cpython/rev/958a98bf924e
--
nosy: +python-dev
Eli Bendersky eli...@gmail.com added the comment:
Committed the bytearray methods in revision 88733.
Closing this issue. Will handle wrong exception and MutableSequence ABC method
addition in separate issues.
--
status: open - closed
___
Python
Raymond Hettinger rhettin...@users.sourceforge.net added the comment:
Hmm, shouldn't self.__class__(self) be a
good default implementation of copy()?
I'd expect any sequence to support this way
of creation from another sequence, even if it's inefficient.
The copy() method isn't being
Raymond Hettinger rhettin...@users.sourceforge.net added the comment:
The patch is fine. Do consider using assertIsNot() in the tests. Then go
ahead and apply it.
The OverflowError in bytearray.pop() is a bug, please open a separate report
for it and make a patch changing it to IndexError.
Georg Brandl ge...@python.org added the comment:
Hmm, shouldn't self.__class__(self) be a good default implementation of copy()?
I'd expect any sequence to support this way of creation from another sequence,
even if it's inefficient.
--
___
Python
Eli Bendersky eli...@gmail.com added the comment:
Attaching a patch adding copy() and clear() to bytearrays, with tests and doc.
I didn't add the methods to MutableSequence because I have a doubt about it -
in particular which exception get raised by .pop if it's empty. Curiously,
lists and
Georg Brandl ge...@python.org added the comment:
Reading clear and copy are not supported by bytearray: shouldn't they be?
(sort probably really makes no sense on bytearrays.)
--
___
Python tracker rep...@bugs.python.org
Eli Bendersky eli...@gmail.com added the comment:
On Fri, Feb 25, 2011 at 10:11, Georg Brandl rep...@bugs.python.org wrote:
Georg Brandl ge...@python.org added the comment:
Reading clear and copy are not supported by bytearray: shouldn't they be?
Perhaps they should, and it's not a big deal
Raymond Hettinger rhettin...@users.sourceforge.net added the comment:
Unless someone raises a controversial and non-trivial issue about adding
clear() and copy() to bytearray, there is no need for a python-dev discussion
on the subject. Just post a patch to the tracker.
--
Georg Brandl ge...@python.org added the comment:
Yes, it should be discussed on python-dev.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10516
___
Georg Brandl ge...@python.org added the comment:
In any case, this issue can be closed.
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10516
___
Boštjan Mejak bostjan.me...@gmail.com added the comment:
I have installed Python 3.2 final on my Windows machine and I get an
exception when doing list.copy or list.clear in the interpreter. Why is that
so?
--
Added file: http://bugs.python.org/file20886/unnamed
Georg Brandl ge...@python.org added the comment:
Because they got added *after* 3.2 was released?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10516
___
Boštjan Mejak bostjan.me...@gmail.com added the comment:
Right, right. My bad. Can't wait for Python 3.3! ;)
--
Added file: http://bugs.python.org/file20887/unnamed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10516
Raymond Hettinger rhettin...@users.sourceforge.net added the comment:
Georg, what is the issue? Is there some reason that bytearrays should not be
copied or cleared? Is there some reason to prefer the current:
dup = b[:] # copy
del b[:] # clear
--
Georg Brandl ge...@python.org added the comment:
No -- but the question is if copy() and clear() mightn't be added to the
(mutable) sequence ABC if we make all builtin such sequences implement them.
--
___
Python tracker rep...@bugs.python.org
Raymond Hettinger rhettin...@users.sourceforge.net added the comment:
The ABCs are subset of the methods for the concrete APIs. We've avoided the
likes of copy() because it requires knowledge of the constructor's signature --
for example, MutableMapping does not cover copy().
It is okay for
Eli Bendersky eli...@gmail.com added the comment:
A slightly revised patch committed in revision 88554:
1. Fixed Éric's whitespace comment
2. Fixed a test in test_descrtut.py which was listing list's methods
3. Moved the change to collections.py onto Lib/collections/__init__.py
4. Added NEWS
Raymond Hettinger rhettin...@users.sourceforge.net added the comment:
The patch looks great.
Please apply it.
--
assignee: rhettinger - eli.bendersky
resolution: later - accepted
___
Python tracker rep...@bugs.python.org
Ray.Allen ysj@gmail.com added the comment:
Please modify the patch so that it can be applied to current py3k trunk
cleanly. (Notice that Lib/collections.py has been changed to a package in
#11085).
--
___
Python tracker rep...@bugs.python.org
Éric Araujo mer...@netwok.org added the comment:
Ray: Eli can just refresh his patch and commit. Note that the patch program
will prompt you for a file name if it can’t find the file for a diff hunk, so
it should be trivial to apply a patch across a rename.
Eli: Would you mind changing two
Raymond Hettinger rhettin...@users.sourceforge.net added the comment:
Eli doesn't need to post a new patch. I'm sure he will fix any nits in his
commit.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10516
Eli Bendersky eli...@gmail.com added the comment:
On Thu, Feb 24, 2011 at 05:26, Éric Araujo rep...@bugs.python.org wrote:
Éric Araujo mer...@netwok.org added the comment:
Ray: Eli can just refresh his patch and commit. Note that the patch program
will prompt you for a file name if it
Changes by Eli Bendersky eli...@gmail.com:
--
nosy: +ncoghlan
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10516
___
___
Python-bugs-list mailing
Raymond Hettinger rhettin...@users.sourceforge.net added the comment:
[Éric Araujo]
+L.clear() - None -- remove all items from L);
It looks like other methods that return None
just omit the “- type” part.
These kind of nitty comments really aren't helpful.
It consumes more time to talk
Changes by Georg Brandl ge...@python.org:
--
stage: needs patch - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10516
___
___
Changes by Antoine Pitrou pit...@free.fr:
--
stage: unit test needed - needs patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10516
___
___
Eli Bendersky eli...@gmail.com added the comment:
Updated patch with versionadded tag for the new methods
--
Added file: http://bugs.python.org/file20056/issue10516.5.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10516
Ray.Allen ysj@gmail.com added the comment:
That's good if it's so... can you explain why list_clear doesn't
guarantee that the list is empty? Why would XDECREF populate the list?
I don't quite understand it.
Does this mean that durning the Py_DECREF progress the list may be populated
Ray.Allen ysj@gmail.com added the comment:
eli, you should also add New in version 3.3 to the doc of the tow new list
methods.
--
nosy: +ysj.ray
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10516
Boštjan Mejak bostjan.me...@gmail.com added the comment:
mapp_methods ? Don't you mean map_methods ?
--
Added file: http://bugs.python.org/file19954/unnamed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10516
Georg Brandl ge...@python.org added the comment:
No, he means mapp_methods. Why don't you simply look at the file?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10516
___
Boštjan Mejak bostjan.me...@gmail.com added the comment:
mapp_methods looks like a typo. you know -- mapp_...? isn't map_... correct?
--
Added file: http://bugs.python.org/file19957/unnamed
___
Python tracker rep...@bugs.python.org
Brian Curtin cur...@acm.org added the comment:
No, and please do not clutter this issue with any perceived typo discussions.
--
nosy: +brian.curtin
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10516
Changes by Éric Araujo mer...@netwok.org:
Removed file: http://bugs.python.org/file19954/unnamed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10516
___
Changes by Éric Araujo mer...@netwok.org:
Removed file: http://bugs.python.org/file19957/unnamed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10516
___
Boštjan Mejak bostjan.me...@gmail.com added the comment:
Why mapp_methods, why not map_methods? Any reason for this?
--
Added file: http://bugs.python.org/file19959/unnamed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10516
Changes by Eric Smith e...@trueblade.com:
Removed file: http://bugs.python.org/file19959/unnamed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10516
___
Éric Araujo mer...@netwok.org added the comment:
1) Obviously because they’re mapping methods, not map methods.
2) Again, opening up the file and looking through it for some seconds or
minutes would have allowed you to understand it.
3) Again, this is not the right place to discuss this.
4)
Boštjan Mejak bostjan.me...@gmail.com added the comment:
I'm troubled with one little letter:
L.copy() - list -- a shallow copy of L); should be
L.copy() - list -- shallow copy of L); without the letter 'a',
because other sentences also don't say L.__sizeof__() -- *A* size of
L in memory,
Boštjan Mejak bostjan.me...@gmail.com added the comment:
Can you please help me find the definition of the copy() method of dict in
the Python sources? I want to see how that method is defined and compare the
definition to the one in Eli's patch.
--
Added file:
Changes by Mark Dickinson dicki...@gmail.com:
Removed file: http://bugs.python.org/file19947/unnamed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10516
___
Changes by Mark Dickinson dicki...@gmail.com:
Removed file: http://bugs.python.org/file19948/unnamed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10516
___
Terry J. Reedy tjre...@udel.edu added the comment:
Objects/dictobject.c
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10516
___
___
Eli Bendersky eli...@gmail.com added the comment:
Boštjan,
a shallow copy: I took this directly from the documentation of dicts, which
says:
D.copy() - a shallow copy of D)
As I mentioned in an earlier message, the doc-strings of list and dict methods
are inconsistent in more than one
Eli Bendersky eli...@gmail.com added the comment:
Was list.copy() also approved? After all, there are many ways to achieve the
same even now:
1. L[:]
2. list(L)
3. import copy and then copy.copy
Especially re the last one: list.copy() can be deep or shallow, which one
should it be?
Eli Bendersky eli...@gmail.com added the comment:
Also, where is the *official* place to document list objects and their methods?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10516
___
Georg Brandl ge...@python.org added the comment:
Yes, list.copy was also approved IIRC. And it should be a shallow copy, like
all other copy methods on builtins.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10516
Boštjan Mejak bostjan.me...@gmail.com added the comment:
This is really welcome. It makes Python even more readable.
If 'a' is a list object, a[:] is not so obvious at first to a newcomer, but
a.copy() is.
Also, a.clear() is so perfect and understandable. I wish you could decorate
Python
Eli Bendersky eli...@gmail.com added the comment:
Attaching a patch with the following:
1. list.copy() and list.clear() implemented in Objects/listobject.c, with
appropriate doc strings (modeled after dict's docstrings)
2. Same methods implemented in collections.UserList
3. Tests added that
Éric Araujo mer...@netwok.org added the comment:
Hi Eli,
I think the right place is 4.6.4,
http://docs.python.org/dev/library/stdtypes#mutable-sequence-types
It starts with “List and bytearray objects support additional operations
that allow in-place modification of the object”.
For methods
Changes by Raymond Hettinger rhettin...@users.sourceforge.net:
--
assignee: - rhettinger
keywords: +easy -patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10516
___
Eli Bendersky eli...@gmail.com added the comment:
Following Éric's suggestion, I'm attaching an updated patch with with the
documentation in Doc/library/stdtypes.rst updated with the new methods.
There seems to be a slight Sphinx markup problem with this addition. I rewrote
note (8) as:
Changes by Eli Bendersky eli...@gmail.com:
Removed file: http://bugs.python.org/file19835/issue10516.1.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10516
___
Changes by Eli Bendersky eli...@gmail.com:
Removed file: http://bugs.python.org/file19938/issue10516.2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10516
___
Raymond Hettinger rhettin...@users.sourceforge.net added the comment:
Nothing will happen on this until 3.2 is done and the py3k branch starts with
3.3 submissions.
--
resolution: - later
___
Python tracker rep...@bugs.python.org
Éric Araujo mer...@netwok.org added the comment:
Eli, I learned this trick recently: :meth:`!copy`.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10516
___
Eli Bendersky eli...@gmail.com added the comment:
Éric - thanks, it works [attaching updated patch]. However, don't you think the
core problem is a Sphinx bug we should report?
Raymond - this happens after final 3.2 release (on Feb 05 2011 if it's on
schedule), right?
--
Added file:
Changes by Eli Bendersky eli...@gmail.com:
Removed file: http://bugs.python.org/file19943/issue10516.3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10516
___
Changes by Eli Bendersky eli...@gmail.com:
--
nosy: +eli.bendersky
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10516
___
___
Python-bugs-list
Eli Bendersky eli...@gmail.com added the comment:
Objects/listobject.c has a static function named list_clear used internally. Is
it possible to just expose this function as a clear() method?
One problem is that it has this strange comment in the end:
/* Never fails; the return value can
Xuanji Li xua...@gmail.com added the comment:
Hi, I'm also looking at listobject.c also... if we want list.clear() to behave
exactly like del list[], we may be able to just call list_ass_slice on the
list. Similarly for list.copy which should behave like a=l[:]
--
nosy: +xuanji
Eli Bendersky eli...@gmail.com added the comment:
Hi, I'm also looking at listobject.c also... if we want list.clear() to
behave exactly like del list[], we may be able to just call list_ass_slice
on the list. Similarly for list.copy which should behave like a=l[:]
Note that when executed
Georg Brandl ge...@python.org added the comment:
Yes, list_clear should be called, but no, it cannot be used directly because a
method needs a PyObject* return value. So a wrapper method is needed that
looks like listappend() does for list.append(). list_copy() will just look like
Xuanji Li xua...@gmail.com added the comment:
That's good if it's so... can you explain why list_clear doesn't guarantee that
the list is empty? Why would XDECREF populate the list? I don't quite
understand it.
eli: are you writing a patch for this?
--
Eli Bendersky eli...@gmail.com added the comment:
Georg,
Thanks. Of course it should be wrapped like the others :-)
Xuanji,
Yes, I will try to get in something preliminary today.
--
___
Python tracker rep...@bugs.python.org
Eli Bendersky eli...@gmail.com added the comment:
Attaching a patch for list.clear():
1. Implements a new function in Objects/listobject.c named listclear() (to be
consistent with the other method functions)
2. listclear() is registered in list_methods and just calls list_clear(),
returning
Changes by Eli Bendersky eli...@gmail.com:
Removed file: http://bugs.python.org/file19834/unnamed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10516
___
Changes by Eli Bendersky eli...@gmail.com:
--
Removed message: http://bugs.python.org/msg122522
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10516
___
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10516
___
___
Changes by Éric Araujo mer...@netwok.org:
--
nosy: +eric.araujo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10516
___
___
Python-bugs-list
New submission from Terry J. Reedy tjre...@udel.edu:
Add list.clear() method with obvious semantics.
Pro:
1. parallel to set/dict/defaultdict/deque.clear(),
usable in generic mutable collection function;
2. makes it easier to switch between list and other collection class;
3. current
Eric Smith e...@trueblade.com added the comment:
Guido's email is archived at:
http://mail.python.org/pipermail/python-ideas/2010-November/008732.html
--
nosy: +eric.smith
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10516
Raymond Hettinger rhettin...@users.sourceforge.net added the comment:
Guido approved these both in a thread earlier this year.
The reasoning for copy() was the same as for clear(), some folks couldn't cope
with:
b = a[:]
--
nosy: +rhettinger
title: Add list.clear() - Add
74 matches
Mail list logo
