Roundup Robot devnull@devnull added the comment:
New changeset 6e9dc970ac0e by Victor Stinner in branch 'default':
Issue #10785: Store the filename as Unicode in the Python parser.
http://hg.python.org/cpython/rev/6e9dc970ac0e
--
nosy: +python-dev
Changes by STINNER Victor victor.stin...@haypocalc.com:
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10785
___
STINNER Victor victor.stin...@haypocalc.com added the comment:
@Benjamin: You told me that you don't want two versions of pgen, but I don't
remember why. As my work on #3080 is mostly done, I now plan to patch the
Python parser to store the filename as Unicode. So could you please review the
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +benjamin.peterson
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10785
___
___
Python-bugs-list
STINNER Victor victor.stin...@haypocalc.com added the comment:
err_clear() should set err-filename to NULL.
--
versions: -Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10785
___
STINNER Victor victor.stin...@haypocalc.com added the comment:
Version 3 of the patch to fix also #9319.
--
Added file: http://bugs.python.org/file20271/parser_filename_obj-3.patch
___
Python tracker rep...@bugs.python.org
Changes by STINNER Victor victor.stin...@haypocalc.com:
Removed file: http://bugs.python.org/file20180/parser_filename_obj.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10785
___
Changes by STINNER Victor victor.stin...@haypocalc.com:
Removed file: http://bugs.python.org/file20184/parser_filename_obj-2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10785
___
Alexander Belopolsky belopol...@users.sourceforge.net added the comment:
I like the idea, but I don't like the trend that parser code continues to
diverge from pgen. I understand that most of the Python runtime is not
available to pgen, but maybe a more elegant solution than changing the type
STINNER Victor victor.stin...@haypocalc.com added the comment:
maybe a more elegant solution than changing the type conditional
on PGEN can be found
In pgen, the filename is only used to display the following warning, in
indenterror():
filename: inconsistent use of tabs and spaces in
STINNER Victor victor.stin...@haypocalc.com added the comment:
When testing my patch, I found and fixed two bugs in pgen:
- r87557: PGEN was not defined to compile pgenmain.c and printgrammar.c
- r87558: pgen error was ignored on make Parser/pgen.stamp (when executing
pgen to compile the
STINNER Victor victor.stin...@haypocalc.com added the comment:
Version 2 of the patch:
- remove filename attribute from perrdetail and tok_state structure in PGEN
mode, and add a comment to explain why
- rename filename_obj to filename
- indenterror() no longer print the input filename in
New submission from STINNER Victor victor.stin...@haypocalc.com:
The Python parser stores the filename as a byte string. But it decodes the
filename on error because most Python functions now use unicode strings.
Instead of decoding the filename at error, which may raise a new error, I
Changes by STINNER Victor victor.stin...@haypocalc.com:
Removed file: http://bugs.python.org/file20179/parse_filename_obj.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10785
___
Changes by STINNER Victor victor.stin...@haypocalc.com:
Added file: http://bugs.python.org/file20180/parser_filename_obj.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10785
___
15 matches
Mail list logo