Senthil Kumaran added the comment:
This has been backported.
3.2 5e71f2712076
3.3 30547e2cd04d
--
assignee: - orsenthil
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
Juho Vuori added the comment:
Should the bug be closed as it seems to be fixed now?
--
nosy: +juho
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10836
___
Senthil Kumaran added the comment:
Nope, I have backport it to other versions. I shall close it then.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10836
___
Senthil Kumaran added the comment:
Here is the patch which captures both HTTPError and URLError at the open_file
and thus preventing multiple exceptions to be raised ( URLError and next
IOError). This can go in 3.4 and since this is bug, where correct exception is
not being caught and wrong
Roundup Robot added the comment:
New changeset daef5526d2ac by Senthil Kumaran in branch 'default':
Issue #10836: Fix exception raised when file not found in urlretrieve
http://hg.python.org/cpython/rev/daef5526d2ac
--
nosy: +python-dev
___
Python
Senthil Kumaran added the comment:
This one is fixed in 3.4. I can see the previous versions raised IOError
exception and it is not a good idea to change by backporting. But the wrong
arguments on URLError should be fixed tough.
--
___
Python
Senthil Kumaran added the comment:
@Ezio, regarding msg172988. That's embarrassing. It should be fixed soon.
Review on the patch, how about having the strerror and filename from the
exception?
-raise URLError(e.errno, e.strerror, e.filename)
+raise URLError(e.strerror,
Chris Jerdonek added the comment:
This should be reported in another issue though.
Has this been done?
--
nosy: +chris.jerdonek
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10836
___
Ezio Melotti added the comment:
Nick reported #16247 today which is very similar.
--
nosy: +ncoghlan
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10836
___
Chris Jerdonek added the comment:
For tracking purposes, I created issue 16250 for what you observed above, which
as you said is related to but not the same as Nick's issue 16247.
--
___
Python tracker rep...@bugs.python.org
Terry J. Reedy added the comment:
The presence of During handling of the above exception, another exception
occurred: is part of an intentional change between 2.x and 3.x. Exception
handling has been tweaked a bit more in the past year. 3.2.3 only gives the
second half of the traceback, which
Ezio Melotti added the comment:
While fixing this issue is easy, there is a wider problem with the use of
URLError.
The constructor accepts two args, reason and filename. About half of the errors
in Lib/urllib/request.py use only one argument, and in the other half not a
single one uses the
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
stage: needs patch - patch review
Added file: http://bugs.python.org/file27584/issue10836-2.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10836
13 matches
Mail list logo
