[issue10838] subprocess __all__ is incomplete

Martin Panter added the comment: See Issue 26782 for a follow-up with Windows. -- ___ Python tracker ___ ___

[issue10838] subprocess __all__ is incomplete

Roundup Robot added the comment: New changeset cb38866e4c13 by Martin Panter in branch '3.5': Issue #10838: Run test__all__() everywhere, even if poll() is not available https://hg.python.org/cpython/rev/cb38866e4c13 -- ___ Python tracker

[issue10838] subprocess __all__ is incomplete

Martin Panter added the comment: IMO the two documented exceptions should definitely be added to __all__. Not so sure, but list2cmdline() should probably be left out, with a comment explaining the decision. It is not mentioned in the main documentation that I can find, but it is mentioned in

[issue10838] subprocess __all__ is incomplete

R. David Murray added the comment: I believe it is and should remain internal. I agree that the mention should be deleted from the docstring. We removed it from the docs a while back but I guess we forgot the docstring. (If there were an external API for doing what list2cmdline does, it

[issue10838] subprocess __all__ is incomplete

Roundup Robot added the comment: New changeset 10b0a8076be8 by Gregory P. Smith in branch 'default': Addresses Issue #10838: The subprocess now module includes https://hg.python.org/cpython/rev/10b0a8076be8 -- nosy: +python-dev ___ Python tracker

[issue10838] subprocess __all__ is incomplete

Gregory P. Smith added the comment: the things left to to before closing this are to rename mswindows and MAXFD as those shouldn't be exported... and to wait for the windows buildbots to tell me if i missed adding anything to the intentionally_excluded list in the unittest. --

[issue10838] subprocess __all__ is incomplete

Gregory P. Smith added the comment: Done. MAXFD was already gone in 3.5 (yay). -- assignee: - gregory.p.smith resolution: - fixed stage: needs patch - commit review status: open - closed type: - behavior versions: +Python 3.2 -Python 3.5 ___

[issue10838] subprocess __all__ is incomplete

Roundup Robot added the comment: New changeset 4c14afc3f931 by Gregory P. Smith in branch 'default': issue10838: Rename the subprocess.mswindows internal global to _mswindows. https://hg.python.org/cpython/rev/4c14afc3f931 -- ___ Python tracker

[issue10838] subprocess __all__ is incomplete

Changes by Berker Peksag berker.pek...@gmail.com: -- stage: commit review - resolved versions: +Python 3.5 -Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10838 ___

[issue10838] subprocess __all__ is incomplete

Serhiy Storchaka added the comment: For now there are three non-underscored names in subprocess that are missed in __all__: SubprocessError, TimeoutExpired, and list2cmdline. SubprocessError and TimeoutExpired are documented. -- nosy: +serhiy.storchaka stage: - needs patch versions:

[issue10838] subprocess __all__ is incomplete

Changes by Eli Bendersky eli...@gmail.com: -- nosy: -eli.bendersky ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10838 ___ ___ Python-bugs-list

[issue10838] subprocess __all__ is incomplete

Eli Bendersky eli...@gmail.com added the comment: Issue #11827 seems to be strongly related -- nosy: +eli.bendersky ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10838 ___

Re: [issue10838] subprocess __all__ is incomplete

On Thu, Jan 06, 2011 at 12:15:26AM +, Antoine Pitrou wrote: IMO they should all be prefixed with an underscore. Greg? +1 to this suggestion. It would make it consistent with expectations. But yeah, I also think that all public methods should be in __all__ is not a guarantee.

[issue10838] subprocess __all__ is incomplete

Changes by Éric Araujo mer...@netwok.org: -- nosy: +eric.araujo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10838 ___ ___ Python-bugs-list

[issue10838] subprocess __all__ is incomplete

Terry J. Reedy tjre...@udel.edu added the comment: My understanding is much like Toshio's: ambiguous (typically, undocumented or omitted from __all__) non-underscored names should be resolved, with the three possible outcomes listed, on a case-by-case basis. -- nosy: +terry.reedy

[issue10838] subprocess __all__ is incomplete

New submission from Toshio Kuratomi a.bad...@gmail.com: I have a compatibility module for subprocess in python-2.7 for people who are stuck on python-2.4 (without check_call) and they got a traceback from trying to use compat.subprocess.list2cmdline(). In order to use the stdlib's subprocess

[issue10838] subprocess __all__ is incomplete

Georg Brandl ge...@python.org added the comment: IMO none of these three are meant to be public, and neither are they documented. (Although the docs make a reference to the list2cmdline *method*, which should probably just be removed.) I remember a thread on python-dev about public-API-ness.

[issue10838] subprocess __all__ is incomplete

Toshio Kuratomi a.bad...@gmail.com added the comment: IIRC, it was more along the lines of: all private names should be underscored. The difference being that we get to choose whether currently non-underscored names should get underscored, should be deprecated and then underscored, or should

[issue10838] subprocess __all__ is incomplete

Toshio Kuratomi a.bad...@gmail.com added the comment: For other's reference, there were three threads in November2010 that touch on this: :About removing argparse.__all__ or adding more methods to it: http://mail.python.org/pipermail/python-dev/2010-November/105147.html :Removing tk

[issue10838] subprocess __all__ is incomplete

Antoine Pitrou pit...@free.fr added the comment: So, MAXFD, list2cmdline, and mswindows seem to be left out. IMO they should all be prefixed with an underscore. Greg? -- nosy: +gregory.p.smith, pitrou ___ Python tracker rep...@bugs.python.org

[issue10838] subprocess __all__ is incomplete

Changes by Antoine Pitrou pit...@free.fr: -- versions: +Python 3.2 -Python 2.7 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10838 ___ ___