[issue10852] SSL/TLS sni use in smtp, pop, imap, nntp, ftp client libs by default

Christian Heimes added the comment: Oh sorry, this is about SNI not verified context. All protocols support SNI for some time. -- resolution: -> out of date stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue10852] SSL/TLS sni use in smtp, pop, imap, nntp, ftp client libs by default

Christian Heimes added the comment: Good idea, but the patch is outdated. We can enforce verification by changing ssl._create_stdlib_context. -- assignee: -> christian.heimes nosy: +alex, dstufft, janssen priority: normal -> high versions: +Python 3.6, Python 3.7 -Python 3.4 _

[issue10852] SSL/TLS sni use in smtp, pop, imap, nntp, ftp client libs by default

Changes by Antoine Pitrou : -- nosy: +christian.heimes ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://m

[issue10852] SSL/TLS sni use in smtp, pop, imap, nntp, ftp client libs by default

Changes by Florian Weimer : -- nosy: +fweimer ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pytho

[issue10852] SSL/TLS sni use in smtp, pop, imap, nntp, ftp client libs by default

Daniel Black added the comment: Ack. Have fix. Simple if self.certfile or self.keyfile: test added before load_cert_chain. part way through developing test. Thinking #17181 would help. -- ___ Python tracker _

[issue10852] SSL/TLS sni use in smtp, pop, imap, nntp, ftp client libs by default

Changes by Senthil Kumaran : -- nosy: +orsenthil ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue10852] SSL/TLS sni use in smtp, pop, imap, nntp, ftp client libs by default

Antoine Pitrou added the comment: I'm getting a test failure in test_ftplib: == ERROR: test_data_connection (test.test_ftplib.TestTLS_FTPClass) -- Traceback (mo

[issue10852] SSL/TLS sni use in smtp, pop, imap, nntp, ftp client libs by default

danblack added the comment: the one error in the previous review corrected. -- ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue10852] SSL/TLS sni use in smtp, pop, imap, nntp, ftp client libs by default

danblack added the comment: > Thanks for the patch > Daniel. 3.3 is nearing the release candidate phase, so I'm re-targetting to > 3.4. I'll take a detailed look soon. Welcome. Just noticed conflicts with #4473 in the client POP implementation. Hopefully they are close anyway. > (I suppose th

[issue10852] SSL/TLS sni use in smtp, pop, imap, nntp, ftp client libs by default

Changes by R. David Murray : -- nosy: +r.david.murray ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://ma

[issue10852] SSL/TLS sni use in smtp, pop, imap, nntp, ftp client libs by default

Antoine Pitrou added the comment: By the way, could you sign a contributor agreement? You can find instructions at http://www.python.org/psf/contrib/ -- ___ Python tracker ___ _

[issue10852] SSL/TLS sni use in smtp, pop, imap, nntp, ftp client libs by default

Antoine Pitrou added the comment: Thanks for the patch, Daniel. 3.3 is nearing the release candidate phase, so I'm re-targetting to 3.4. I'll take a detailed look soon. (I suppose there's no easy way to write automated tests for this, unfortunately) -- stage: -> patch review versions:

[issue10852] SSL/TLS sni use in smtp, pop, imap, nntp, ftp client libs by default

danblack added the comment: previous patch had dumb error and even failed test suit. Now fixed. -- Added file: http://bugs.python.org/file26949/issue10852-sni.patch ___ Python tracker __

[issue10852] SSL/TLS sni use in smtp, pop, imap, nntp, ftp client libs by default

Changes by danblack : Removed file: http://bugs.python.org/file26918/issue_10852_pop-smtp-imap-nntp.patch ___ Python tracker ___ ___ Python-b

[issue10852] SSL/TLS sni use in smtp, pop, imap, nntp, ftp client libs by default

danblack added the comment: Antoine, I copied off your http example for all the other protocols. tested with: import smtplib a = smtplib.SMTP_SSL('gmail-smtp-in.l.google.com.') a.starttls() a = smtplib.SMTP_SSL('mail.internode.on.net') a = smtplib.SMTP_SSL('smtp.gmail.com') import ftplib #

[issue10852] SSL/TLS sni use in smtp, pop, imap, nntp, ftp client libs by default

Daniel Black added the comment: I thought previous comments you wanted SSLContext to become the primary api rather than wrap_socket? Coding this into the examples is probably a good way of making this happen. -- ___ Python tracker

[issue10852] SSL/TLS sni use in smtp, pop, imap, nntp, ftp client libs by default

Changes by Giampaolo Rodola' : -- nosy: +giampaolo.rodola ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:

[issue10852] SSL/TLS sni use in smtp, pop, imap, nntp, ftp client libs by default

Antoine Pitrou added the comment: Well, there are already such examples: http://docs.python.org/dev/library/ssl.html#examples Do you think they are not visible enough? -- ___ Python tracker __

[issue10852] SSL/TLS sni use in smtp, pop, imap, nntp, ftp client libs by default

Daniel Black added the comment: ok. should library/ssl.rst be updated to use a SSLContext example? -- ___ Python tracker ___ ___ Pyth

[issue10852] SSL/TLS sni use in smtp, pop, imap, nntp, ftp client libs by default

Antoine Pitrou added the comment: I understand this patch relies on #10851. As I said there, I would rather have SSLContext become the primary API, and the stdlib standardize on it. Part of the stdlib, as you have witnessed, already allows the user to pass a custom SSLContext, which is very s

[issue10852] SSL/TLS sni use in smtp, pop, imap, nntp, ftp client libs by default

Antoine Pitrou added the comment: Oops, I hadn't noticed you had closed it. -- nosy: +pitrou resolution: duplicate -> status: closed -> open ___ Python tracker ___

[issue10852] SSL/TLS sni use in smtp, pop, imap, nntp, ftp client libs by default

Daniel Black added the comment: dup #10853 -- nosy: -pitrou resolution: -> duplicate status: open -> closed ___ Python tracker ___

[issue10852] SSL/TLS sni use in smtp, pop, imap, nntp, ftp client libs by default

New submission from Daniel Black : Like r85793, sni is enabled by default for url and https classes. This continues the consistency throughout the python libraries by adding it to other places where wrap_socket is used to instigate a SSL/TLS connection. -- components: Library (Lib) fil