Antoine Pitrou pit...@free.fr added the comment:
Łukasz, please close issues when they are fixed.
--
nosy: +pitrou
resolution: - fixed
stage: - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
SilentGhost ghost@gmail.com added the comment:
Committed for 2.7 in r87964, for 3.1 in r87965.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10874
___
New submission from Andreas Stührk andy-pyt...@hammerhartes.de:
See the attached patch (applies to 2.7 and 3.2).
--
components: Tests
files: test_urllib2.patch
keywords: patch
messages: 125846
nosy: Trundle, lukasz.langa
priority: normal
severity: normal
status: open
title: test_urllib2
SilentGhost ghost@gmail.com added the comment:
Shouldn't that be:
self.assertIs(req.type == ftp, ftp)
?
--
nosy: +SilentGhost
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10874
___
Changes by SilentGhost ghost@gmail.com:
Added file: http://bugs.python.org/file20326/test_urllib2.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10874
___
Éric Araujo mer...@netwok.org added the comment:
Actually, this block of tests may be outdated. Reading the comment above the
list of (URIs, is_ftp) doubles makes you see that it was testing the automatic
use of FTP in some file: URIs, a very dubious behavior that is now removed or
Łukasz Langa luk...@langa.pl added the comment:
Committed for py3k in r87895. Yup, could have been assertIs as well. The reason
for the change is that is failed on PyPy.
This should be backported to Python 2.7 as well.
--
___
Python tracker
