[issue10874] test_urllib2 shouldn't use is operator for comparing strings

2011-01-14 Thread Antoine Pitrou 

Antoine Pitrou pit...@free.fr added the comment:

Łukasz, please close issues when they are fixed.

--
nosy: +pitrou
resolution:  - fixed
stage:  - committed/rejected
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10874
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10874] test_urllib2 shouldn't use is operator for comparing strings

2011-01-12 Thread SilentGhost 

SilentGhost ghost@gmail.com added the comment:

Committed for 2.7 in r87964, for 3.1 in r87965.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10874
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10874] test_urllib2 shouldn't use is operator for comparing strings

2011-01-09 Thread Andreas Stührk 

New submission from Andreas Stührk andy-pyt...@hammerhartes.de:

See the attached patch (applies to 2.7 and 3.2).

--
components: Tests
files: test_urllib2.patch
keywords: patch
messages: 125846
nosy: Trundle, lukasz.langa
priority: normal
severity: normal
status: open
title: test_urllib2 shouldn't use is operator for comparing strings
versions: Python 2.7, Python 3.2
Added file: http://bugs.python.org/file20324/test_urllib2.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10874
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10874] test_urllib2 shouldn't use is operator for comparing strings

2011-01-09 Thread SilentGhost 

SilentGhost ghost@gmail.com added the comment:

Shouldn't that be:

self.assertIs(req.type == ftp, ftp)

?

--
nosy: +SilentGhost

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10874
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10874] test_urllib2 shouldn't use is operator for comparing strings

2011-01-09 Thread SilentGhost 

Changes by SilentGhost ghost@gmail.com:


Added file: http://bugs.python.org/file20326/test_urllib2.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10874
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10874] test_urllib2 shouldn't use is operator for comparing strings

2011-01-09 Thread Éric Araujo 

Éric Araujo mer...@netwok.org added the comment:

Actually, this block of tests may be outdated.  Reading the comment above the 
list of (URIs, is_ftp) doubles makes you see that it was testing the automatic 
use of FTP in some file: URIs, a very dubious behavior that is now removed or 
deprecated.  Senthil, I think a little cleanup is needed.

--
assignee:  - orsenthil
nosy: +eric.araujo, orsenthil
versions: +Python 3.1

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10874
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10874] test_urllib2 shouldn't use is operator for comparing strings

2011-01-09 Thread Łukasz Langa 

Łukasz Langa luk...@langa.pl added the comment:

Committed for py3k in r87895. Yup, could have been assertIs as well. The reason 
for the change is that is failed on PyPy.

This should be backported to Python 2.7 as well.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10874
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com