[issue10898] posixmodule.c redefines FSTAT

2020-11-15 Thread Irit Katriel 


Change by Irit Katriel :


--
versions: +Python 3.10, Python 3.8, Python 3.9 -Python 2.7, Python 3.2, Python 
3.3, Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10898] posixmodule.c redefines FSTAT

2013-07-07 Thread Christian Heimes 

Changes by Christian Heimes li...@cheimes.de:


--
nosy: +christian.heimes
versions: +Python 3.3, Python 3.4 -Python 3.1

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10898
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10898] posixmodule.c redefines FSTAT

2011-09-12 Thread Alan Hourihane 

Changes by Alan Hourihane al...@fairlite.co.uk:


--
resolution: accepted - remind

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10898
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10898] posixmodule.c redefines FSTAT

2011-07-03 Thread Alan Hourihane 

Alan Hourihane al...@fairlite.co.uk added the comment:

Well, I'd probably prefer something akin to my first patch then.

There's no need to #undef things at all if we just prefix the usage with PYTHON_

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10898
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10898] posixmodule.c redefines FSTAT

2011-07-02 Thread Antoine Pitrou 

Antoine Pitrou pit...@free.fr added the comment:

 I've had to split the three #undef's up to just before they're used.

I would really prefer to move up the offending #include rather than
sprinkle those #undef's all over the place.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10898
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10898] posixmodule.c redefines FSTAT

2011-07-01 Thread Alan Hourihane 

Alan Hourihane al...@fairlite.co.uk added the comment:

Hi Antoine,

Unfortunately the #undef is too early and later #includes redefine it.

We should move the #undef closer to the code that actually uses them.

--
resolution: fixed - accepted
status: closed - open

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10898
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10898] posixmodule.c redefines FSTAT

2011-07-01 Thread Roundup Robot 

Roundup Robot devnull@devnull added the comment:

New changeset 45b27448f95c by Antoine Pitrou in branch '2.7':
Really fix issue #10898: posixmodule.c redefines FSTAT
http://hg.python.org/cpython/rev/45b27448f95c

--
nosy: +python-dev

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10898
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10898] posixmodule.c redefines FSTAT

2011-07-01 Thread Antoine Pitrou 

Antoine Pitrou pit...@free.fr added the comment:

Ah, sorry. Can you check with the changeset I've just pushed (it's on branch 
2.7)?
If ok, I'll port it to 3.2/3.x and close again.

--
resolution: accepted - fixed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10898
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10898] posixmodule.c redefines FSTAT

2011-07-01 Thread Alan Hourihane 

Alan Hourihane al...@fairlite.co.uk added the comment:

No, that patch still doesn't work.

--
resolution: fixed - accepted

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10898
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10898] posixmodule.c redefines FSTAT

2011-07-01 Thread Antoine Pitrou 

Antoine Pitrou pit...@free.fr added the comment:

Hum, can you propose something?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10898
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10898] posixmodule.c redefines FSTAT

2011-07-01 Thread Alan Hourihane 

Alan Hourihane al...@fairlite.co.uk added the comment:

I've had to split the three #undef's up to just before they're used.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10898
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10898] posixmodule.c redefines FSTAT

2011-01-19 Thread Antoine Pitrou 

Antoine Pitrou pit...@free.fr added the comment:

Ok, fixed in r88111 (3.2), r88112 (3.1) and r88113 (2.7).

--
resolution:  - fixed
stage: needs patch - committed/rejected
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10898
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10898] posixmodule.c redefines FSTAT

2011-01-18 Thread Antoine Pitrou 

Antoine Pitrou pit...@free.fr added the comment:

How about adding #undef FSTAT instead? Would it work for you?

--
components: +Extension Modules
nosy: +pitrou
stage:  - needs patch
versions: +Python 2.7, Python 3.1, Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10898
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10898] posixmodule.c redefines FSTAT

2011-01-18 Thread Alan Hourihane 

Alan Hourihane al...@fairlite.co.uk added the comment:

On Tue, 2011-01-18 at 19:59 +, Antoine Pitrou wrote:
 Antoine Pitrou pit...@free.fr added the comment:
 
 How about adding #undef FSTAT instead? Would it work for you?

Sure.

Alan.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10898
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10898] posixmodule.c redefines FSTAT

2011-01-12 Thread Alan Hourihane 

New submission from Alan Hourihane al...@fairlite.co.uk:

Python 2.7.1 redefines FSTAT, but the problem is my libc already defines FSTAT 
in sys/ioctl.h.

I've worked around this by prefixing the FSTAT define with PYTHON. It should 
probably be done with STAT too.

--- Modules/posixmodule.c.old   2011-01-12 01:46:45.0 +
+++ Modules/posixmodule.c   2011-01-12 01:47:05.0 +
@@ -344,11 +344,11 @@
 #undef STAT
 #if defined(MS_WIN64) || defined(MS_WINDOWS)
 #   define STAT win32_stat
-#   define FSTAT win32_fstat
+#   define PYTHON_FSTAT win32_fstat
 #   define STRUCT_STAT struct win32_stat
 #else
 #   define STAT stat
-#   define FSTAT fstat
+#   define PYTHON_FSTAT fstat
 #   define STRUCT_STAT struct stat
 #endif
 
@@ -6641,7 +6641,7 @@
 if (!_PyVerify_fd(fd))
 return posix_error();
 Py_BEGIN_ALLOW_THREADS
-res = FSTAT(fd, st);
+res = PYTHON_FSTAT(fd, st);
 Py_END_ALLOW_THREADS
 if (res != 0) {
 #ifdef MS_WINDOWS

--
messages: 126120
nosy: alanh
priority: normal
severity: normal
status: open
title: posixmodule.c redefines FSTAT
type: compile error

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10898
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com