[issue10980] http.server Header Unicode Bug

2012-09-25 Thread Antoine Pitrou

Changes by Antoine Pitrou pit...@free.fr:


--
resolution: accepted - fixed
stage: commit review - committed/rejected
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10980
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10980] http.server Header Unicode Bug

2011-11-18 Thread Ezio Melotti

Ezio Melotti ezio.melo...@gmail.com added the comment:

Now it's too late for 3.1, should this still go to 2.7?

--
nosy: +ezio.melotti
versions:  -Python 3.1

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10980
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10980] http.server Header Unicode Bug

2011-11-18 Thread Benjamin Peterson

Benjamin Peterson benja...@python.org added the comment:

Please.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10980
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10980] http.server Header Unicode Bug

2011-11-18 Thread Armin Ronacher

Armin Ronacher armin.ronac...@active-4.com added the comment:

2.7 does not suffer from this since 2.7 does not support unicode in headers.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10980
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10980] http.server Header Unicode Bug

2011-01-22 Thread Armin Ronacher

New submission from Armin Ronacher armin.ronac...@active-4.com:

I have a critical bugfix that should make it into Python 3.2 even when it's in 
release candidate state.  Currently http.server.BaseHTTPServer encodes headers 
with ASCII charset.  This is at least in violation with PEP  which demands 
that latin1 is used.

Because HTTP itself suggests latin1 (iso-8859-1) I strongly recommend changing 
this in BaseHTTPServer and not wsgiref.

The attached patch fixes that in a backwards compatible fashion.

--
assignee: georg.brandl
components: Library (Lib)
files: http-server-unicode.patch
keywords: patch
messages: 126832
nosy: aronacher, georg.brandl
priority: normal
severity: normal
stage: patch review
status: open
title: http.server Header Unicode Bug
type: behavior
Added file: http://bugs.python.org/file20486/http-server-unicode.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10980
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10980] http.server Header Unicode Bug

2011-01-22 Thread STINNER Victor

STINNER Victor victor.stin...@haypocalc.com added the comment:

Extract of PEP :  Note also that strings passed to start_response() as a 
status or as response headers must follow RFC 2616 with respect to encoding. 
That is, they must either be ISO-8859-1 characters, or use RFC 2047 MIME 
encoding. 

What is the best choice for portability (HTTP servers and web browsers): latin1 
or MIME encoding? Latin1 is a small subset of Unicode: only U+..U+00FF.

We should maybe give the choice to the user between Latin1, MIME, or maybe 
something else (eg. UTF-8, cp1252, ...). Or at least, you should try something 
like:

try:
   bytes = text.encode('latin1')
except UnicodeEncodeError:
   bytes = encodeMIME(text, 'utf-8')

Would it be a good idea to accept raw bytes headers? HTTP is *supposed* to be 
correctly encoded using different RFC, but in practical, anyone is free to do 
whateven he wants.

Sentence extracted randomly from the WWW (dec. 2008): it seems that neither 
Tomcat 5.5 or 6 properly decodes HTTP headers as per RFC 2047! The Tomcat code 
assumes everywhere that header values use ISO-8859-1.

Finally, why do you consider that this issue have to be fixed before Python 3.2?

--
nosy: +haypo

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10980
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10980] http.server Header Unicode Bug

2011-01-22 Thread STINNER Victor

STINNER Victor victor.stin...@haypocalc.com added the comment:

RFC 5987 (Character Set and Language Encoding for Hypertext Transfer Protocol 
(HTTP) Header Field Parameters), August 2010:
http://greenbytes.de/tech/webdav/rfc5987.html#language.specification.in.encoded.words

 3.3 Language Specification in Encoded Words

Section 5 of [RFC2231] extends the encoding defined in [RFC2047] to also 
support language specification in encoded words. Although the HTTP/1.1 
specification does refer to RFC 2047 ([RFC2616], Section 2.2), it's not clear 
to which header field exactly it applies, and whether it is implemented in 
practice (see http://tools.ietf.org/wg/httpbis/trac/ticket/111 for details).

Thus, this specification does not include this feature. 

Hum ok, Latin1 looks safe and enough.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10980
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10980] http.server Header Unicode Bug

2011-01-22 Thread Armin Ronacher

Armin Ronacher armin.ronac...@active-4.com added the comment:

Georg Brandl signed off the commit and Python 3.2 will ship with the HTTP 
server accepting latin1 bytes.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10980
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10980] http.server Header Unicode Bug

2011-01-22 Thread Georg Brandl

Georg Brandl ge...@python.org added the comment:

Armin committed the patch in r88142 and followed up with r88143 for the 
http.client library.

Needs backporting?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10980
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10980] http.server Header Unicode Bug

2011-01-22 Thread Éric Araujo

Éric Araujo mer...@netwok.org added the comment:

I think so.

--
nosy: +benjamin.peterson, eric.araujo, orsenthil
resolution:  - accepted
stage: patch review - commit review
versions: +Python 2.7, Python 3.1, Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10980
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com