[issue11072] Add MLSD command support to ftplib

Roundup Robot added the comment: New changeset ecef6b3f6639 by Gregory P. Smith in branch '3.5': Issue #11072: change the incorrect "deprecation" of ftplib dir() and nlst() https://hg.python.org/cpython/rev/ecef6b3f6639 New changeset 287bb82768a7 by Gregory P. Smith in branch 'default': Issue #1

[issue11072] Add MLSD command support to ftplib

Roundup Robot added the comment: New changeset 153bd8fc22c7 by Giampaolo Rodola' in branch 'default': #11072- applying http://bugs.python.org/review/11072/show suggestions http://hg.python.org/cpython/rev/153bd8fc22c7 -- ___ Python tracker

[issue11072] Add MLSD command support to ftplib

Giampaolo Rodola' added the comment: In my view, aside from the documentation note they're all minor/styling-related changes but feel free to provide a patch if you want to and I'll commit it. -- ___ Python tracker

[issue11072] Add MLSD command support to ftplib

SilentGhost added the comment: a review on rietveld http://bugs.python.org/review/11072/show which as I confirmed with you specifically at #python-dev you received a notification of. -- ___ Python tracker ___

[issue11072] Add MLSD command support to ftplib

Giampaolo Rodola' added the comment: Which ones in particular? msg130474? -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue11072] Add MLSD command support to ftplib

SilentGhost added the comment: Has something prevent you from implementing suggestion provided in my review? -- ___ Python tracker ___ __

[issue11072] Add MLSD command support to ftplib

Changes by Giampaolo Rodola' : -- assignee: -> giampaolo.rodola components: +Library (Lib) resolution: -> fixed stage: -> committed/rejected status: open -> closed type: -> feature request ___ Python tracker __

[issue11072] Add MLSD command support to ftplib

Roundup Robot added the comment: New changeset 56bce38b274f by Giampaolo Rodola' in branch 'default': Issue #11072: added MLSD command (RFC-3659) support to ftplib. http://hg.python.org/cpython/rev/56bce38b274f -- nosy: +python-dev ___ Python tracker

[issue11072] Add MLSD command support to ftplib

Eric V. Smith added the comment: Yes, I think this should be committed. I think the API is reasonable, which is the primary concern. If there are implementation bugs, they can be addressed as they're found. -- ___ Python tracker

[issue11072] Add MLSD command support to ftplib

Giampaolo Rodola' added the comment: Eric, any further comments about the patch? Can we go on and commit it? -- ___ Python tracker ___ __

[issue11072] Add MLSD command support to ftplib

Eric Smith added the comment: So it is. I told you I hadn't done a proper review! I was mainly trying to say I agree with lowercasing. I'll shut up until I can read the whole patch. -- ___ Python tracker ___

[issue11072] Add MLSD command support to ftplib

Giampaolo Rodola' added the comment: > You should have the facts in MLSD_DATA be mixed case, to ensure > they're being lowercased correctly. This is already tested by: +# case sensitiveness +set_data('Type=type;TyPe=perm;UNIQUE=unique; name\r\n') +_name, facts = next(s

[issue11072] Add MLSD command support to ftplib

Eric Smith added the comment: I'll give this a proper review in the next day or so (busy at PyCon). Despite the fact that I typically hate changing values returned by the server, I agree on case-folding the fact names to lowercase upon reading them. The RFC clearly states they're case insensi

[issue11072] Add MLSD command support to ftplib

Giampaolo Rodola' added the comment: You're right about r/strip(), thanks (new patch in attachment). > In your test you're checking whether returned facts > contain every requested fact, this is not guaranteed by RFC. Yes, but we're using a dummy FTP server returning static MLSD_DATA, so this

[issue11072] Add MLSD command support to ftplib

SilentGhost added the comment: facts_found.strip(" ").rstrip(";") strip is redundant since facts_found is a first element of partitioning by the same string. rstrip is wrong since you're potentially deleting more than one character (there is no test for that). In your test you're checking wh

[issue11072] Add MLSD command support to ftplib

Giampaolo Rodola' added the comment: Thanks for the great review Eric. Patch in attachment provides the following changes: - return a generator object - remove callback parameter - each yielded entry is a (name, {...}) tuple - fix for ";" in file name - fix for " " in file name - fix for "=" in

[issue11072] Add MLSD command support to ftplib

SilentGhost added the comment: Here is a patch incorporating some of the changes proposed by Eric: * drop callback, return generator of (filename, fact-dict) > Aren't you modifying the state on the server (via "OPTS MLST"), and then if > you make a subsequent call without specifying "facts" y

[issue11072] Add MLSD command support to ftplib

Changes by SilentGhost : -- nosy: +SilentGhost ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue11072] Add MLSD command support to ftplib

Eric Smith added the comment: I agree that the callback isn't needed, and it reflects the older coding style of much of the library (such as in retrlines). Instead, I'd make this a generator, yielding each of the dicts. (Actually in some ideal rewrite of ftplib, the whole callback "feature" u

[issue11072] Add MLSD command support to ftplib

Changes by George Dhoore : -- nosy: +George.Dhoore ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.

[issue11072] Add MLSD command support to ftplib

Antoine Pitrou added the comment: Why the callback option? Also, the tests don't appear to check the return value. -- ___ Python tracker ___

[issue11072] Add MLSD command support to ftplib

Changes by Eric Smith : -- nosy: +eric.smith ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue11072] Add MLSD command support to ftplib

New submission from Giampaolo Rodola' : >From RFC-3659: The MLST and MLSD commands are intended to standardize the file and directory information returned by the server-FTP process. These commands differ from the LIST command in that the format of the replies is strictly defined alt