[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass

Irit Katriel added the comment: I've created Issue45935 for the missing test and will close this as resolved in version 3.3. -- nosy: +iritkatriel status: open -> closed ___ Python tracker _

[issue45935] Add test for Issue11109: socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass.

, orsenthil, python-dev, vstinner priority: normal severity: normal status: open title: Add test for Issue11109: socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass. type: enhancement versions: Python 3.11 ___ Python tracker

[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass

Roundup Robot added the comment: New changeset 991c24b8969d by R David Murray in branch '3.3': #11109: clean up docs, add whatsnew entry, and fix Justin's last name. http://hg.python.org/cpython/rev/991c24b8969d New changeset 1234300bc056 by R David Murray in branch 'default': Merge #11109: clea

[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass

Justin Warkentin added the comment: Sorry, I haven't had a chance to look at this in a couple days. I've been very busy with work. I'm not sure exactly how to write the test for this, so I don't know that I'd be much help there. One last thing, I was just looking through the commits and I not

[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass

Senthil Kumaran added the comment: Victor - Sure, I understand Issue #xxx: desc must be useful while generation reST docs. -- ___ Python tracker ___ ___

[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass

STINNER Victor added the comment: > New changeset 3e3cd0ed82bb by Senthil Kumaran in branch 'default': > News entry for issue11109. > http://hg.python.org/cpython/rev/3e3cd0ed82bb Please try to format NEWS entries using "Issue #xxx: xxx" instead of "Issue #xxx - xxx". -- nosy: +haypo

[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass

Senthil Kumaran added the comment: This is fixed in 3.3 now. Keeping it open for test_socketserver update. After a ForkingServer service call, it should be asserted the collect_children routine is run. -- resolution: -> fixed stage: patch review -> committed/rejected versions: -Pyth

[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass

Senthil Kumaran added the comment: The feature is in 3.3. I did not remove the handle_timeout method from the Mixin class, because it might be used in the production by the existing servers. It is not appropriate to remove methods all of sudden without deprecation warnings and also it is not

[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass

Roundup Robot added the comment: New changeset e2363b1c4bca by Senthil Kumaran in branch 'default': Fix closes issue #11109 - socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass. http://hg.python.org/cpython/rev/e2363b1c4bca New changeset 3e3cd0ed82bb by Senth

[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass

Senthil Kumaran added the comment: Justin, The patch and logic is okay. We can have this is 3.3. - I find that loop_actions as not appropriate name for the new method. It fails to give a intuitive meaning of what is supposed to do. request_action, request_action_continued or anything else wh

[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass

Justin added the comment: Don't mean to nag. Just checking to see if anyone has taken it upon themselves to commit this yet since it's been a couple more months :P -- ___ Python tracker __

[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass

Gregory P. Smith added the comment: not yet, thanks for the reminder. if any other committers feel like jumping on this and doing it before I get around to it, feel free. -- ___ Python tracker __

[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass

Justin added the comment: Just following up on this. Now that 3.2 is out, has the patch been committed? -- ___ Python tracker ___ ___

[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass

Justin added the comment: Sorry I keep plaguing this with comments and files, but I got to thinking, anyone should be able to override _loop_actions() and implement what they need in the loop. While it's probably a bad idea in most cases, there may be legitimate needs and it's always good to

[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass

Justin added the comment: I hope I did that last patch right. I did a 'diff -u' instead of a 'diff -c'. If you need something different, let me know. -- ___ Python tracker ___

[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass

Changes by Justin : Added file: http://bugs.python.org/file20693/loop_actions.patch ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass

Changes by Justin : Removed file: http://bugs.python.org/file20691/loop_actions.patch ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass

Changes by Justin : Removed file: http://bugs.python.org/file20690/loop_actions.patch ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass

Justin added the comment: I noticed that ForkingMixIn also was overriding handle_timeout() trying to cleanup zombies after 300 seconds of inactivity, which is useless on a busy server. I'm replacing the patch with one that also removes handle_timeout(). -- Added file: http://bugs.pyth

[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass

Changes by Gregory P. Smith : -- assignee: -> gregory.p.smith ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass

Gregory P. Smith added the comment: I believe that is good. I'll commit it after the 3.2 release has been cut (we're in release candidate release blocker only lockdown right now). Looking at ForkingMixIn.collect_children() there appears to be another buglet: it loops over self.active_childre

[issue11109] socketserver.ForkingMixIn leaves zombies

Justin added the comment: Good point. I was just writing up something quick that works. Here's another patch, is this acceptable? -- Added file: http://bugs.python.org/file20690/loop_actions.patch ___ Python tracker

[issue11109] socketserver.ForkingMixIn leaves zombies

Gregory P. Smith added the comment: Rather than depending on the internal details of ForkingMixIn in your BaseServer.serve_forever modification I'd prefer to see that simply call self._cleanup() Define a do-nothing _periodic_cleanup method in BaseServer. ForkingMixIn should implement its ow

[issue11109] socketserver.ForkingMixIn leaves zombies

Changes by Giampaolo Rodola' : -- nosy: +giampaolo.rodola ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:

[issue11109] socketserver.ForkingMixIn leaves zombies

Changes by Antoine Pitrou : -- nosy: +gregory.p.smith stage: -> patch review versions: +Python 2.7, Python 3.2, Python 3.3 -Python 3.1 ___ Python tracker ___ ___

[issue11109] socketserver.ForkingMixIn leaves zombies

Justin added the comment: I guess I didn't really explain the issue much. The problem is that if the server receives say, 10 requests at once, and then forks a process for each, after those processes finish they will sit as zombies until process_request() is called again, which calls collect_

[issue11109] socketserver.ForkingMixIn leaves zombies

New submission from Justin : This is the same issue as was reported here: http://bugs.python.org/issue1954. It is still a problem in Python 3.1. I'm writing a server that will be receiving a massive number of requests and I'd like to eliminate the zombie problem. Once I figured out what was go