Roundup Robot added the comment:
New changeset 958217164846 by Eli Bendersky in branch '3.2':
Issue #11367: fix documentation of some find* methods in ElementTree
http://hg.python.org/cpython/rev/958217164846
New changeset 4012d4b41b2b by Eli Bendersky in branch '3.3':
Issue #11367: fix
Roundup Robot added the comment:
New changeset 8e6db2462a77 by Eli Bendersky in branch '2.7':
Issue #11367: fix documentation of some find* methods in ElementTree
http://hg.python.org/cpython/rev/8e6db2462a77
--
___
Python tracker
Eli Bendersky added the comment:
Thanks for the patches - committed with slight adaptations (in default branch
the internal documentation switched from comments to docstrings).
--
resolution: - fixed
stage: needs patch - committed/rejected
status: open - closed
Henrik Heimbuerger added the comment:
Eli, I fully understand. I was experimenting with working on Cloud9, but it
unfortunately has no easy way to extract individual files, I had to recreate
them locally. I hope it is correct now.
--
Added file:
Henrik Heimbuerger added the comment:
for 3.2
--
Added file: http://bugs.python.org/file29375/issue11367_branch32.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11367
___
Eli Bendersky added the comment:
Henrik, this patch fails to apply to 3.2
applying issue11367_branch32.patch
patching file Doc/library/xml.etree.elementtree.rst
Hunk #1 FAILED at 411
1 out of 1 hunks FAILED -- saving rejects to file
Doc/library/xml.etree.elementtree.rst.rej
patching file
anatoly techtonik added the comment:
You can use patch.py utility from
http://python-patch.googlecode.com/svn-history/trunk/patch.py to apply patch
that doesn't have this CRLF problem.
--
___
Python tracker rep...@bugs.python.org
Eli Bendersky added the comment:
No, according to the devguide patches for Python have to be created with 'hg
diff' and applicable with 'hg patch'. I can fix the patch in a number of ways,
but I think it's important for a new contributor to learn how to generate a
correct patch that can be
Henrik Heimbuerger added the comment:
Brought the ElementTree docs for find(), findtext() and findall() in line with
the default branch (now they are just referencing the methods from Element).
Made the same changes in the method comments of the implementation.
Separate patches for 2.7 and
Henrik Heimbuerger added the comment:
Patch for 3.2.
--
Added file: http://bugs.python.org/file29350/issue11367_branch32.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11367
___
Henrik Heimbuerger added the comment:
That sounds good, Eli! I'll check the implementations and then adapt the other
ElementTree methods as well. Will take until next week, though.
--
___
Python tracker rep...@bugs.python.org
Henrik Heimbuerger added the comment:
Eli, I tried to preserve the style (and detail) of the rest of the docs of the
respective version. If I bring the 3.3 version of find() into 2.7, then it will
have a lot less detail than f.e. findall() as a sibling method on the same
class:
Eli Bendersky added the comment:
Henrik. Yes, I think the change in 3.3 was intentional in order to avoid
duplication that can be a source of errors. If ET.find() does exactly what
ET.getroot().find() does, it suffices to mention it with a link. Since Element
docs come first and arguably
anatoly techtonik added the comment:
Thanks for working on this. It is always nice to see things moving.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11367
___
Eli Bendersky added the comment:
Henrik, there's no need to provide more information in 3.2 and 2.7 than in 3.3
and default. Could you just align your patches with those (i.e. same wording in
the documentation)?
--
___
Python tracker
Henrik Heimbuerger added the comment:
Attached patch file for the 2.7 branch. They not only touch find(), but also
findtext(), which has the mistake in the documentation. Also does some related
changes in the module's code comments.
--
keywords: +patch
nosy: +hheimbuerger
Added file:
Henrik Heimbuerger added the comment:
Almost identical patch for 3.2, just differs in line numbers.
--
Added file: http://bugs.python.org/file29185/issue11367_branch32.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11367
Eli Bendersky added the comment:
Patches to documentation of 3.2 and 2.7 are welcome
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11367
___
Serhiy Storchaka added the comment:
Already fixed in 3.3+.
--
keywords: +easy
nosy: +eli.bendersky, serhiy.storchaka
stage: - needs patch
type: - enhancement
versions: +Python 2.7, Python 3.2 -Python 2.6
___
Python tracker rep...@bugs.python.org
New submission from anatoly techtonik techto...@gmail.com:
ElementTree.find(path) docs say:
Finds the first toplevel element with given tag. Same as getroot().find(path).
path is the element to look for.
That's not true. path can take the form of //tag to find any child element
with given
20 matches
Mail list logo
