Roundup Robot devnull@devnull added the comment:
New changeset 7a693e283c68 by Senthil Kumaran in branch '2.7':
Issue #11467: Fix urlparse behavior when handling urls which contains scheme
http://hg.python.org/cpython/rev/7a693e283c68
--
nosy: +python-dev
Roundup Robot devnull@devnull added the comment:
New changeset 495d12196487 by Senthil Kumaran in branch '3.1':
Issue #11467: Fix urlparse behavior when handling urls which contains scheme
specific part only digits.
http://hg.python.org/cpython/rev/495d12196487
--
Senthil Kumaran sent...@uthcode.com added the comment:
Fixed this in all codelines. Thanks Santoso.
--
resolution: - fixed
stage: - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11467
Changes by Santoso Wijaya santoso.wij...@gmail.com:
--
versions: +Python 3.1
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11467
___
___
Santoso Wijaya santoso.wij...@gmail.com added the comment:
I'm attaching a patch with a fix and a unittest using the email example. I put
this in a new test_RFC2368 (the mailto URL scheme) method. Seems like there is
no unittest for parsing mailto scheme to begin with.
--
Added file:
Changes by Santoso Wijaya santoso.wij...@gmail.com:
Removed file: http://bugs.python.org/file21110/urlparse.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11467
___
Santoso Wijaya santoso.wij...@gmail.com added the comment:
Oops, wrong revision base.
--
Added file: http://bugs.python.org/file2/urlparse.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11467
Senthil Kumaran orsent...@gmail.com added the comment:
Santoso, Quick review comments:
1. The patch looks good.
2. I would use a temporary 'throw-away' variable instead of _, but don't bother
to change it, before committing I shall take care.
3. Important - Did you find any regression with the
Santoso Wijaya santoso.wij...@gmail.com added the comment:
Senthil,
Thanks for the review! I was initially thinking of `port = ...` but opted for
_, arbitrarily, instead.
regrtest on Darwin-10.6.0-i386-64bit ran fine.
--
___
Python tracker
Changes by Santoso Wijaya santoso.wij...@gmail.com:
--
nosy: +santa4nt
versions: +Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11467
___
New submission from Bastian Kleineidam cal...@users.sourceforge.net:
When using a javascript URL with only digits as paths, the urlsplit() functions
behaves different in Python 2.7 than in 2.6:
$ python2.6 -c import urlparse; print urlparse.urlsplit('javascript:123')
Changes by Bastian Kleineidam cal...@users.sourceforge.net:
--
versions: +Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11467
___
___
Bastian Kleineidam cal...@users.sourceforge.net added the comment:
The behaviour change is caused by the fix for issue #754016.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11467
___
Changes by R. David Murray rdmur...@bitdance.com:
--
nosy: +orsenthil, r.david.murray
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11467
___
___
Senthil Kumaran orsent...@gmail.com added the comment:
What kind of url is 'javascript:123' and how do you (/ we) say that python2.6
behavior was correct?
--
assignee: - orsenthil
keywords: +patch
___
Python tracker rep...@bugs.python.org
Bastian Kleineidam cal...@users.sourceforge.net added the comment:
Regarding the correctness of the Python 2.6 implementation:
http://www.faqs.org/rfcs/rfc1738.html specifies URLs of the form
scheme:scheme-specific-part where the scheme specific part is allowed to
consist only of digits.
I
Bastian Kleineidam cal...@users.sourceforge.net added the comment:
To make the previous comment more precise: URLs where
the scheme specific part begins with a digit are affected.
--
___
Python tracker rep...@bugs.python.org
17 matches
Mail list logo
