Martin Panter added the comment:
I think the fix for this bug only works if it gets the server to respond with a
“Connection: close” header itself. I opened Issue 19524 because I was seeing
keep-alive responses using chunked encoding that still trigger a socket leak.
--
nosy: +vadmium
'default':
Closes issue11563 test_urllibnet is triggering a ResourceWarning. Patch by Jeff
McNeil.
http://hg.python.org/cpython/rev/dfceb98767c0
--
nosy: +python-dev
resolution: - fixed
stage: needs patch - committed/rejected
status: open - closed
___
Python
STINNER Victor victor.stin...@haypocalc.com added the comment:
@Senthil Kumaran: Because your patch touchs not only the test, can you document
your change in Misc/NEWS? Sending a new HTTP header should be documented.
Is there an issue to support persistent connections in
Nadeem Vawda nadeem.va...@gmail.com added the comment:
urlopen_HttpTests.test_willclose() fails to call unfakehttp(), which breaks
subsequent runs of test_urllib2_localnet, test_urllib2net and test_urllibnet.
Fix attached.
--
Added file:
Senthil Kumaran orsent...@gmail.com added the comment:
Victor - Issue9740 and Issue3566 talks about the need to have persistent
connection. 3.3 would be a good target to have this feature in.
Shall add the NEWS entry.
Nadeen Wadwa - Thanks for your patch. I committed the fix as part of another
Changes by Senthil Kumaran orsent...@gmail.com:
--
Removed message: http://bugs.python.org/msg131456
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11563
___
Senthil Kumaran orsent...@gmail.com added the comment:
Victor - Issue9740 and Issue3566 talks about the need to have persistent
connection. 3.3 would be a good target to have this feature in.
Shall add the NEWS entry.
Nadeem Vawda - Thanks for your patch. I committed the fix as part of another
Roundup Robot devnull@devnull added the comment:
New changeset 53c8f2bd0316 by Senthil Kumaran in branch '3.2':
Add NEWS for Issue #11563.
http://hg.python.org/cpython/rev/53c8f2bd0316
--
___
Python tracker rep...@bugs.python.org
Nadeem Vawda nadeem.va...@gmail.com added the comment:
issue10883 is related; test_urllib2net also leaves sockets open in several
places.
--
nosy: +haypo, nvawda
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11563
Jeff McNeil j...@jmcneil.net added the comment:
So, it turned out to be more complicated than that. The HTTPConnection object
returns an HTTPResponse, but never closes the underlying socket after calling
makesock.
Since persistent connections aren't supported, nothing actually closes the
Senthil Kumaran orsent...@gmail.com added the comment:
On Thu, Mar 17, 2011 at 06:30:51PM +, Jeff McNeil wrote:
I went down the same path as AbstractHTTPHandler and added a Connection:
close header.
This is fine for the moment, tough I wish that the TODO pending in
urllib.request with
Jeff McNeil j...@jmcneil.net added the comment:
Sounds good. I'll look at doing that, too.
--
versions: +Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11563
___
Changes by Jeff McNeil j...@jmcneil.net:
--
nosy: +mcjeff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11563
___
___
Python-bugs-list mailing
Jeff McNeil j...@jmcneil.net added the comment:
So, I've been meaning to get more into contributing back to Python and I found
this one somewhat interesting.
As it turns out, even the following simple script raises the same warning:
[jeff@martian cpython]$ ./python -c 'import urllib.request;
Senthil Kumaran orsent...@gmail.com added the comment:
Yes, go ahead with the patch.
--
nosy: +orsenthil
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11563
___
New submission from Brett Cannon br...@python.org:
test.test_urllibnet.urlopenNetworkTests.test_getcode() is leaving a socket
open. My guess is that the error condition being triggered is somehow leaving
the socket open but I can't find where.
--
components: Library (Lib)
messages:
16 matches
Mail list logo
