[issue11595] Miscellaneous bugs in cfg_to_args() utility function

[Éric Araujo]

Éric Araujo  added the comment:

> The reason being that I'm using this in my own packages so that I can
> distutils2-like setup.cfgs, but still install with normal distutils
> and/or Distribute without depending on distutils2 in its entirety.
>
> I'm wondering if there might be a better way to proceed, or if this
> sort of compatibility support is even useful to anyone else.

I think that now I understand what you meant here.  You should not have to 
duplicate distutils2 code in legacy setup.py scripts: “pysetup generate-setup” 
will create a setup script that can find information in the setup.cfg file (so 
that you only have to update one file), without depending on distutils2 code 
(it uses inspect.getsource to copy the cfg_to_args function into setup.py).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11595] Miscellaneous bugs in cfg_to_args() utility function

[Éric Araujo]

Éric Araujo  added the comment:

Thanks again!

--
resolution:  -> fixed
stage: patch review -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11595] Miscellaneous bugs in cfg_to_args() utility function

[Roundup Robot]

Roundup Robot  added the comment:

New changeset 303e3693d634 by Éric Araujo in branch 'default':
Move useful function to packaging.util.
http://hg.python.org/cpython/rev/303e3693d634

New changeset 06670bd0e59e by Éric Araujo in branch 'default':
Fix assorted bugs in packaging.util.cfg_to_args (#11595).
http://hg.python.org/cpython/rev/06670bd0e59e

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11595] Miscellaneous bugs in cfg_to_args() utility function

[Erik Bray]

Erik Bray  added the comment:

Thanks Eric for your review.  Obviously the last patch was rushed, and I didn't 
even run the tests.  It also got my changes for issue12240 mixed into it.  So 
I've gone ahead and attached an updated patch which incorporates your review 
comments.

--
Added file: http://bugs.python.org/file22298/issue11595-3.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11595] Miscellaneous bugs in cfg_to_args() utility function

[Erik Bray]

Erik Bray  added the comment:

Done.  Also added support for multi-valued description-file values.

--
Added file: http://bugs.python.org/file22276/issue11595-2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11595] Miscellaneous bugs in cfg_to_args() utility function

[Éric Araujo]

Éric Araujo  added the comment:

Can you refresh your patch for packaging?

--
assignee: tarek -> eric.araujo
stage:  -> patch review
type:  -> behavior
versions: +Python 3.3 -3rd party

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11595] Miscellaneous bugs in cfg_to_args() utility function

[Éric Araujo]

Éric Araujo  added the comment:

Another bug: the extracted author_email value is wrong.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11595] Miscellaneous bugs in cfg_to_args() utility function

[Éric Araujo]

Éric Araujo  added the comment:

I don’t really follow what you’re saying, sorry.  Anyway, it looks like a 
feature request separate from this bug, let’s keep things distinct :)

You can write to the ML, add a todo entry or another bug about your other thing.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11595] Miscellaneous bugs in cfg_to_args() utility function

[Erik Bray]

Erik Bray  added the comment:

I've got an additional patch to this function that also adds support for the 
package_data option, for extension modules (at least as they are currently 
specified in setup.cfg), and adds support for running setup_hook.

The only problem is that it's starting to copy more and more from 
distutils2.config.Config.  The difference being that it's still simpler, and 
doesn't depend on much else from distutils2.  The reason being that I'm using 
this in my own packages so that I can distutils2-like setup.cfgs, but still 
install with normal distutils and/or Distribute without depending on distutils2 
in its entirety.

I'm wondering if there might be a better way to proceed, or if this sort of 
compatibility support is even useful to anyone else.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11595] Miscellaneous bugs in cfg_to_args() utility function

[Éric Araujo]

Éric Araujo  added the comment:

Looks good to me (note: didn’t test).

--
versions: +3rd party

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11595] Miscellaneous bugs in cfg_to_args() utility function

[Erik Bray]

New submission from Erik Bray :

Attached is a patch that fixes a few miscellaneous bugs in cfg_to_args() that 
were holding me up. Namely:
 * A bad variable name (file -> path)
 * A few more fields needed to be in MULTI_FIELDS
 * Added support for packages_root -> package_dir conversion

This also adds a unit test for cfg_to_args().

--
assignee: tarek
components: Distutils2
files: cfg_to_args.patch
keywords: patch
messages: 131336
nosy: Erik.Bray, alexis, eric.araujo, tarek
priority: normal
severity: normal
status: open
title: Miscellaneous bugs in cfg_to_args() utility function
Added file: http://bugs.python.org/file21278/cfg_to_args.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com