[issue11640] Shelve references globals in its __del__ method

[Berker Peksag]

Berker Peksag added the comment:

Since PEP 442 has been implemented in 3.4 and e826940911c8 made Shelve.close() 
more robust, I think this is no longer an issue.

--
nosy: +berker.peksag
resolution:  -> out of date
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11640] Shelve references globals in its __del__ method

[Serhiy Storchaka]

Changes by Serhiy Storchaka storch...@gmail.com:


--
versions: +Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11640
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11640] Shelve references globals in its __del__ method

[Daniel Stutzbach]

Daniel Stutzbach stutzb...@google.com added the comment:

Could you add a comment above the lines defining self._BytesIO, describing why 
they're being set?  Someone else might see them as unnecessary and rip them out 
if there's no explanation.

Can a test launch Python in a subprocess, set up the appropriate data 
structure, let the subprocess Python shutdown, then check the subprocess's 
stderr for the error?

It's a little convoluted, but perhaps it could be built into a general utility 
function that could be used to test __del__ methods in other modules, too.

Not sure that it's worth the effort though.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11640
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11640] Shelve references globals in its __del__ method

[Petri Lehtinen]

Petri Lehtinen pe...@digip.org added the comment:

The patch looks good to me. Is there any way this could be tested in the test 
suite? How to simulate interpreter shutdown?

--
keywords: +needs review -patch
nosy: +petri.lehtinen
stage:  - patch review

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11640
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11640] Shelve references globals in its __del__ method

[Daniel Urban]

Changes by Daniel Urban urban.dani...@gmail.com:


--
nosy: +durban

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11640
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11640] Shelve references globals in its __del__ method

[Peter Davies]

New submission from Peter Davies ultra...@gmail.com:

Shelf.__setitem__ (which is called from __del__ when writeback is enabled) 
references globals. This was causing exceptions on interpreter  shutdown (due 
to another exception) for me.

I have attached a patch which stores the relevant globals in the Shelf object.

--
components: Library (Lib)
files: shelve_del_fix.diff
keywords: patch
messages: 131793
nosy: Peter.Davies
priority: normal
severity: normal
status: open
title: Shelve references globals in its __del__ method
type: behavior
versions: Python 2.7, Python 3.2
Added file: http://bugs.python.org/file21345/shelve_del_fix.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11640
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11640] Shelve references globals in its __del__ method

[Daniel Stutzbach]

Changes by Daniel Stutzbach stutzb...@google.com:


--
nosy: +stutzbach
versions: +Python 3.3

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11640
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com