Nick Coghlan ncogh...@gmail.com added the comment:
Just noting that the pep380 integration branch is also available in the
hg.python.org clone of my sandbox repo.
--
hgrepos: +107
___
Python tracker rep...@bugs.python.org
Nick Coghlan ncogh...@gmail.com added the comment:
Committed for 3.3: http://hg.python.org/cpython/rev/d64ac9ab4cd0
Thanks to Greg for the initial effort on the PEP and reference implementation
and to all involved in updating the original patch for 3.3 and getting the
tests and documentation
Éric Araujo mer...@netwok.org added the comment:
Kudos!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11682
___
___
Python-bugs-list mailing
Changes by Nick Coghlan ncogh...@gmail.com:
Added file: http://bugs.python.org/file24213/494c976c41c4.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11682
___
Changes by Nick Coghlan ncogh...@gmail.com:
Removed file: http://bugs.python.org/file23774/0d1d76f68750.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11682
___
Changes by Nick Coghlan ncogh...@gmail.com:
Removed file: http://bugs.python.org/file24213/494c976c41c4.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11682
___
Changes by Nick Coghlan ncogh...@gmail.com:
Added file: http://bugs.python.org/file24214/f8349cbc1b26.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11682
___
Nick Coghlan ncogh...@gmail.com added the comment:
Nice milestone this evening: by incorporating doc updates based on Zbysek's
efforts and dropping the explicit bytecode generation tests, I now have
something that appears ready to commit *without* a dependency on the proposed
dis module
Changes by Zbyszek Szmek zbys...@in.waw.pl:
--
hgrepos: -66
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11682
___
___
Python-bugs-list mailing
Zbyszek Szmek zbys...@in.waw.pl added the comment:
Some minor comments in http://bugs.python.org/review/11682/show.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11682
___
Zbyszek Szmek zbys...@in.waw.pl added the comment:
f((yield))
This requirement seems unnecessary. And surprising, because
f(generator-expression) or f('a' if 'a' else 'b') doesn't require parenthes.
There's no room for confusion if parentheses were omitted in the
single-argument case.
Changes by Nick Coghlan ncogh...@gmail.com:
Removed file: http://bugs.python.org/file23216/0001.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11682
___
Changes by Nick Coghlan ncogh...@gmail.com:
Removed file:
http://bugs.python.org/file23570/issue11682_pep380_branch_2031.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11682
___
Changes by Nick Coghlan ncogh...@gmail.com:
Removed file: http://bugs.python.org/file23759/0001-2.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11682
___
Changes by Nick Coghlan ncogh...@gmail.com:
Removed file: http://bugs.python.org/file23639/test.py
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11682
___
Changes by Nick Coghlan ncogh...@gmail.com:
--
hgrepos: -11
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11682
___
___
Python-bugs-list mailing
Nick Coghlan ncogh...@gmail.com added the comment:
OK, I removed all the old files and repo links (they're still available in the
history below if needed). (well, the link to Renaud's hg patch queue is gone,
but that's also present in one of the early comments). (Ron: your comment makes
me
Nick Coghlan ncogh...@gmail.com added the comment:
As far as *why* yield expressions aren't special cased the way generator
expressions are - just an oversight when yield expressions were added, no real
grand master plan. It's not a big deal in practice, so nobody has ever cared
enough to
Ron Adam ron3...@gmail.com added the comment:
Thanks for the updated links Nick.
There is a comment in the docs that recommends putting parentheses around any
yield expression that returns a value. So it is in agreement with that in the
function argument case.
The grammar I used does keep
Ron Adam ron3...@gmail.com added the comment:
There is a test for 'yield from' as a function argument without the extra
parentheses.
f(yield from x)
You do need them in the case of a regular yield.
f((yield)) or f((yield value))
Shouldn't the same rule apply in both cases?
*
Changes by Nick Coghlan ncogh...@gmail.com:
Added file: http://bugs.python.org/file23774/0d1d76f68750.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11682
___
Zbyszek Szmek zbys...@in.waw.pl added the comment:
Updated doc patch 0001-2.diff: following ncoghlan's request, the bulk of yield
documentation is kept in expressions.rst, and simple_stmts.rst mostly refers to
the other one. (In previous version it was the other way around).
After doing this
Nick Coghlan ncogh...@gmail.com added the comment:
*Any* expression can be used as a standalone statement and (since PEP 352 was
implemented) that now applies to 'yield' as well.
PEP 352 fundamentally changed the way yield was conceptualised within the
language - thinking of it as a statement
Changes by Zbyszek Szmek zbys...@in.waw.pl:
Removed file: http://bugs.python.org/file23217/0002.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11682
___
Zbyszek Szmek zbys...@in.waw.pl added the comment:
Nick Coghlan wrote:
I don't want to completely rearrange the yield related sections of the
language reference as part of incorporating this PEP. If you're happy
to submit a new pull request with a minimalist change just documenting
the new
Nick Coghlan ncogh...@gmail.com added the comment:
In reviewing Zbyszek's doc updates and comparing them against the Grammar, I
discovered a gratuitous change in the implementation: it allows a bare (i.e. no
parentheses) 'yield from' as an argument to a function, even when there's
multiple
Nick Coghlan ncogh...@gmail.com added the comment:
OK, the bitbucket repo now has a more sane version of the new Grammar ('yield
from' now requires parentheses wherever 'yield' does).
The updated test_grammar does a more thorough check of the expected acceptance
and rejection of yield
Yury Selivanov yseliva...@gmail.com added the comment:
It looks like there is a memory leak bug (on StopIteration exception instances).
Attached is the test to expose it.
It seems that adding 'Py_DECREF(e);' after
'PyErr_SetObject(PyExc_StopIteration, e);' in 'genobject.c' fixes the leak.
Nick Coghlan ncogh...@gmail.com added the comment:
Bitbucket repo and attached patch updated relative to latest get_opinfo branch
(which in turn was updated to apply cleanly against current CPython tip).
(I still need to incorporate the doc updates and look into adding keyword
argument
Changes by Nick Coghlan ncogh...@gmail.com:
Removed file: http://bugs.python.org/file22616/pep380-missing-docs.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11682
___
Changes by Nick Coghlan ncogh...@gmail.com:
Removed file:
http://bugs.python.org/file23096/issue11682_pep380_branch_20110904.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11682
___
Armin Ronacher armin.ronac...@active-4.com added the comment:
A little bit of input on this issue. Considering that exceptions are now
getting keyword arguments for things like import errors and other things for
attributes I would find it much better if StopIteration would follow that as
Éric Araujo mer...@netwok.org added the comment:
Doc patch 002 is not strictly related to PEP 380 but pertains more to #10289.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11682
___
Changes by Nick Coghlan ncogh...@gmail.com:
Removed file: http://bugs.python.org/file22616/pep380-missing-docs.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11682
___
Changes by Nick Coghlan ncogh...@gmail.com:
Added file: http://bugs.python.org/file22616/pep380-missing-docs.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11682
___
Nick Coghlan ncogh...@gmail.com added the comment:
I have updated the bitbucket repo with changes to address most of Benjamin's
review comments.
A few points of note:
- I agree in principle with the idea of splitting Yield and YieldFrom into
distinct AST nodes, but I'd prefer to focus on
Zbyszek Szmek zbys...@in.waw.pl added the comment:
Here are the un-reflowed documentation changes, as a patch this time. I've
split the changes in two:
0001 is the real documentation change
0002 is the link fixes [optional].
--
Added file:
Changes by Zbyszek Szmek zbys...@in.waw.pl:
Added file:
http://bugs.python.org/file23211/0002-Fix-references-to-__next__-__iter__-and-nearby-refer.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11682
Changes by Zbyszek Szmek zbys...@in.waw.pl:
Removed file:
http://bugs.python.org/file23210/0001-Document-the-yield-from-syntax-and-StopIteration-ret.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11682
Changes by Zbyszek Szmek zbys...@in.waw.pl:
Removed file:
http://bugs.python.org/file23211/0002-Fix-references-to-__next__-__iter__-and-nearby-refer.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11682
Changes by Zbyszek Szmek zbys...@in.waw.pl:
Added file:
http://bugs.python.org/file23212/0001-Document-the-yield-from-syntax-and-StopIteration-ret.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11682
Changes by Zbyszek Szmek zbys...@in.waw.pl:
Added file:
http://bugs.python.org/file23213/0002-Fix-references-to-__next__-__iter__-and-nearby-refer.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11682
Changes by Zbyszek Szmek zbys...@in.waw.pl:
Removed file:
http://bugs.python.org/file23212/0001-Document-the-yield-from-syntax-and-StopIteration-ret.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11682
Changes by Zbyszek Szmek zbys...@in.waw.pl:
Removed file:
http://bugs.python.org/file23213/0002-Fix-references-to-__next__-__iter__-and-nearby-refer.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11682
Changes by Zbyszek Szmek zbys...@in.waw.pl:
Added file: http://bugs.python.org/file23216/0001.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11682
___
Changes by Zbyszek Szmek zbys...@in.waw.pl:
Added file: http://bugs.python.org/file23217/0002.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11682
___
Zbyszek Szmek zbys...@in.waw.pl added the comment:
I've created some documentation... The patches are the bitbucket repo.
Nothing is added to the tutorial, because I think that this isn't material for
a newcomer to python. The tutorial doesn't mention generator.throw() and send()
either, just
Nick Coghlan ncogh...@gmail.com added the comment:
Uploaded a patch that should be complete. Note that my pep380 branch is based
on my get_opinfo branch (see #11816), so if you're applying patches manually
rather than updating directly from my sandbox with hg, you'll need to apply the
latest
Nick Coghlan ncogh...@gmail.com added the comment:
Actually, not assigning to Raymond for review yet, after all - I just noticed
there are some of Benjamin's review comments relating to cosmetic details
rather than functionality that I still need to address.
I'll kick it in Raymond's
Nick Coghlan ncogh...@gmail.com added the comment:
The pep380 branch in my bitbucket repo has been updated with the refactored
tests that Ryan Kelly put together at the PyconAU sprints (as well as being
brought up to speed with 3.x tip).
The update depends on the new dis.get_opinfo() API
Changes by Ryan Kelly r...@rfk.id.au:
--
nosy: +rfk
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11682
___
___
Python-bugs-list mailing list
Renaud Blanch rndbl...@gmail.com added the comment:
I can not comment on http://bugs.python.org/review/11682/, so a quick comment
here: Doc/whatsnew/3.3.rst patch gives me credit together with Greg Ewing for
the implementation, but I've only upgraded his patches to 3.3.
So, the following line:
Nick Coghlan ncogh...@gmail.com added the comment:
I moved my personal sandbox from hg.python.org to bitbucket, so it should be
easier for folks to build off the work in progress. (And fixed the typo in
Renaud's name - I at least had it right in ACKS. I also reworded the draft
attribution
Nick Coghlan ncogh...@gmail.com added the comment:
Once again got close to committing this, but then realised it is missing all
the necessary documentation updates for a core language change.
I have uploaded a patch that includes all the changes from Bitbucket as well as
the subsequent fixes
Nick Coghlan ncogh...@gmail.com added the comment:
Renaud has updated the patch on bitbucket to incorporate Greg's tests (still in
golden output form, but in a unittest/regrtest compatible way). That's a good
enough starting point for me - they can be refactored into proper assert based
tests
Renaud Blanch rndbl...@gmail.com added the comment:
I've just updated the pep380-test patch to make it slightly simpler (still in
golden output form though)
https://bitbucket.org/rndblnch/cpython-pep380/src/317eadf5e3e8/pep380-tests
--
___
Python
Changes by Andrew Svetlov andrew.svet...@gmail.com:
--
nosy: +asvetlov
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11682
___
___
Changes by Nick Coghlan ncogh...@gmail.com:
--
assignee: - ncoghlan
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11682
___
___
Python-bugs-list
Nick Coghlan ncogh...@gmail.com added the comment:
OK, this isn't going to be as simple as I thought it was. The big problem is
that the test suite from [1] needs to be refactored into a format that is
suitable for use in regrtest. That means porting them to either unittest or
doctest, as
Renaud Blanch rndbl...@gmail.com added the comment:
As nick said, the repo only host a patch queue.
the patch itself is visible here:
https://bitbucket.org/rndblnch/cpython-pep380/qseries?apply=tqs_apply=pep380
Or it can be download here in raw text:
Éric Araujo mer...@netwok.org added the comment:
(“Create patch” does not work for some reason, I’ll report that to the
metatracker in a few days if nobody does it first)
--
nosy: +eric.araujo
___
Python tracker rep...@bugs.python.org
Nick Coghlan ncogh...@gmail.com added the comment:
It's because it isn't a true Mercurial clone-and-update - it's a patch queue,
which the review generation code doesn't know how to interpret.
--
___
Python tracker rep...@bugs.python.org
Changes by Yury Selivanov yseliva...@gmail.com:
--
nosy: +Yury.Selivanov
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11682
___
___
Changes by Renaud Blanch rndbl...@gmail.com:
--
nosy: +rndblnch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11682
___
___
Python-bugs-list
New submission from Nick Coghlan ncogh...@gmail.com:
Creating an issue to track efforts to forward port the PEP 380 reference
implementation to Python 3.3.
--
hgrepos: 11
messages: 132213
nosy: ncoghlan
priority: normal
severity: normal
status: open
title: PEP 380 reference
Changes by Alex Gaynor alex.gay...@gmail.com:
--
nosy: +alex
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11682
___
___
Python-bugs-list mailing
66 matches
Mail list logo
