[issue11751] Increase distutils.filelist / packaging.manifest test coverage

Éric Araujo added the comment: It was actually already known: #6884 (and then found again: #14004). -- ___ Python tracker ___ ___ Pyt

[issue11751] Increase distutils.filelist / packaging.manifest test coverage

Éric Araujo added the comment: FYI the tests revealed a bug in the code on Windows: #13193 -- ___ Python tracker ___ ___ Python-bugs-

[issue11751] Increase distutils.filelist / packaging.manifest test coverage

Éric Araujo added the comment: Did the second idea as suggested by Ezio. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___

[issue11751] Increase distutils.filelist / packaging.manifest test coverage

Roundup Robot added the comment: New changeset 723517bf6708 by Éric Araujo in branch 'default': Make test_manifest pass on 2.4 and 2.5 (fixes #11751). http://hg.python.org/distutils2/rev/723517bf6708 -- ___ Python tracker

[issue11751] Increase distutils.filelist / packaging.manifest test coverage

Éric Araujo added the comment: Advice from Ezio Melotti: > I would keep the flags even if you don't need them > someone in the present or in the future might need them, and having them > doesn't harm -- ___ Python tracker

[issue11751] Increase distutils.filelist / packaging.manifest test coverage

Roundup Robot added the comment: New changeset 3dda26cfc1d7 by Éric Araujo in branch 'default': Increase test coverage for manifest (#11751). http://hg.python.org/distutils2/rev/3dda26cfc1d7 -- ___ Python tracker

[issue11751] Increase distutils.filelist / packaging.manifest test coverage

Éric Araujo added the comment: I’ve found the reason: #6665. fnmatch.translate (used by _glob_to_re was changed to support filenames with embedded newlines. I don’t think it’s a concern for us: As the input we give to _glob_to_re comes one line at a time from a file, we just never have file

[issue11751] Increase distutils.filelist / packaging.manifest test coverage

Éric Araujo added the comment: > Still can't reproduce It only shows in 2.4 and 2.5. > (though I got one failure and three other errors) If these are not covered in #13170, please add them to that report. -- ___ Python tracker

[issue11751] Increase distutils.filelist / packaging.manifest test coverage

Justin Love added the comment: Still can't reproduce (though I got one failure and three other errors) $ patch -p 1 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue11751] Increase distutils.filelist / packaging.manifest test coverage

Éric Araujo added the comment: Python 2.7 contains distutils, not distutils2. You’d have to clone hg.python.org/distutils2 and apply the patch I’m attaching. Thanks for the help! -- Added file: http://bugs.python.org/file23467/distutils2-manifest.diff __

[issue11751] Increase distutils.filelist / packaging.manifest test coverage

Justin Love added the comment: re: test_glob_to_re Could not reproduce (OS X 10.6) I built branch 2.7, and also tried the expressions from glob_to_re on my system 2.7 and 3.2, all returned the (?ms) version. -- ___ Python tracker

[issue11751] Increase distutils.filelist / packaging.manifest test coverage

Roundup Robot added the comment: New changeset 368134e10d09 by Éric Araujo in branch '2.7': Increase test coverage for distutils.filelist (#11751). http://hg.python.org/cpython/rev/368134e10d09 -- ___ Python tracker

[issue11751] Increase distutils.filelist / packaging.manifest test coverage

Roundup Robot added the comment: New changeset 866d098367c1 by Éric Araujo in branch '3.2': Increase test coverage for distutils.filelist (#11751). http://hg.python.org/cpython/rev/866d098367c1 New changeset ba894d8a2a57 by Éric Araujo in branch 'default': Merge #11751 from 3.2 http://hg.python

[issue11751] Increase distutils.filelist / packaging.manifest test coverage

Éric Araujo added the comment: I made a few edits and committed to distutils and packaging. Then I ported the packaging patch to distutils2, which supports Python 2.4-2.7, and got this failure: FAIL: test_glob_to_re (__main__.ManifestTestCase)

[issue11751] Increase distutils.filelist / packaging.manifest test coverage

Justin Love added the comment: Incorporated some formatting suggestions. Removed _actions. Just as well, as I accidentally left in the 'blarg' bogus action ;^) Added a test for implicit-include. Whether 'this cannot happen' can happen depends on the output of _parse_template_line. If you

[issue11751] Increase distutils.filelist / packaging.manifest test coverage

Éric Araujo added the comment: > Sorry, it's been sitting at the bottom of my starred list for months, > the prospect of reloading context always making it a little less > attractive than something else. I understand that very well :) > Error was caused by an actual change in behavior Ah, good,

[issue11751] Increase distutils.filelist / packaging.manifest test coverage

Justin Love added the comment: Sorry, it's been sitting at the bottom of my starred list for months, the prospect of reloading context always making it a little less attractive than something else. I turned out I had to update to even have 'packaging' Error was caused by an actual change in

[issue11751] Increase distutils.filelist / packaging.manifest test coverage

Éric Araujo added the comment: Hi Justin, is there any way I can help you move forward with this? Please tell if you don’t have the time, I can work on completing the patch. -- ___ Python tracker ___

[issue11751] Increase distutils.filelist / packaging.manifest test coverage

Changes by Éric Araujo : Added file: http://bugs.python.org/file22231/packaging-manifest.diff ___ Python tracker ___ ___ Python-bugs-list mail

[issue11751] Increase distutils.filelist / packaging.manifest test coverage

Éric Araujo added the comment: Hi! I cleaned up your patch and fixed a bug: you have to call sort before calling remove_duplicates (the result in your patch had two 'a' entries). > One line was marked as excluded because it was a "this cannot happen" > error, and I agreed. How about we add a