[issue11981] dupe self.fp.tell() in zipfile.ZipFile.writestr

2012-11-17 Thread Ezio Melotti
Ezio Melotti added the comment: Fixed, thanks for the patch! -- assignee: -> ezio.melotti resolution: -> fixed stage: commit review -> committed/rejected status: open -> closed versions: -Python 3.3 ___ Python tracker

[issue11981] dupe self.fp.tell() in zipfile.ZipFile.writestr

2012-11-17 Thread Roundup Robot
Roundup Robot added the comment: New changeset d51665f9a416 by Ezio Melotti in branch 'default': #11981: remove duplicate line. Patch by Johan Euphrosine. http://hg.python.org/cpython/rev/d51665f9a416 -- nosy: +python-dev ___ Python tracker

[issue11981] dupe self.fp.tell() in zipfile.ZipFile.writestr

2012-11-11 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: LGTM. -- stage: -> commit review versions: +Python 3.4 ___ Python tracker ___ ___ Python-bugs-lis

[issue11981] dupe self.fp.tell() in zipfile.ZipFile.writestr

2012-04-07 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- nosy: +storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.p

[issue11981] dupe self.fp.tell() in zipfile.ZipFile.writestr

2011-09-13 Thread Alan McIntyre
Alan McIntyre added the comment: I also can't see any file operations that might occur between the two .tell() calls, and a full test pass (including test_zipfile64) on the py3k development branch doesn't turn up any problems on Linux (2.6.38, x86_64) for me, so I agree the second .tell() cou

[issue11981] dupe self.fp.tell() in zipfile.ZipFile.writestr

2011-05-13 Thread Ezio Melotti
Ezio Melotti added the comment: I double checked the code on py3k and I think the second occurrence can be removed. -- nosy: +alanmcintyre versions: +Python 3.3 -Python 3.4 ___ Python tracker

[issue11981] dupe self.fp.tell() in zipfile.ZipFile.writestr

2011-05-05 Thread Johan Euphrosine
Johan Euphrosine added the comment: Here is a log that shows zinfo.header_offset value after each .tell() when running test_zipfile -- Added file: http://bugs.python.org/file21895/zinfo.header_offset.log ___ Python tracker

[issue11981] dupe self.fp.tell() in zipfile.ZipFile.writestr

2011-05-05 Thread Johan Euphrosine
Johan Euphrosine added the comment: I just find it while reading the source, for fixing #11980 zinfo.header_offset is only read in self._write_check, and it seems to me that no file operation are performed on self.fp between the two call. So I can't see see how it could different. Also the t

[issue11981] dupe self.fp.tell() in zipfile.ZipFile.writestr

2011-05-05 Thread Ezio Melotti
Ezio Melotti added the comment: Can you prove that the second one is useless (did it cause you any problem or did you just find it reading the source)? There might be reasons why there are two calls to fp.tell() (e.g. the result is different in the two places and/or zinfo.header_offset is read

[issue11981] dupe self.fp.tell() in zipfile.ZipFile.writestr

2011-05-03 Thread Johan Euphrosine
Changes by Johan Euphrosine : -- keywords: +patch title: duplicated self.fp.tell() in zipfile.ZipFile.writestr -> dupe self.fp.tell() in zipfile.ZipFile.writestr Added file: http://bugs.python.org/file21870/zipfile-fix-dupe-fp-tell.patch ___ Python t