Roundup Robot devnull@devnull added the comment:
New changeset 6c6923a406df by Victor Stinner in branch '2.7':
Issue #12057: Add tests for ISO 2022 codecs
http://hg.python.org/cpython/rev/6c6923a406df
New changeset 2a313ceaf17c by Victor Stinner in branch '3.2':
Issue #12057: Add tests for ISO
STINNER Victor victor.stin...@haypocalc.com added the comment:
We have know tests for some ISO 2022 codecs and the HZ codec, it's much better!
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
STINNER Victor victor.stin...@haypocalc.com added the comment:
Haypo, since you've created a new directory there are makefile
(and PC build file, I think) updates that will need to be made.
Can you review attached cjkencodings_dir.patch?
(This should be documented in the dev guide if it
Terry J. Reedy tjre...@udel.edu added the comment:
I presume and hope David meant the process, as I would have no idea how to add
a directory. And David did not seem completely sure.
--
___
Python tracker rep...@bugs.python.org
Roundup Robot devnull@devnull added the comment:
New changeset 10b23f1c8cb6 by Victor Stinner in branch '3.1':
Issue #12057: Add tests for the HZ encoding
http://hg.python.org/cpython/rev/10b23f1c8cb6
New changeset 3368d4a04e52 by Victor Stinner in branch '3.2':
(Merge 3.1) Issue #12057: Add
Roundup Robot devnull@devnull added the comment:
New changeset 3c724c3eaed7 by Victor Stinner in branch '2.7':
Issue #12057: Add tests for the HZ encoding
http://hg.python.org/cpython/rev/3c724c3eaed7
--
___
Python tracker rep...@bugs.python.org
R. David Murray rdmur...@bitdance.com added the comment:
Looks good to me. And I meant documenting the process for adding a directory.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12057
STINNER Victor victor.stin...@haypocalc.com added the comment:
iso2022_tests.patch: add some tests for ISO2022 encodings:
- testcase for iso2022_jp and iso2022_kr, iso2022_jp2 reuses iso2022_jp
testcase
- test some invalid byte sequences
--
Added file:
Roundup Robot devnull@devnull added the comment:
New changeset a024183e046f by Victor Stinner in branch '3.1':
Issue #12057: Add cjkencodings directory to the Makefile and Tools/msi/msi.py
http://hg.python.org/cpython/rev/a024183e046f
New changeset 4289cc96835e by Victor Stinner in branch
Roundup Robot devnull@devnull added the comment:
New changeset 8ba0192a0eb1 by Victor Stinner in branch '2.7':
Issue #12057: Add cjkencodings directory to the Makefile and Tools/msi/msi.py
http://hg.python.org/cpython/rev/8ba0192a0eb1
--
___
Python
STINNER Victor victor.stin...@haypocalc.com added the comment:
I think that issue #12100 should be fixed (wontfix/fixed) before this one.
--
dependencies: +Incremental encoders of CJK codecs reset the codec at each call
to encode()
___
Python
R. David Murray rdmur...@bitdance.com added the comment:
Haypo, since you've created a new directory there are makefile (and PC build
file, I think) updates that will need to be made. (This should be documented
in the dev guide if it isn't already.)
--
nosy: +r.david.murray
Roundup Robot devnull@devnull added the comment:
New changeset 83f4c270b27d by Victor Stinner in branch '2.7':
Issue #12057: Fix .hgeol and test_multibytecodec_support for the conversion of
http://hg.python.org/cpython/rev/83f4c270b27d
--
___
Python
STINNER Victor victor.stin...@haypocalc.com added the comment:
ISO 2022 encodings don't have tests neither: test_multibytecodec doesn't test
directly these encodings but it is Unit test for multibytecodec itself. We
may also add tests specific to ISO 2022 encodings:
- iso2022_kr
-
Roundup Robot devnull@devnull added the comment:
New changeset 16503022c4b8 by Victor Stinner in branch '3.1':
Issue #12057: Convert CJK encoding testcase BLOB into multiple text files
http://hg.python.org/cpython/rev/16503022c4b8
New changeset 370db8da308f by Victor Stinner in branch '3.2':
Roundup Robot devnull@devnull added the comment:
New changeset 1bd697cdd210 by Victor Stinner in branch '2.7':
Issue #12057: Convert CJK encoding testcase BLOB into multiple text files
http://hg.python.org/cpython/rev/1bd697cdd210
--
___
Python
STINNER Victor victor.stin...@haypocalc.com added the comment:
Oh, I specified the wrong issue number of my last 3 commits: test_linecache
failure is related to this issue.
New changeset 9a4d4506680a by Victor Stinner in branch '3.1':
Issue #11614: Fix test_linecache, cjkencodings_test.py
STINNER Victor victor.stin...@haypocalc.com added the comment:
I wanted for them to be treated as text files which are trackable
in CVS or subversion and to keep Python source codes free of any
non-ASCII characters
Mercurial supports binary file, I plan to mark the CJK testcases as binary
New submission from STINNER Victor victor.stin...@haypocalc.com:
All CJK codecs have tests except the chinese HZ codec, I don't know why.
But to add a test, I need to add data to Lib/test/cjkencodings_test.py and the
format of this file is not documented. It is not too difficult to understand
Changes by STINNER Victor victor.stin...@haypocalc.com:
Added file: http://bugs.python.org/file21966/convert_cjkencodings.py
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12057
___
Changes by STINNER Victor victor.stin...@haypocalc.com:
--
keywords: +patch
Added file: http://bugs.python.org/file21967/cjkencodings.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12057
Changes by STINNER Victor victor.stin...@haypocalc.com:
Removed file: http://bugs.python.org/file21967/cjkencodings.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12057
___
Changes by STINNER Victor victor.stin...@haypocalc.com:
Added file: http://bugs.python.org/file21968/cjkencodings.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12057
___
STINNER Victor victor.stin...@haypocalc.com added the comment:
convert_cjkencodings.py is script to replace Lib/test/cjkencodings_test.py by a
Lib/test/cjkencodings/ directory:
---
big5hkscs.txt
big5hkscs-utf8.txt
big5.txt
big5-utf8.txt
cp949.txt
cp949-utf8.txt
euc_jisx0213.txt
Changes by STINNER Victor victor.stin...@haypocalc.com:
--
dependencies: +HZ codec has no test
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12057
___
Changes by STINNER Victor victor.stin...@haypocalc.com:
--
dependencies: -HZ codec has no test
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12057
___
STINNER Victor victor.stin...@haypocalc.com added the comment:
New files should be marked as binary in Mercurial: add Lib/test/cjkencodings/*
= BIN in .hgeol.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12057
Terry J. Reedy tjre...@udel.edu added the comment:
Looking at cjkencodings.py the format is pretty clear. The file consists of one
statement that creates one dict that maps encoding names to a pair of (encoded)
byte strings. The bytes literals are entirely hex escapes, with a maximum of 16
Marc-Andre Lemburg m...@egenix.com added the comment:
Terry J. Reedy wrote:
Terry J. Reedy tjre...@udel.edu added the comment:
Looking at cjkencodings.py the format is pretty clear. The file consists of
one statement that creates one dict that maps encoding names to a pair of
(encoded)
STINNER Victor victor.stin...@haypocalc.com added the comment:
Looking at cjkencodings.py the format is pretty clear. The file
consists of one statement that creates one dict that maps encoding
names to a pair of (encoded) byte strings. The bytes literals are
entirely hex escapes, with a
STINNER Victor victor.stin...@haypocalc.com added the comment:
Le mercredi 11 mai 2011 à 17:27 +, Marc-Andre Lemburg a écrit :
Victor, could you please contact Hye-Shik Chang pe...@freebsd.org
before making significant changes to the test suite.
Good idea, done.
Wouldn't it be better to
STINNER Victor victor.stin...@haypocalc.com added the comment:
Lib/test/cjkencodings_test.py was created when CJK were introduced in Python:
changeset 31386 by Hye-Shik Chang hyes...@gmail.com.
Add CJK codecs support as discussed on python-dev. (SF #873597)
Several style fixes are suggested
Changes by STINNER Victor victor.stin...@haypocalc.com:
--
nosy: +hyeshik.chang
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12057
___
___
Terry J. Reedy tjre...@udel.edu added the comment:
Reading http://tools.ietf.org/html/rfc1843 suggests that the reason that there
is no HZ pair in cjkencodings.py is that it is not a cjkencoding. Instead it is
a formatter or meta-encoding for intermixing ascii codes and GB2312(-80) codes.
(I
Terry J. Reedy tjre...@udel.edu added the comment:
Reading http://tools.ietf.org/html/rfc1843 suggests that the reason that there
is no HZ pair in cjkencodings.py is that it is not a cjkencoding. Instead it is
a formatter or meta-encoding for intermixing ascii codes and GB2312(-80) codes.
(I
Changes by Terry J. Reedy tjre...@udel.edu:
--
Removed message: http://bugs.python.org/msg135802
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12057
___
Hyeshik Chang hyes...@gmail.com added the comment:
Hello, everyone!
The rationale why I chose to encode the test strings into a Python source code
was that I wanted for them to be treated as text files which are trackable in
CVS or subversion and to keep Python source codes free of any
37 matches
Mail list logo
