[issue12240] Allow multiple setup_hooks
Éric Araujo mer...@netwok.org added the comment: The tests were failing on builbots with an ASCII locale. The config files have to be opened with an explicit encoding='utf-8' argument. Let’s remember it for the future :) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12240 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12240] Allow multiple setup_hooks
Erik Bray erik.m.b...@gmail.com added the comment: Good to know! The majority of my development is still on 2.x so it's easy to forget things like that. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12240 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12240] Allow multiple setup_hooks
Roundup Robot devnull@devnull added the comment: New changeset 5f0cd4844061 by Éric Araujo in branch 'default': Allow multiple setup hooks in packaging’s setup.cfg files (#12240). http://hg.python.org/cpython/rev/5f0cd4844061 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12240 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12240] Allow multiple setup_hooks
Éric Araujo mer...@netwok.org added the comment: Done. -- assignee: tarek - eric.araujo resolution: - fixed stage: - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12240 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12240] Allow multiple setup_hooks
Erik Bray erik.m.b...@gmail.com added the comment: Here's an update with tests. It should be applied after my patch for issue11595. -- Added file: http://bugs.python.org/file22299/python_issue12240-2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12240 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12240] Allow multiple setup_hooks
Erik Bray erik.m.b...@gmail.com added the comment: Adds support for multiple setup_hooks and updates the docs. For now I left the option name as setup_hook, though it might make sense to rename it to setup_hooks for consistency's sake. -- keywords: +patch Added file: http://bugs.python.org/file22264/python_issue12240.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12240 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12240] Allow multiple setup_hooks
Éric Araujo mer...@netwok.org added the comment: I can’t see why not. Would you like to work on a patch? -- versions: +Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12240 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12240] Allow multiple setup_hooks
Erik Bray erik.m.b...@gmail.com added the comment: Great! I'll add a patch shortly. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12240 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12240] Allow multiple setup_hooks
New submission from Erik Bray erik.m.b...@gmail.com: I have a use case where I have a small library of setup_hook functions for various purposes that are used by multiple projects. Some projects may want to use more than one of these setup_hooks. I can certainly create a wrapper hook for each function that calls all the necessary hooks. But that gets a little tedious and seems unnecessary. In this use case it would be fine if I could just list a set of setup_hooks to be executed in sequence. It is, of course, up the developer to be sure that none of these setup_hooks have conflicting actions. As a temporary workaround I wrote a setup_hook called chain_setup_hooks. I then looks for an option called setup_hooks which behaves as I've described. This works fine, though I don't see why setup_hook shouldn't allow multiple values to begin with. -- assignee: tarek components: Distutils2 messages: 137479 nosy: alexis, eric.araujo, erik.bray, tarek priority: normal severity: normal status: open title: Allow multiple setup_hooks type: feature request ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12240 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
