David Lam d...@dlam.me added the comment:
Wow, cool! Thanks for the update.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12537
___
___
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 5c1c402a63e5 by R David Murray in branch 'default':
#12537: in mailbox avoid depending on knowledge of email package internals
http://hg.python.org/cpython/rev/5c1c402a63e5
--
nosy: +python-dev
R. David Murray rdmur...@bitdance.com added the comment:
David, thanks for your assistance. I didn't wind up using your patch, but the
work you did was valuable in preparing the patch I committed.
What I did was turn your 'detect the attributes' recipe into a unit test. I
then applied your
David Lam d...@dlam.me added the comment:
This patch deletes the leftover special attributes.
Thanks for guiding me through my confusion and/or cluelessness!
--
keywords: +patch
Added file: http://bugs.python.org/file23191/12537.patch
___
Python
Changes by David Lam d...@dlam.me:
Added file:
http://bugs.python.org/file23192/12537.find.attribute.differences.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12537
___
R. David Murray rdmur...@bitdance.com added the comment:
Unfortunately I don't think there is any way except going through each subclass
to see what special attributes it creates.
--
___
Python tracker rep...@bugs.python.org
David Lam d...@dlam.me added the comment:
Hm, it seems right now that the only time that happens is when creating a
message based on an mbox message. The 'status' and 'x-status' attributes are
deleted.
Any hints on what I could to do figure out what special attributes should be
deleted? I
David Lam d...@dlam.me added the comment:
Hi hi, noob here. I found this today after clicking 'Easy issues' link.
Would something like this work? test_mailbox.py seems to pass. However, I'm
not too sure what more needs to be done in the _explain_to. It seems like
everything to convert
R. David Murray rdmur...@bitdance.com added the comment:
That is the first step, yes. In addition to that we need to have the various
explain_to methods delete the special attributes that aren't valid for the new
Message subtype.
--
___
Python
Changes by Justin Wehnes jweh...@gmail.com:
--
nosy: +jwehnes
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12537
___
___
Python-bugs-list mailing
Changes by Kasun Herath kasun...@gmail.com:
--
nosy: +kasun
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12537
___
___
Python-bugs-list mailing
New submission from R. David Murray rdmur...@bitdance.com:
The mailbox module has a method _become_message that copies attributes from an
object that is an email.message.Message subclass to the calling object (which
is also a subclass of email.message.Message). This method is very fragile in
Changes by Thomas Holmes tho...@devminded.com:
--
nosy: +thomas.holmes
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12537
___
___
José María Ruiz Aguilera josemariar...@gmail.com added the comment:
Hi, I will be working on this issue. This is the first time I will work on a
issue in Python so please patient.
--
nosy: +josemaria
___
Python tracker rep...@bugs.python.org
14 matches
Mail list logo
