[issue1261] PEP 3137: make bytesobject.c methods

2007-10-16 Thread Gregory P. Smith
Gregory P. Smith added the comment: Committed revision 58493 -- resolution: - accepted status: open - closed __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1261 __ ___

[issue1261] PEP 3137: make bytesobject.c methods

2007-10-15 Thread Guido van Rossum
Guido van Rossum added the comment: Is it worth my time to review this yet? __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1261 __ ___ Python-bugs-list mailing list

[issue1261] PEP 3137: make bytesobject.c methods

2007-10-15 Thread Gregory P. Smith
Changes by Gregory P. Smith: __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1261 __ ___ Python-bugs-list mailing list Unsubscribe:

[issue1261] PEP 3137: make bytesobject.c methods

2007-10-15 Thread Guido van Rossum
Guido van Rossum added the comment: Very impressive! (Apologies if these lines are occasionally out of order.) +extern PyObject* _bytes_isspace(const char *cptr, const Py_ssize_t len); IMO all these functions should have names starting with _Py or _Py_, since they are visible to the linker.

[issue1261] PEP 3137: make bytesobject.c methods

2007-10-15 Thread Gregory P. Smith
Changes by Gregory P. Smith: __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1261 __ ___ Python-bugs-list mailing list Unsubscribe:

[issue1261] PEP 3137: make bytesobject.c methods

2007-10-15 Thread Gregory P. Smith
Changes by Gregory P. Smith: __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1261 __ ___ Python-bugs-list mailing list Unsubscribe:

[issue1261] PEP 3137: make bytesobject.c methods

2007-10-15 Thread Guido van Rossum
Guido van Rossum added the comment: Good! Check it in before I change my mind. :-) The words can be tweaked later. 04b is the same as 04, i just fixed the docstrings that i had missed in stringlib/transmogrify.h to use 'B' instead of 'S' and say they return a modified copy of B instead of a

[issue1261] PEP 3137: make bytesobject.c methods use PEP 3118 buffer API

2007-10-11 Thread Gregory P. Smith
New submission from Gregory P. Smith: This makes all existing bytesobject.c methods use the buffer API rather than explicitly requiring bytes objects as input. It also fixes input to append() and remove() that was not strict enough and improves a few unit tests in that area. NOTE: this patch

[issue1261] PEP 3137: make bytesobject.c methods use PEP 3118 buffer API

2007-10-11 Thread Guido van Rossum
Changes by Guido van Rossum: -- assignee: - gvanrossum nosy: +gvanrossum __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1261 __ ___ Python-bugs-list mailing list

[issue1261] PEP 3137: make bytesobject.c methods

2007-10-11 Thread Gregory P. Smith
Changes by Gregory P. Smith: __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1261 __ ___ Python-bugs-list mailing list Unsubscribe:

[issue1261] PEP 3137: make bytesobject.c methods

2007-10-11 Thread Guido van Rossum
Guido van Rossum added the comment: Patch updated. It now implements the is*() methods for PyBytes. It moves common code into a shared bytes_ctype.c and .h file so that stringobject.c and bytesobject.c can share as much as possible. Did you move this into the stringlib subdirectory? That's

[issue1261] PEP 3137: make bytesobject.c methods

2007-10-11 Thread Gregory P. Smith
Gregory P. Smith added the comment: Patch updated. It now implements the is*() methods for PyBytes. It moves common code into a shared bytes_ctype.c and .h file so that stringobject.c and bytesobject.c can share as much as possible. Did you move this into the stringlib subdirectory?

[issue1261] PEP 3137: make bytesobject.c methods

2007-10-11 Thread Gregory P. Smith
Changes by Gregory P. Smith: __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1261 __ ___ Python-bugs-list mailing list Unsubscribe:

[issue1261] PEP 3137: make bytesobject.c methods

2007-10-11 Thread Gregory P. Smith
Changes by Gregory P. Smith: -- nosy: -gps __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1261 __ ___ Python-bugs-list mailing list Unsubscribe: