[issue12715] Add symlink support to shutil functions

Antoine Pitrou added the comment: Patch is now applied to 3.3, thank you for your patience :) -- resolution: -> fixed stage: commit review -> committed/rejected status: open -> closed ___ Python tracker _

[issue12715] Add symlink support to shutil functions

Roundup Robot added the comment: New changeset cf57ef65bcd0 by Antoine Pitrou in branch 'default': Issue #12715: Add an optional symlinks argument to shutil functions (copyfile, copymode, copystat, copy, copy2). http://hg.python.org/cpython/rev/cf57ef65bcd0 -- nosy: +python-dev __

[issue12715] Add symlink support to shutil functions

Antoine Pitrou added the comment: I've checked the latest patch to work fine under Windows 7 (and Linux, of course). -- stage: -> commit review ___ Python tracker ___

[issue12715] Add symlink support to shutil functions

Hynek Schlawack added the comment: Added new patch with protection for the remaining UF_NODUMPs in the test case. All raised issues should be fixed now. :) -- ___ Python tracker __

[issue12715] Add symlink support to shutil functions

Changes by Hynek Schlawack : Added file: http://bugs.python.org/file24102/8330f2045f4d.diff ___ Python tracker ___ ___ Python-bugs-list mailin

[issue12715] Add symlink support to shutil functions

Hynek Schlawack added the comment: Added another patch fixing the issues pointed out by Antoine and Charles-François. -- ___ Python tracker ___

[issue12715] Add symlink support to shutil functions

Changes by Hynek Schlawack : Added file: http://bugs.python.org/file24099/23e6204efe20.diff ___ Python tracker ___ ___ Python-bugs-list mailin

[issue12715] Add symlink support to shutil functions

Hynek Schlawack added the comment: The patch contains also the necessary changes for the docs now. Please let me know, if I can do anything else. -- ___ Python tracker ___

[issue12715] Add symlink support to shutil functions

Changes by Hynek Schlawack : Added file: http://bugs.python.org/file24070/d9212bb67f64.diff ___ Python tracker ___ ___ Python-bugs-list mailin

[issue12715] Add symlink support to shutil functions

Hynek Schlawack added the comment: Thanks to Antoine & Charles-François for their reviews! I think I've incorporated all desired changes. Please let me know if I have missed something, meanwhile I'll tackle the docs. -- ___ Python tracker

[issue12715] Add symlink support to shutil functions

Changes by Hynek Schlawack : Added file: http://bugs.python.org/file24069/4832bf7aa028.diff ___ Python tracker ___ ___ Python-bugs-list mailin

[issue12715] Add symlink support to shutil functions

Antoine Pitrou added the comment: I've done a review at http://bugs.python.org/review/12715 -- nosy: +pitrou ___ Python tracker ___ _

[issue12715] Add symlink support to shutil functions

Hynek Schlawack added the comment: I have updated the patch to latest default/tip and would appreciate a review. -- ___ Python tracker ___ __

[issue12715] Add symlink support to shutil functions

Changes by Hynek Schlawack : Added file: http://bugs.python.org/file24067/c92c4d936255.diff ___ Python tracker ___ ___ Python-bugs-list mailin

[issue12715] Add symlink support to shutil functions

Changes by Antoine Pitrou : -- nosy: +haypo, neologix ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://ma

[issue12715] Add symlink support to shutil functions

Changes by Hynek Schlawack : -- keywords: +patch Added file: http://bugs.python.org/file23028/e126ceae5ba9.diff ___ Python tracker ___ ___

[issue12715] Add symlink support to shutil functions

Hynek Schlawack added the comment: What started as a 2 lines fix, grew to a patch of ~400 lines. :) It's mostly tests though: Lib/shutil.py | 102 +-- Lib/test/test_shutil.py | 220 +

[issue12715] Add symlink support to shutil functions

Changes by Марк Коренберг : -- nosy: +mmarkk ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue12715] Add symlink support to shutil functions

Hynek Schlawack added the comment: We have an edge case when the caller calls copymode with symlinks=True on an OS that doesn't have lchmod (ie any other than FreeBSD). Should it be a nop (as in copystat), use chmod or raise an Exception? I Personally (and some people on #python-dev) believe

[issue12715] Add symlink support to shutil functions

Éric Araujo added the comment: Other reports related to shutil and symlinks: #9993, #4489, #12461. -- ___ Python tracker ___ ___ Pyth

[issue12715] Add symlink support to shutil functions

Hynek Schlawack added the comment: JFTR, my implementation is ready, but I can't/don't want to start writing tests, as long as #12721 is open. -- ___ Python tracker ___ ___

[issue12715] Add symlink support to shutil functions

Petri Lehtinen added the comment: > Doing what UNIX’ cp program does would be best here. $ cp --version cp (GNU coreutils) 8.5 $ touch file $ ln -s file link_to_file $ mkdir directory $ ln -s directory link_to_directory $ cp -a link_to_file link_to_directory $ ls -l directory lrwxrwxrwx 1 use

[issue12715] Add symlink support to shutil functions

Éric Araujo added the comment: > Problem: What if dst is a symlink to a directory? Should it be > replaced or should the symlink copied inside that directory? Doing what UNIX’ cp program does would be best here. -- nosy: +eric.araujo ___ Python trac

[issue12715] Add symlink support to shutil functions

Hynek Schlawack added the comment: Additionally copyfile() might be fixed to understand symlinks=True too. Currently working on a patch for all 5 of them. -- ___ Python tracker ___

[issue12715] Add symlink support to shutil functions

Petri Lehtinen added the comment: We could also have symlinks='require' to have copymode() and copystat() raise an error unless both src and dst are symlinks. -- ___ Python tracker ___

[issue12715] Add symlink support to shutil functions

New submission from Petri Lehtinen : The shutil.copytree() function aknowledges symlinks when given the symlink=True argument. Other shutil functions should do this too: copymode(src, dst, symlinks=True) If both src and dst are symlinks, copy the source symlink mode to the destination syml