Éric Araujo mer...@netwok.org added the comment:
Thanks!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12804
___
___
Python-bugs-list mailing
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 585d3664da89 by Nadeem Vawda in branch 'default':
Issue #12804: Fix test failures on systems without internet access.
http://hg.python.org/cpython/rev/585d3664da89
--
___
Changes by Nadeem Vawda nadeem.va...@gmail.com:
--
resolution: - fixed
stage: needs patch - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12804
___
Éric Araujo mer...@netwok.org added the comment:
Actually, the skip system is already supposed to work for that if used
properly (see test.support.transient_internet()). However, perhaps it
actually doesn't work in all situations.
It’s better than that: nearly all tests requiring network
Ezio Melotti ezio.melo...@gmail.com added the comment:
FWIW there's also support.open_urlresource that can be used to download test
data. open_urlresouce calls requires('urlfetch') and skips the test when the
resource is not enabled. For instance, test_normalization uses it:
try:
Nadeem Vawda nadeem.va...@gmail.com added the comment:
Change reverted. make test should run a comprehensive test of
Python's facilities
Fair enough.
If it is easy to detect network availability programmatically, we could
just use the skip system.
+1. I don't know if there is a reasonable
Antoine Pitrou pit...@free.fr added the comment:
If it is easy to detect network availability programmatically, we could
just use the skip system.
+1. I don't know if there is a reasonable way to do this, but if so, that
would be the best solution.
Actually, the skip system is already
Nadeem Vawda nadeem.va...@gmail.com added the comment:
Oh, neat. I'll take a look at that when I get a chance.
--
assignee: - nadeem.vawda
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12804
